From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <roszenrami@gmail.com>
Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com
 [209.85.167.196]) by dpdk.org (Postfix) with ESMTP id BDCC34C9D;
 Tue, 25 Dec 2018 20:29:21 +0100 (CET)
Received: by mail-oi1-f196.google.com with SMTP id c206so11820849oib.0;
 Tue, 25 Dec 2018 11:29:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=PPv8wkgDKZikfThDBpWw75vgF9ulJFGAOsLua5pv/VI=;
 b=qq0E3Gn0IHNwZwd6A58CKj8iF6JIyHuGw0sqeLSMspBqEMBJA456rHjfjBw4/pkWpt
 vR4hOiWEVzpWPpORMnzSAu4r7Qc9JJy88FF4KfZ25zLSjBl9ovuQ2w35N5X46YhhV+37
 GgPvyau6bJp1zgRrXAUaa1x49L0oGCjALB7JwDL40ov8VafBjgon+E3DNoxrYLW8oWdz
 fl+CaOIvoUsUB6bAbBoZjJDNQ4u7vFNWITjgfTqWJ06iPbcAPNU5KQetB7XQsmCZcP1Y
 3RIk2rOfAh1uy/V0pPPj5CAT65thc8a4Tka3Vgva2pU0+TwxUw94h8FqAbRMN9Qn2P29
 frhg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=PPv8wkgDKZikfThDBpWw75vgF9ulJFGAOsLua5pv/VI=;
 b=Ba2ypbwJnERp+nZ2qCTn289lL9BAX5EikCf9GUSLfz8wWQqOwEd8USG4tNiNxkw4Tq
 SnndHBBXh79xS+4P+9fPAAg73oShHdH22tjiVpwBTR3BPb74qX6IYlbvk3EgLKLfsads
 f2Gt3v5uiJCPgNokJZp0NnnT/0XH1frSqQiydK4+w1xVbTOwu54m+Dk3Jgb1zdVBavD0
 J82hy3N6W2viPqbLlEF+fipGAlDZxuTeRVt2VsUqfVh96b4hBvFvsc2FW2cY7DzQCc6f
 Vxcbic66T9ThjhDDE1gpkYwdT5qFv+nvDYblZCNdxrLQJRhCN36Sd31DWORmzk8kKFrP
 BCEA==
X-Gm-Message-State: AA+aEWZv4wZBoz17eyQ4HJ3ECip2aE9nJtJ63eF9Aghlz2vsfVf1oCwB
 YngXkL42zHFb4HDq6JIkDt/jQdVj33q8jGVvLaE=
X-Google-Smtp-Source: AFSGD/Vo8w8ZgqNOuYHw9RVrIDcEbYBRHqUFlXW5GYN+YCgM8HiWtLk/n8sIMnPZW+cHY7gqVT87ScpWLoWHbwKVLLw=
X-Received: by 2002:aca:dc46:: with SMTP id t67mr10454752oig.279.1545766161007; 
 Tue, 25 Dec 2018 11:29:21 -0800 (PST)
MIME-Version: 1.0
References: <1545136604-22816-1-git-send-email-salehals@mellanox.com>
In-Reply-To: <1545136604-22816-1-git-send-email-salehals@mellanox.com>
From: Rami Rosen <roszenrami@gmail.com>
Date: Tue, 25 Dec 2018 21:29:12 +0200
Message-ID: <CAKoUArnYfH3q8Mm0zSGVbyAtpe2Yhn_W1O1dVDJ6UJF1mhAmrw@mail.gmail.com>
To: Saleh Alsouqi <salehals@mellanox.com>
Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, 
 dev@dpdk.org, Ori Kam <orika@mellanox.com>, stable@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix mpls encap ipv4 version and
	ihl
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Dec 2018 19:29:22 -0000

Hi Saleh,
Thanks for your patch.
If you will grep into the DPDK repo you will see that there are several
occurrences of IP_VHL_DEF, with the same functionality.
I would consider putting the IPV4_VHL_DEF you added in a more generic
location and not
under testpmd, so other modules will be able to use it without the need to
include testpmd.h, which is a bit awkard.
Another question is whether it should be IPV4_VHL_DEF or IPV_VHL_DEF as in
other DPDK apps. Probably other apps should be adjusted to use it.

Regards,
Rami Rosen