From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C12FA050A; Tue, 12 Apr 2022 18:11:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAD6340DF6; Tue, 12 Apr 2022 18:11:51 +0200 (CEST) Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by mails.dpdk.org (Postfix) with ESMTP id 9CA5D4014F; Tue, 12 Apr 2022 18:11:51 +0200 (CEST) Received: by mail-yb1-f175.google.com with SMTP id m132so4677463ybm.4; Tue, 12 Apr 2022 09:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ewn/y7NJNSEZkN/sqt9FnBKm80TLNPM28o78ybelnMI=; b=bVL0+gv7nMRIaTO0JkEGHtPViiv/i6tJF02PtUACgd3gvtxbRYfSHfGctiCBiwllMq Cs+dAA8dLmiLLK9qko8AWZntKEPomltFUqtpoU9ZKcugVvMbzFi9dlZkMEVOs+d+qOac 41xQng693eCMoDP8gzUCdCiJoRKWURFwqE1N++YtsBFy0PS8DVeQBmSDok4PNnUuvEDR TCM8XMPUCIpRnGHuLL2xnjHZZ/V6up/bduH0EGOqq19OQUUV7sFwsHIV5LDgbnXugatz 1ffAc8wRUUGHBgD8YI+PQuISQYBhtMHKrpsc9BlaS2R3OL23fjKs23LMlnF/8ofGr1Zu zsHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ewn/y7NJNSEZkN/sqt9FnBKm80TLNPM28o78ybelnMI=; b=RiG9dYpe4fDTdlT9ITvqVxw1h+T/giV4qMaK3+t/QgYivyXMfpEd8o3MVtv9+/zqXy SeC6GC9b6vq0AaRQ7QcCaJRUcVLbqRQzqigQrNRL71XX+Wcj4/fGfc2duQm2myuaP1YT EyNykJF/jowK7VFlZCzFj5Bj7j4iiU/Jl9rBuC0kJRXkJ1wmHDp2mZuhR6Yxc3hQ8vWi TacXyDCxog+F0+h3esTVE051gNUGvr1gshOtz03p59zX/C3XYlJQ1aC2YwWizUYMQcbW 4N4Y9o37q8GpQOz9Qtsy5ccULNusb34P7xRIXai0D7UsFMSm5FfqWhrWWVDe4CiK9SCb 8H7g== X-Gm-Message-State: AOAM532/aSxxin9hcKsL0gouqyh2Qj4aCTIiZgTo8Atu5g4U7Z5whJxp SmzGnPIMXKTOcR136oVjy4mLlf3bNS3+0SA8Mhs= X-Google-Smtp-Source: ABdhPJzUjLQxogCzN29F6gy1bjVpLiC+6rB2uF11nalBJe88DGTrvRKkG60Au1RSpg8Ll744mHCqR1R9NisViqRaguI= X-Received: by 2002:a25:7256:0:b0:641:5deb:b1a5 with SMTP id n83-20020a257256000000b006415debb1a5mr7791634ybc.246.1649779911048; Tue, 12 Apr 2022 09:11:51 -0700 (PDT) MIME-Version: 1.0 References: <20220404005634.2657-1-koncept1@gmail.com> <98CBD80474FA8B44BF855DF32C47DC35D86F9B@smartserver.smartshare.dk> <95d923da-0216-9a66-2713-17f0a6442a0c@redhat.com> <3423184.iIbC2pHGDl@thomas> In-Reply-To: From: Ben Magistro Date: Tue, 12 Apr 2022 12:11:40 -0400 Message-ID: Subject: Re: [PATCH] mbuf: expose outer vlan in mbuf dump To: Olivier Matz Cc: Thomas Monjalon , =?UTF-8?Q?Morten_Br=C3=B8rup?= , dev@dpdk.org, ben.magistro@trinitycyber.com, Stefan Baranoff , stable@dpdk.org, Luca Boccassi , Christian Ehrhardt , "Xueming(Steven) Li" , Kevin Traynor Content-Type: multipart/alternative; boundary="0000000000008e434405dc7751bb" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000008e434405dc7751bb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Was there a consensus on if this should be re-drafted as a bug and fixes or left as a backportable feature/improvement? I am good either way, just wanted to clarify if I had an additional action at this time. Cheers On Wed, Apr 6, 2022 at 3:33 AM Olivier Matz wrote: > Hi, > > On Tue, Apr 05, 2022 at 05:51:05PM +0200, Thomas Monjalon wrote: > > 04/04/2022 12:33, Kevin Traynor: > > > On 04/04/2022 07:15, Morten Br=C3=B8rup wrote: > > > >> From: Ben Magistro [mailto:koncept1@gmail.com] > > > >> Sent: Monday, 4 April 2022 02.57 > > > >> > > > >> Enable printing of the outer vlan if flags indicate it is present. > > > >> > > > >> Signed-off-by: Ben Magistro > > Acked-by: Olivier Matz > > > > >> > > > >> --- > > > >> > > > >> While troubleshooting some QinQ offloads with various Intel i40e > > > >> firmware[1], it was > > > >> helpful to expose the outer vlan in the dump mbuf calls. This > should > > > >> be straightforward > > > >> to backport and happy to do the work if accepted. I understand tha= t > > > >> this may not be a > > > >> widely supported capability at this time, so we are okay if this i= s > not > > > >> accepted and > > > >> we just maintain a local patch. > > > > > > > > Features are usually not backported, only bug fixes. > > > > > > > > However, since this patch proved helpful finding a bug, and it is > very simple, it could be considered by the LTS maintainers. > > > > > > > > > Suggest to tag the patch with 'Cc: stable@dpdk.org' to indicate it is > > > requested for stable branches. It will be caught by stable maintainer > > > filters when it is time for backports and can be discussed further > then. > > > > I think it is a bug. > > What was introduced first? the function or the field? > > Please find the commit where it should have been done > > and mark it with "Fixes:" syntax + Cc:stable. > > The vlan dump was introduced by commit 5b6eaea8ea7c ("mbuf: display more > fields in dump"), but I don't think we can say it's a bug. To me, it is > an enhancement that could be backported, because there is a benefit with > a very low risk. > --0000000000008e434405dc7751bb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Was there a consensus on if this should be re-drafted as a= bug and fixes or left as a backportable feature/improvement?=C2=A0 I am go= od either way, just wanted to clarify=C2=A0if I had an additional action at= this time.

Cheers

On Wed, Apr 6, 2022 at 3:33 AM O= livier Matz <olivier.matz@6win= d.com> wrote:
Hi,

On Tue, Apr 05, 2022 at 05:51:05PM +0200, Thomas Monjalon wrote:
> 04/04/2022 12:33, Kevin Traynor:
> > On 04/04/2022 07:15, Morten Br=C3=B8rup wrote:
> > >> From: Ben Magistro [mailto:koncept1@gmail.com]
> > >> Sent: Monday, 4 April 2022 02.57
> > >>
> > >> Enable printing of the outer vlan if flags indicate it i= s present.
> > >>
> > >> Signed-off-by: Ben Magistro <koncept1@gmail.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

> > >>
> > >> ---
> > >>
> > >> While troubleshooting some QinQ offloads with various In= tel i40e
> > >> firmware[1], it was
> > >> helpful to expose the outer vlan in the dump mbuf calls.= =C2=A0 This should
> > >> be straightforward
> > >> to backport and happy to do the work if accepted. I unde= rstand that
> > >> this may not be a
> > >> widely supported capability at this time, so we are okay= if this is not
> > >> accepted and
> > >> we just maintain a local patch.
> > >
> > > Features are usually not backported, only bug fixes.
> > >
> > > However, since this patch proved helpful finding a bug, and = it is very simple, it could be considered by the LTS maintainers.
> >
> >
> > Suggest to tag the patch with 'Cc: stable@dpdk.org' to indicate it is
> > requested for stable branches. It will be caught by stable mainta= iner
> > filters when it is time for backports and can be discussed furthe= r then.
>
> I think it is a bug.
> What was introduced first? the function or the field?
> Please find the commit where it should have been done
> and mark it with "Fixes:" syntax + Cc:stable.

The vlan dump was introduced by commit 5b6eaea8ea7c ("mbuf: display mo= re
fields in dump"), but I don't think we can say it's a bug. To = me, it is
an enhancement that could be backported, because there is a benefit with a very low risk.
--0000000000008e434405dc7751bb--