From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it1-f195.google.com (mail-it1-f195.google.com [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id 51A7B28FD for ; Tue, 7 May 2019 11:57:58 +0200 (CEST) Received: by mail-it1-f195.google.com with SMTP id l10so25380911iti.3 for ; Tue, 07 May 2019 02:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bDD/3yHGQoQF8HXx6bMOzbtY19ZlW9ibxPi7xAlglGM=; b=IKyRISNlWJKgIz4+DrRwAupY/XfBj1O65zrMOIMMBAZeE6RLdVlbpYxHdlapLjLFHO zYuuwLRz6D+TfkziVaRzBzsl0cU0irdu5o01fyHHQZpEy04kzgKxR1tKUJcw92MXgV1o iUpaY0zGGc6ctpsqTzrXI/3TIW0DUjJcMAypH1uX8wh1aCBjRzmR/y6+WlikEI7PrYan BcUA0sosVVaMUuQa4RSzWJhBdh2LMVF0WownyxNsDOS0sTyYkl4kuWLYtMTXNhgWdIvv 1ZfK84JlYHsslyqDqnOSgJ5B3+y/WKRrOc/C6eEHbYY9N5Lsxtqu7H75ygf1Ikj17f51 XpLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bDD/3yHGQoQF8HXx6bMOzbtY19ZlW9ibxPi7xAlglGM=; b=IO/Xc4wavVlrJ1g2KgouBA7/eVYggq8uIgPMPx07mQ73XKkNT5dyvI48ZioNtfwua+ 4XImEhEDSHjvidE3/j+Qv2olUragDAhj0dqpuD0b8nfD2XquxtmMzn0xbrd2pCHCcqy7 agD+B56VgmPyYJbTk3OTYcQqykQmAyLGjWVr2WbpZO+K7PlJxqTVFOrHv5kP41xG+APK COvOQGUwOf5uhThhr/OE8SiuaQqUuw98Joj2S0oH6b6cVmE6JqZUEHbKEa18RpwwaPpT NJSwi4M5LHiU8MhsXqru4u4zrzicij9KTi/cItV6KmI0ZxDzKuZbCIoVDL95Yz25pb56 4wYw== X-Gm-Message-State: APjAAAVz6bzMuDCw9oHEYn8HgXJ/vX6Yc2ZGi/hERRhXLzUDguhq5AMc 7Pz/L9OkXU4q4S/7StTnZy+0efOsljW6vDCa99EoHg== X-Google-Smtp-Source: APXvYqxBWK/T9aEE5mperhfgpmfUezJSiZYHqVVIyZDY62ksIdoQ0OlvRbSw829XyfcaKoKhqr/9Fiq2R3fmitWhwnI= X-Received: by 2002:a24:5d81:: with SMTP id w123mr14914703ita.11.1557223077565; Tue, 07 May 2019 02:57:57 -0700 (PDT) MIME-Version: 1.0 References: <1556463528-22853-1-git-send-email-arnon@qwilt.com> <20190428092357.66ae2b80@hermes.lan> <20190429092430.4e71a9ab@hermes.lan> <3c8183ba-7140-784f-d690-a279e1aff30c@intel.com> In-Reply-To: <3c8183ba-7140-784f-d690-a279e1aff30c@intel.com> From: Arnon Warshavsky Date: Tue, 7 May 2019 12:57:46 +0300 Message-ID: To: Ferruh Yigit Cc: Stephen Hemminger , dev@dpdk.org, Thomas Monjalon , "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , Jerin Jacob , Bruce Richardson , ranjit.menon@intel.com, anand.rawat@intel.com, Pallavi Kadam , Harini Ramakrishnan , "O'Hare, Cathal" , Arnon Warshavsky Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 May 2019 09:57:58 -0000 > > > Changing 'kni_fifo_init()' return type shouldn't be a problem at all, > perhaps it would be a problem if the content of the fifo changed but it is > not > the case. > Should I move this patch to deferred or reject? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 551F0A0096 for ; Tue, 7 May 2019 11:58:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 85FF8293B; Tue, 7 May 2019 11:58:00 +0200 (CEST) Received: from mail-it1-f195.google.com (mail-it1-f195.google.com [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id 51A7B28FD for ; Tue, 7 May 2019 11:57:58 +0200 (CEST) Received: by mail-it1-f195.google.com with SMTP id l10so25380911iti.3 for ; Tue, 07 May 2019 02:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bDD/3yHGQoQF8HXx6bMOzbtY19ZlW9ibxPi7xAlglGM=; b=IKyRISNlWJKgIz4+DrRwAupY/XfBj1O65zrMOIMMBAZeE6RLdVlbpYxHdlapLjLFHO zYuuwLRz6D+TfkziVaRzBzsl0cU0irdu5o01fyHHQZpEy04kzgKxR1tKUJcw92MXgV1o iUpaY0zGGc6ctpsqTzrXI/3TIW0DUjJcMAypH1uX8wh1aCBjRzmR/y6+WlikEI7PrYan BcUA0sosVVaMUuQa4RSzWJhBdh2LMVF0WownyxNsDOS0sTyYkl4kuWLYtMTXNhgWdIvv 1ZfK84JlYHsslyqDqnOSgJ5B3+y/WKRrOc/C6eEHbYY9N5Lsxtqu7H75ygf1Ikj17f51 XpLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bDD/3yHGQoQF8HXx6bMOzbtY19ZlW9ibxPi7xAlglGM=; b=IO/Xc4wavVlrJ1g2KgouBA7/eVYggq8uIgPMPx07mQ73XKkNT5dyvI48ZioNtfwua+ 4XImEhEDSHjvidE3/j+Qv2olUragDAhj0dqpuD0b8nfD2XquxtmMzn0xbrd2pCHCcqy7 agD+B56VgmPyYJbTk3OTYcQqykQmAyLGjWVr2WbpZO+K7PlJxqTVFOrHv5kP41xG+APK COvOQGUwOf5uhThhr/OE8SiuaQqUuw98Joj2S0oH6b6cVmE6JqZUEHbKEa18RpwwaPpT NJSwi4M5LHiU8MhsXqru4u4zrzicij9KTi/cItV6KmI0ZxDzKuZbCIoVDL95Yz25pb56 4wYw== X-Gm-Message-State: APjAAAVz6bzMuDCw9oHEYn8HgXJ/vX6Yc2ZGi/hERRhXLzUDguhq5AMc 7Pz/L9OkXU4q4S/7StTnZy+0efOsljW6vDCa99EoHg== X-Google-Smtp-Source: APXvYqxBWK/T9aEE5mperhfgpmfUezJSiZYHqVVIyZDY62ksIdoQ0OlvRbSw829XyfcaKoKhqr/9Fiq2R3fmitWhwnI= X-Received: by 2002:a24:5d81:: with SMTP id w123mr14914703ita.11.1557223077565; Tue, 07 May 2019 02:57:57 -0700 (PDT) MIME-Version: 1.0 References: <1556463528-22853-1-git-send-email-arnon@qwilt.com> <20190428092357.66ae2b80@hermes.lan> <20190429092430.4e71a9ab@hermes.lan> <3c8183ba-7140-784f-d690-a279e1aff30c@intel.com> In-Reply-To: <3c8183ba-7140-784f-d690-a279e1aff30c@intel.com> From: Arnon Warshavsky Date: Tue, 7 May 2019 12:57:46 +0300 Message-ID: To: Ferruh Yigit Cc: Stephen Hemminger , dev@dpdk.org, Thomas Monjalon , "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , Jerin Jacob , Bruce Richardson , ranjit.menon@intel.com, anand.rawat@intel.com, Pallavi Kadam , Harini Ramakrishnan , "O'Hare, Cathal" , Arnon Warshavsky Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190507095746.Zet9026OURHrXEz49big-laVCvjnpVhGNSAO8r_HG5M@z> > > > Changing 'kni_fifo_init()' return type shouldn't be a problem at all, > perhaps it would be a problem if the content of the fifo changed but it is > not > the case. > Should I move this patch to deferred or reject?