DPDK patches and discussions
 help / color / mirror / Atom feed
From: Arnon Warshavsky <arnon@qwilt.com>
To: Andrzej Ostruszka <amo@semihalf.com>
Cc: Ilya Maximets <i.maximets@samsung.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	 Stephen Hemminger <stephen@networkplumber.org>,
	David Marchand <david.marchand@6wind.com>,
	dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] devtools: move forbidden tokens awk script to a separate file
Date: Sun, 23 Sep 2018 23:20:43 +0300	[thread overview]
Message-ID: <CAKy9EB0OzfVzvGu263VHKvP8LwTycfa9m_7PLxrNj0T8jDJoiQ@mail.gmail.com> (raw)
In-Reply-To: <8c7b1bea-526d-65cd-cdd9-6fa135c891a1@semihalf.com>

On Fri, Sep 21, 2018 at 2:37 PM, Andrzej Ostruszka <amo@semihalf.com> wrote:

> Acked-by: Andrzej Ostruszka <amo@semihalf.com>
>
> However you might consider keeping this comment in the awk script.
>
> On 20.09.2018 23:11, Arnon Warshavsky wrote:
> [...]
> > @@ -44,85 +44,12 @@ print_usage () {
> >  }
> >
> >  check_forbidden_additions() {
> > -    # This awk script receives a list of expressions to monitor
> > -    # and a list of folders to search these expressions in
> > -    # - No search is done inside comments
> > -    # - Both additions and removals of the expressions are checked
> > -    #   A positive balance of additions fails the check
>
> Best regards
> Andrzej
>

Thanks  Andrzej  , you are right. It was indeed supposed to move into the
awk script.
Will fix that

      reply	other threads:[~2018-09-23 20:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 21:11 Arnon Warshavsky
2018-09-21 11:37 ` Andrzej Ostruszka
2018-09-23 20:20   ` Arnon Warshavsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKy9EB0OzfVzvGu263VHKvP8LwTycfa9m_7PLxrNj0T8jDJoiQ@mail.gmail.com \
    --to=arnon@qwilt.com \
    --cc=amo@semihalf.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=i.maximets@samsung.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).