From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it1-f196.google.com (mail-it1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id 27A5A201 for ; Sun, 23 Sep 2018 22:20:45 +0200 (CEST) Received: by mail-it1-f196.google.com with SMTP id j81-v6so8037514ite.0 for ; Sun, 23 Sep 2018 13:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MAkxgw6AVOFW6Cto3fKdZQAaIph4nyTj/uJida4k2Gc=; b=wGipdSMbtxhAZ/Zwr8O0NXlSdGNhwvDuRdeOljZNBRDGOvHApnnSp6l+t75LaJqdmr DVcg5+Y9LXjWFPFGAJYFG1cnfAc0/EL+Bcap7XQMTf7aXGpsMw63G+ue7xm3C0jWWxk8 g3iOrmqFHKMMSUtl0mwKVbwY4MQpUFqKYMtAXMDXvDU4QF6MId+QPxaQ52RGsSk72Q/K GIXvT6p+qBjblHxViGkpqSYuJp0w5gy4HDHvTTNzbMkdvLxC/cKINbQLNJPb1p5zz6w3 eKTmqyC9Bt3P5Lw3Yh141Uf1kMWrA4IkrZUgqxHoi4b4Rw25qJ0zXQpjq/T353sbONUZ NZAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MAkxgw6AVOFW6Cto3fKdZQAaIph4nyTj/uJida4k2Gc=; b=hcmHVHcgSiX6d+Ho2RaabS2mf90nbypY5XrfLm1jb+DT90r3rcJUsypkIIBhggCU4M qpqFJJD7xU+TyFMdCm7Ib4Nl2+73f/dsMVkSnglmqEjatNlF8/EdSdAYPJjPPXCx1H+f k0jUq/HaH08PRRaT+ENvSkRcctgxFQqGluQni1c7vJ0VwYh1+4/s8Km1RMiydhrFkczC GGYv91/8YbkzWoiM4rjcR3hkGwhQilLMTx2ltn3jF0JBUT/7Um/voI6wN+l5xu0JQLN5 ZI5CL/9UjcJlMpjyMV7WMDNVx2s71kmRTAFn+UXZUdlkfu83zFmloICEQFL1H2Sg+ZAE 80KQ== X-Gm-Message-State: ABuFfohN8Qxnj7ldmk0PaQO4grM0rjE6+zBBuJVnmNfGbeOkBh+BVW4Q 7Mx3ukeyK5NwUuNeSgAgz+Cpbs5jKTnSSSZogVF/Lg== X-Google-Smtp-Source: ANB0VdbG57GLK0CPhspe83CwpmGsZQoazy/fRsVFBv05ZuOC35js/wIPSMOvZ2PMuI5xSx5mNIZ7hnSaanGJuEax2Ew= X-Received: by 2002:a24:400b:: with SMTP id n11-v6mr5805287ita.2.1537734044276; Sun, 23 Sep 2018 13:20:44 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:d419:0:0:0:0:0 with HTTP; Sun, 23 Sep 2018 13:20:43 -0700 (PDT) In-Reply-To: <8c7b1bea-526d-65cd-cdd9-6fa135c891a1@semihalf.com> References: <1537477900-32682-1-git-send-email-arnon@qwilt.com> <8c7b1bea-526d-65cd-cdd9-6fa135c891a1@semihalf.com> From: Arnon Warshavsky Date: Sun, 23 Sep 2018 23:20:43 +0300 Message-ID: To: Andrzej Ostruszka Cc: Ilya Maximets , Thomas Monjalon , Stephen Hemminger , David Marchand , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] devtools: move forbidden tokens awk script to a separate file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Sep 2018 20:20:45 -0000 On Fri, Sep 21, 2018 at 2:37 PM, Andrzej Ostruszka wrote: > Acked-by: Andrzej Ostruszka > > However you might consider keeping this comment in the awk script. > > On 20.09.2018 23:11, Arnon Warshavsky wrote: > [...] > > @@ -44,85 +44,12 @@ print_usage () { > > } > > > > check_forbidden_additions() { > > - # This awk script receives a list of expressions to monitor > > - # and a list of folders to search these expressions in > > - # - No search is done inside comments > > - # - Both additions and removals of the expressions are checked > > - # A positive balance of additions fails the check > > Best regards > Andrzej > Thanks Andrzej , you are right. It was indeed supposed to move into the awk script. Will fix that