From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f50.google.com (mail-it0-f50.google.com [209.85.214.50]) by dpdk.org (Postfix) with ESMTP id ED8617CD9 for ; Thu, 26 Apr 2018 23:06:19 +0200 (CEST) Received: by mail-it0-f50.google.com with SMTP id c5-v6so775582itj.1 for ; Thu, 26 Apr 2018 14:06:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hCvmRTXke1bpyUznniMdD9A+4KAbGxhWKWQpMZWEjKI=; b=O5TUNDD33xNAGtAhS0QNLdLNOGh2edeCRBEF8A+tuxRkO6ODUpNzxHwZvC9ACcnhFI rwUwGfLjLDcKtKUehHnAiYVJO0uIIfnlMo/Pt9leoD67zu8fN3UicVDUgD+X6U9YTm6K 2FynrWyx86vqL/hq2rJxv0tq6oSOuG+iuuNivnzpvalyVYFgpebqtzXAVXyGWuQRvgSw XsKA+/otEy7GPLv0ZNKLCr4gVExp+Is+CIcDKgJ18/idE1b/YBv5Z71vZwJXQ6qWQ+3g msiJsG6564IDB0TN2hYsSY69MmE3OEzysg5EzAU7dCwHZDplfXdmSoE7f3NrGcLvkV3t ndag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hCvmRTXke1bpyUznniMdD9A+4KAbGxhWKWQpMZWEjKI=; b=jBDYGr3MftYD/9aX6HMQzSq2NGC29hNAkPPc6HnfRAWGmYgAyb0j1ZfYmPogJMDjwi bw0wJBoo/VoHffmi27p5ZPFsbbr5QGKpP8faTcJfJ3okmfSOAr64isNCr7JbbGzdnH3M EySjgV9++xvJxPxbtUiqAkf0TvCoXRDWVuDXw9LyJEyxQLTUJfPexzGCwPfgTDcn9b6G MTkIrad8WnydkJ6v0MrxaJILLAEkjsaysyRZDr3vFV4wNJM0HvL0zEFxUyU+kGKAE+Cp UnSMB1UFUyQhPzD9EBwKS1OpubPeqEpi4gEEoeZwl0KUcLE63Gzo/ei94BLm1m/lmKP3 hc7g== X-Gm-Message-State: ALQs6tAVmPDo3tir3HNse9CPetf+3g7wPupQ0wvl0ny7Gg80KKVH9Oaa 0HMdf3vUHN5e0wzf7PpMGc8pP3VW9Pna+eRTfLE3FQ== X-Google-Smtp-Source: AB8JxZr6Vbse1eaJE2ZmMsewauJCLGAyTR/bwvgRdpFV8AtHVBPfmMwq+QnkkGtCY4vzyLmFTqqjDZb99CvQfUsD03M= X-Received: by 2002:a24:2911:: with SMTP id p17-v6mr87182itp.37.1524776779368; Thu, 26 Apr 2018 14:06:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.145 with HTTP; Thu, 26 Apr 2018 14:06:18 -0700 (PDT) In-Reply-To: <9a982432-aec7-a3b5-12b2-e3f9f799aa76@redhat.com> References: <1524663944-30376-11-git-send-email-arnon@qwilt.com> <1524723664-30510-1-git-send-email-arnon@qwilt.com> <1524723664-30510-3-git-send-email-arnon@qwilt.com> <9a982432-aec7-a3b5-12b2-e3f9f799aa76@redhat.com> From: Arnon Warshavsky Date: Fri, 27 Apr 2018 00:06:18 +0300 Message-ID: To: Kevin Traynor Cc: Thomas Monjalon , "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v9 02/10] bond: replace rte_panic instances in bonding driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 21:06:20 -0000 Hi Kevin > /* Any memory allocation failure in initialization is critical > because > > * resources can't be free, so reinitialization is impossible. */ > > What about this comment? Not sure if it is just stale or if there is > something else you need to do. > This comment was originally in the code to explain why is a panic being thrown. By returning from this function in this patch I also aim to terminate the process, but through the door rather than out the window, so It still makes sense there > > > * @return > > * 0 on success, negative value otherwise. > > ^^^ you inadvertently fixed a doxygen bug :-) > I consider this doxygen tightly coupled with the code in this change so I > will not charge twice here :) > > > > + if (rc == internals->active_slave_count) { > > + int rc = activate_slave(bonded_eth_dev, > > + slave_port_id); > > + if (rc != 0) > > + return -1; > > + } > > Not functionally wrong, but commented about no need for variables here > in v4 and seems to have been missed > Indeed missed that one. Will fix Thanks /Arnon