DPDK patches and discussions
 help / color / mirror / Atom feed
From: Arnon Warshavsky <arnon@qwilt.com>
To: Ilya Maximets <i.maximets@samsung.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
	 Stephen Hemminger <stephen@networkplumber.org>,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] devtools: don't use bash extension in checkpatches
Date: Thu, 16 Aug 2018 08:25:38 +0300	[thread overview]
Message-ID: <CAKy9EB16M51eKWUCGmK4Oe52GH=PuPYMOpVJL4Qqi7fu0vVsJw@mail.gmail.com> (raw)
In-Reply-To: <20180815153346.11495-1-i.maximets@samsung.com>

Hi Ilya

Let's use single quotes instead of variable.


Using the script directly with single quotes loses the ability to reuse it
with an additional set of folders , expressions and RET_ON_FAIL.
If we wish to keep the awk code in this file and not in a separate file,
maybe receiving the awk script parameters from the function
 check_forbidden_additions( ) can also preserve the ability to reuse in
future cases.

thanks
/Arnon

  reply	other threads:[~2018-08-16  5:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180815153249eucas1p2e13cf746fda4b82519b40f3b760a2c33@eucas1p2.samsung.com>
2018-08-15 15:33 ` Ilya Maximets
2018-08-16  5:25   ` Arnon Warshavsky [this message]
2018-09-14 14:50     ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-09-14 15:10       ` Ilya Maximets
2018-09-15 21:07         ` Thomas Monjalon
2018-09-15 19:07       ` Arnon Warshavsky
2018-09-15 20:37         ` Thomas Monjalon
2018-09-16  3:13           ` Arnon Warshavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKy9EB16M51eKWUCGmK4Oe52GH=PuPYMOpVJL4Qqi7fu0vVsJw@mail.gmail.com' \
    --to=arnon@qwilt.com \
    --cc=dev@dpdk.org \
    --cc=i.maximets@samsung.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).