From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arnon@qwilt.com>
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194]) by dpdk.org (Postfix) with ESMTP id F1CF52BAF
 for <dev@dpdk.org>; Thu, 16 Aug 2018 07:25:39 +0200 (CEST)
Received: by mail-lj1-f194.google.com with SMTP id y17-v6so2649067ljy.8
 for <dev@dpdk.org>; Wed, 15 Aug 2018 22:25:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=qwilt-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=8xSULDQfpIpOOdHnyh4Fk4JaUKYAgr9qHCLLKG0YpKA=;
 b=GYlYhBy4fXvUuFi3wEz1mkxxSngd2qomB4ooDq5sK36C5NEPcohGW2s0BIeT7LYYr0
 WTRO7UpUruXk//kxfnkREYAOdcEqIvuNapstwqw0Ve0nDho/MWuGFyQTixq6AuPzvb+k
 3hggJ5RSEbRS7+Zz6KvJxbGhHhwtyoD48k/yp+gO4nOimxfc0+9i1dAnM58/DorR3Tp7
 xYVGPg2uzeRH7+BBn3+TeDTNV4m3ZqgbkV5ja8D38FDHsTM6FAC5Ob4nXcrkvtA+dmQW
 Tdloqz4rWc3czSaGYW9gvZ6DJ3S43FwQ0LdMRvvdcpq0mJO6h1SupbAnw5OZdy7uN17r
 vpdA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=8xSULDQfpIpOOdHnyh4Fk4JaUKYAgr9qHCLLKG0YpKA=;
 b=fTyUQWYpdjNCW56GmJTNKEtlvHPfBVxA+1gOowbZy/p3+ZGxJrasKPHYKWROKpxPrk
 bqLXDTY7SxeyzCuZ4Rcdvp9Eyeoxr1zccKbZHnd9H7iWwgNH4P0qrBZwQJGzXM85S+YA
 du2GiLRbyXwtIq6XxtCB6OKSeiCYeT6IOJJ5e/nwxGefhpKg6nqzpZKFvmwZ78L/GPzD
 SEjqQCxcqIrOc+x4EFRt5MMIOZUz984H4HOxocUbv7TiDHbEh0AAhdhOJH5m+LB5TyuM
 ivUEvxe1K8CkOwEmf+IDvMBuJXimpy64zEXTZaLAcY8yZUQUwFXzqMK2eKtrrOoEG+dt
 HT4w==
X-Gm-Message-State: AOUpUlGyTbuvPptQsoyQ0YVv2kTj1WxaGqjyMYi1mngwkyQJ8S1b6wWE
 S4di/Wfd0g9xW8edxdX9SfX/aeDwlQWiOm38KMvLEA==
X-Google-Smtp-Source: AA+uWPxMo3jrIobEIFVwErPrno2yPMg+DiK0aHwmsf7G+21ctHcvj6SZCKvMJRc6kaeZ6jUe0hnmj+SE+k1QfS3I1UM=
X-Received: by 2002:a2e:9614:: with SMTP id
 v20-v6mr5078568ljh.130.1534397139299; 
 Wed, 15 Aug 2018 22:25:39 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:ab3:6a92:0:0:0:0:0 with HTTP; Wed, 15 Aug 2018 22:25:38
 -0700 (PDT)
In-Reply-To: <20180815153346.11495-1-i.maximets@samsung.com>
References: <CGME20180815153249eucas1p2e13cf746fda4b82519b40f3b760a2c33@eucas1p2.samsung.com>
 <20180815153346.11495-1-i.maximets@samsung.com>
From: Arnon Warshavsky <arnon@qwilt.com>
Date: Thu, 16 Aug 2018 08:25:38 +0300
Message-ID: <CAKy9EB16M51eKWUCGmK4Oe52GH=PuPYMOpVJL4Qqi7fu0vVsJw@mail.gmail.com>
To: Ilya Maximets <i.maximets@samsung.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>, 
 Stephen Hemminger <stephen@networkplumber.org>, stable@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] devtools: don't use bash extension in
	checkpatches
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Aug 2018 05:25:40 -0000

Hi Ilya

Let's use single quotes instead of variable.


Using the script directly with single quotes loses the ability to reuse it
with an additional set of folders , expressions and RET_ON_FAIL.
If we wish to keep the awk code in this file and not in a separate file,
maybe receiving the awk script parameters from the function
 check_forbidden_additions( ) can also preserve the ability to reuse in
future cases.

thanks
/Arnon