* [dpdk-dev] [PATCH] devtools: use bash for checkpatches.sh
@ 2018-08-30 13:00 Andrzej Ostruszka
2018-08-31 8:00 ` Arnon Warshavsky
0 siblings, 1 reply; 3+ messages in thread
From: Andrzej Ostruszka @ 2018-08-30 13:00 UTC (permalink / raw)
To: dev; +Cc: arnon
On some systems /bin/sh does not support '-d' option of 'read'.
So instead of /bin/sh use /bin/bash.
Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs")
Cc: arnon@qwilt.com
Signed-off-by: Andrzej Ostruszka <amo@semihalf.com>
---
devtools/checkpatches.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index ba795ad..db7afc4 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -1,4 +1,4 @@
-#! /bin/sh
+#! /bin/bash
# SPDX-License-Identifier: BSD-3-Clause
# Copyright 2015 6WIND S.A.
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] devtools: use bash for checkpatches.sh
2018-08-30 13:00 [dpdk-dev] [PATCH] devtools: use bash for checkpatches.sh Andrzej Ostruszka
@ 2018-08-31 8:00 ` Arnon Warshavsky
2018-09-10 6:26 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Arnon Warshavsky @ 2018-08-31 8:00 UTC (permalink / raw)
To: Andrzej Ostruszka; +Cc: dev, Ilya Maximets
On Thu, Aug 30, 2018 at 4:00 PM, Andrzej Ostruszka <amo@semihalf.com> wrote:
> On some systems /bin/sh does not support '-d' option of 'read'.
> So instead of /bin/sh use /bin/bash.
>
> Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs")
> Cc: arnon@qwilt.com
> Signed-off-by: Andrzej Ostruszka <amo@semihalf.com>
> ---
> devtools/checkpatches.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index ba795ad..db7afc4 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -1,4 +1,4 @@
> -#! /bin/sh
> +#! /bin/bash
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright 2015 6WIND S.A.
>
> --
> 2.7.4
>
>
Acked-By: Arnon Warshavsky <arnon@qwilt.com>
thanks
/Arnon
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] devtools: use bash for checkpatches.sh
2018-08-31 8:00 ` Arnon Warshavsky
@ 2018-09-10 6:26 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2018-09-10 6:26 UTC (permalink / raw)
To: Arnon Warshavsky; +Cc: Andrzej Ostruszka, dev, Ilya Maximets
On Fri, Aug 31, 2018 at 10:00 AM, Arnon Warshavsky <arnon@qwilt.com> wrote:
> On Thu, Aug 30, 2018 at 4:00 PM, Andrzej Ostruszka <amo@semihalf.com> wrote:
>
>> On some systems /bin/sh does not support '-d' option of 'read'.
>> So instead of /bin/sh use /bin/bash.
>>
>> Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs")
>> Cc: arnon@qwilt.com
>> Signed-off-by: Andrzej Ostruszka <amo@semihalf.com>
>> ---
>> devtools/checkpatches.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
>> index ba795ad..db7afc4 100755
>> --- a/devtools/checkpatches.sh
>> +++ b/devtools/checkpatches.sh
>> @@ -1,4 +1,4 @@
>> -#! /bin/sh
>> +#! /bin/bash
>> # SPDX-License-Identifier: BSD-3-Clause
>> # Copyright 2015 6WIND S.A.
>>
>> --
>> 2.7.4
>>
>>
>
> Acked-By: Arnon Warshavsky <arnon@qwilt.com>
Tested on Ubuntu 18.04, thanks.
Tested-by: David Marchand <david.marchand@6wind.com>
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-10 6:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-30 13:00 [dpdk-dev] [PATCH] devtools: use bash for checkpatches.sh Andrzej Ostruszka
2018-08-31 8:00 ` Arnon Warshavsky
2018-09-10 6:26 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).