From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arnon@qwilt.com>
Received: from mail-it1-f172.google.com (mail-it1-f172.google.com
 [209.85.166.172]) by dpdk.org (Postfix) with ESMTP id C00E71B1EF
 for <dev@dpdk.org>; Fri,  2 Nov 2018 11:37:37 +0100 (CET)
Received: by mail-it1-f172.google.com with SMTP id p11-v6so1200203itf.0
 for <dev@dpdk.org>; Fri, 02 Nov 2018 03:37:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=qwilt-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=c89hKrEW0W5JGqYGr9e5wo0N+MlCVvS+ssd2T+yE9Rk=;
 b=aBlCDKnzbsKwyFBt/G7BlJkmtwdNvxRYevwMblDKqQO0gmBoVi6DFa6YcFjfcbDzwu
 CTxSjhnKXHGA7lLGdxG71YSuNcV81C28W49NsLaJRxgYsjmrmbMSHf3sjz5LMDE3AtiQ
 cna0DFD49F9nbyhC4fM30axHfBZ4isDmZMHCKt72/dkiqO67JZO1sJEJu4+kNKZjxcdv
 gukj18aFKkGCY2XxI9j93kGa9b8BxPh3Ed+RXQIRKvy11VQ4/z6sOgCfIbN3jXqsVNGY
 GNgKfLr+WVQhjhZSFw+L4UQomiRD9RWpUd2mE8lmHt4RVtnS8g0PlQpcMNXKAQrTfFqr
 RS2w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=c89hKrEW0W5JGqYGr9e5wo0N+MlCVvS+ssd2T+yE9Rk=;
 b=Ca5ArfZkZ0o1qq8NhsvT2ecQRyL//45e2fWAcQKIIhtAQuy9I6/rnMGoKor9xNNyT1
 37OCnA2fOroHggonAzGUiHRRKqn0tgVhn7e6uWlUch6Ncu4tHsJWVIIu14JwQLiPYNqw
 JMR7ek4uu0dCvhGTiP7GOAk3+zXfkB99oRVOxACmuc1JcZ70pTiLgS8qU5CDS1Nv1sKE
 7cEes/AQ2isEgxQ0MXyrNGbSQURZ6FvFaMFwtuvilipn9iT3eXhrngr6buwiCzS/3mns
 lUA02al9jZnB17u1ifcrtKlas8R+pIbxgbVNk5TNKjgce4Wu8qQdqs2zNzPJ/hw5i+0A
 tqBg==
X-Gm-Message-State: AGRZ1gJ3K6Cyf7cVMsXLidbC81Cfruk5y6iXhMUkDmZgocxyHKq1MPMo
 xfLGovLaLsb3eJ6zYUMn4JACJsStzdu1V5CxheJO1g==
X-Google-Smtp-Source: AJdET5cCHTCy1UVj0iIOU3pI4XeXKNfXSD2pStIem2X+3FM0Ki8Oj+RjwqJ0R/NvH78K60ZCtND+dDsPrFBy/uZehVM=
X-Received: by 2002:a24:220c:: with SMTP id o12-v6mr226942ito.2.1541155057002; 
 Fri, 02 Nov 2018 03:37:37 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a6b:5502:0:0:0:0:0 with HTTP;
 Fri, 2 Nov 2018 03:37:36 -0700 (PDT)
In-Reply-To: <4348558.Aku75RrXBD@xps>
References: <1541138405-6608-1-git-send-email-arnon@qwilt.com>
 <4348558.Aku75RrXBD@xps>
From: Arnon Warshavsky <arnon@qwilt.com>
Date: Fri, 2 Nov 2018 12:37:36 +0200
Message-ID: <CAKy9EB1L3MRdFKFZotAe7DQTQxndxBpA+u63=0km3vA_Wby+og@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v2] devtools: add explicit warning messages
	for forbidden tokens
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Nov 2018 10:37:38 -0000

>
> > +     message="Using explicit .svg extension in figures instead of .*"
> >       awk -v FOLDERS='doc' \
> >               -v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \
> >               -v RET_ON_FAIL=1 \
> > +             -v MESSAGE="$message" \
> >               -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk
> \
> >               "$1"
> >  }
>
> Why using a variable for message in the second check?
>
>
> This was to avoid the 80 characters long line warning I get.
It also seems more convenient should there be a need for multi-line
messages.
Is there a more preferred way in such a case of a passed parameter?