From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f194.google.com (mail-io0-f194.google.com [209.85.223.194]) by dpdk.org (Postfix) with ESMTP id 4A8ADA48D for ; Mon, 16 Apr 2018 18:19:59 +0200 (CEST) Received: by mail-io0-f194.google.com with SMTP id y128so18721672iod.4 for ; Mon, 16 Apr 2018 09:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QwJZYt62FOpyuDAv3Vx1F9jI6V42LYVnc7/el6ROkTc=; b=VFaOfMdboQpcSrIAYsXxKmJPWvU+kwzUAIybc4Alr8rrTM3eyOsEtLqBDcVZQKlSYD 0MU4ekZLyZk5zw0i9eVxCC9IAZVcSDrX/JOpZMUikZBThS6Ebp881QhZg+7rG75TB5gc 0/1G8lqbuFiFWMabOeKnJXqazgACrjPSY8Uhk9ZIqHn2dUer8o7CYLVIWy/gh+y2qi5e ukZbr4icSulf/ZNsbwBTjqqIFYwcrm9Ydcdrrz+gM6PZ4sWeHs2BV5rAecp4xzDwcgie C9/wf8VmEmNm9wP8KpuxqAJPeQq7v5MIZytvUxs5IGcdoP5x4OYf/q2GfUQWX+jaPh7Z OfSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QwJZYt62FOpyuDAv3Vx1F9jI6V42LYVnc7/el6ROkTc=; b=rabExNBR9gHMbW9XKG89X1FuKkTVDgqR+UjgHaWQ1YYBw2cx+BF8MR54tLwpmd5Hx3 qdPKe/Da/Ti5rMZyrbpmI9ucg1QO+cEomyHOY6GkGqJYPZvuG1D7zY5Limy+NoSOcqV1 kyxXc8RKPp6Su9/EpVRxS2JmFSP/x7dxbsXn8on30rnP/GFv8hXxeHZSPL/J1OwagkUo wgJMFlmbD/2UmwkIZSon2HC5OnJ1dib8/rJ2fw7YB3Z227C/4b5TMIAOMefefln6itTy 1PrmGYHB1/WlOwBrmAd+E4HtWalXvg7x6AfPwTfDnhuBwUt67tIPRTHY8gPvq4gAZFLe t5EQ== X-Gm-Message-State: ALQs6tAc3HRnLQfnwLVAU8UKOxl83C8ZwVj0++Zdf+AMjHaK6gAZVHkL /8X/ztIJJi2ipqucw7VTh993pjDw87G2IGTxblavxQ== X-Google-Smtp-Source: AIpwx4+7I+A02SE/6WTQ3NCxbaUn5xYx83aXDf1nvrDn5cutKqyK4Ikv/CcB43llGlSuk861lrcD59iwxRNmV7Aje0g= X-Received: by 10.107.58.11 with SMTP id h11mr24688244ioa.283.1523895598500; Mon, 16 Apr 2018 09:19:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.145 with HTTP; Mon, 16 Apr 2018 09:19:57 -0700 (PDT) In-Reply-To: <20180416083409.6d4cb085@xeon-e3> References: <1523644244-17511-1-git-send-email-arnon@qwilt.com> <1523644244-17511-4-git-send-email-arnon@qwilt.com> <20180416083409.6d4cb085@xeon-e3> From: Arnon Warshavsky Date: Mon, 16 Apr 2018 19:19:57 +0300 Message-ID: To: Stephen Hemminger Cc: Thomas Monjalon , "Burakov, Anatoly" , wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, Bruce Richardson , ferruh.yigit@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 03/13] e1000: replace rte_panic instances in e1000 driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 16:19:59 -0000 Thanks Stephen I thought I handled all the split strings. Apparently checkpatches overlooked it. Will do a rescan on the entire patchset and fix those in v4. Missed the separate log macro. Will change that as well On Mon, Apr 16, 2018 at 6:34 PM, Stephen Hemminger < stephen@networkplumber.org> wrote: > On Fri, 13 Apr 2018 21:30:34 +0300 > Arnon Warshavsky wrote: > > > + if (*vfinfo == NULL) { > > + RTE_LOG(CRIT, PMD, "%s(): Cannot allocate memory for > private " > > + "VF data\n", __func__); > > + return -1; > > + } > > > Don't split strings across lines. Checkpatch should complain about that. > It makes searching for error messages in source harder. > > Instead do: > if (!*vfinfo) { > RTE_LOG(CRIT, PMD, > "%s(): Cannot allocate memory for private VF > data\n", > __func__); > return -1; > } > > Also why not use PMD_DRV_LOG() macro. > -- *Arnon Warshavsky* *Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | arnon@qwilt.com *