From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arnon@qwilt.com>
Received: from mail-io0-f174.google.com (mail-io0-f174.google.com
 [209.85.223.174]) by dpdk.org (Postfix) with ESMTP id 097212BCD
 for <dev@dpdk.org>; Tue, 24 Apr 2018 21:27:53 +0200 (CEST)
Received: by mail-io0-f174.google.com with SMTP id r9-v6so8014014iod.6
 for <dev@dpdk.org>; Tue, 24 Apr 2018 12:27:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=qwilt-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=68JL3hTUSEfC1vlyywayYop3/ssgnpC1Qtl0MUgf8yw=;
 b=bozcH/cMNPtP2d4fhVrtpbYlMMczMyg1F5TeBkIkAtDLVMXbekkniQRTHl7nVSZ7tN
 +8sRSPvk/qXwmzRRCxNUi+pN6DQz5Sll1MKJRU9yAjDBuSbnb1Hk12ZOj4N0dJGiD3gw
 gQsd80lpoduIpXExQdRBvBdGoVYb+brS+/fVF4gSpST0p9DAHSOppyOH5DZEDXSLuLQV
 z+e9UFWacX+KpOTnYl1xAQBPOr+GpIRcPUoIX9G3YnXEvdhSHYJ4gNdCHkYJKPHWZ/ZJ
 lxDY9lR87G3tolxulx2LeJqCXGXlhFfxojIQb2lYf1q5v56txqyGAkLvT55+7QoW4RQu
 vVoA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=68JL3hTUSEfC1vlyywayYop3/ssgnpC1Qtl0MUgf8yw=;
 b=lP1ZFB1zzLs5RWg6ACq8O6vhbH0t/XsFvhWJPa2y4hDffs3I+j0JipIZ5uwLqyJiJN
 ct38PYntOOXsRICAVFwoo4xlVWwQNZKdOP14jvUPNc+504huy5VA4nbLUq4pWTxrc8kU
 WKNUe6TI9DyeABC3b13EyYqPs0O4qBDmmL5HB6AL9GoQPoSpsxspca32kwRK2sU0HDQ/
 J1j5Ztwvxgy+HVtPmzaQY+cEku0bEc1SY+AwJHZCgs7hPBAMUKZpm9tZsxN7P2I8aXW2
 d1efmwLlEg1izZKPxJJS8WbBRvs16dqEmO+Mr51hQPjsIkO0/o3V68p7Imv+rh+wbt0k
 AgXA==
X-Gm-Message-State: ALQs6tD+1OdV/XY31okhGqumiyCh9DStUd6gP9ahkTDBNrsVmU2P+lzC
 BtEleaQjql9gYJkI/5pUg3VgcF8SeTQ9z63smEH5PQ==
X-Google-Smtp-Source: AIpwx48mhsJiw87r6epr5rL3jVKJUPYytqAM4/UMNIdDAQBVKFNyQqHLra8OjeyAdJ6pVIPJ1N+1VvL7125+P17amX0=
X-Received: by 2002:a6b:6918:: with SMTP id
 e24-v6mr29698328ioc.242.1524598073276; 
 Tue, 24 Apr 2018 12:27:53 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.107.142.145 with HTTP; Tue, 24 Apr 2018 12:27:52 -0700 (PDT)
In-Reply-To: <20180424080032.161d08b9@xeon-e3>
References: <1524552123-31378-1-git-send-email-arnon@qwilt.com>
 <1524552123-31378-2-git-send-email-arnon@qwilt.com>
 <20180424080032.161d08b9@xeon-e3>
From: Arnon Warshavsky <arnon@qwilt.com>
Date: Tue, 24 Apr 2018 22:27:52 +0300
Message-ID: <CAKy9EB2aChL9PcVMaL+u2iZsvFWfGQA4+ahsngumTvsQMLw17w@mail.gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Thomas Monjalon <thomas@monjalon.net>, "Burakov,
 Anatoly" <anatoly.burakov@intel.com>, 
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Doherty,
 Declan" <declan.doherty@intel.com>, 
 jerin.jacob@caviumnetworks.com, Bruce Richardson <bruce.richardson@intel.com>, 
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v6 01/11] crypto/dpaa: replace rte_panic
 instances in crypto/dpaa driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Apr 2018 19:27:54 -0000

>
>
> > +             if (cryptodev->data->dev_private == NULL) {
> > +                     RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone
> for private device data",
> > +                     __func__);
>
> dpaa2_sec is already doing private log type, via DPAA2_SEC_LOG macro.
>
> You should go through your patch and make sure there are as few direct
> calls
> to RTE_LOG as possible.
>

Thanks Stephen,
missed that one which seems to be declared but not yet used.Will replace

I may be missing something here.
While seeing the point in a short common form such as PMD_DRV_LOG,
why won't dpaa use the same syntax rather than adding another syntax
variant which does pretty much the same?