From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f50.google.com (mail-it0-f50.google.com [209.85.214.50]) by dpdk.org (Postfix) with ESMTP id 71A262C54 for ; Sun, 27 May 2018 22:34:20 +0200 (CEST) Received: by mail-it0-f50.google.com with SMTP id z6-v6so12647285iti.4 for ; Sun, 27 May 2018 13:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ful2E+hK6ljE/z/dkhtSo9CGslHPG5yEyif9QJg9BVQ=; b=bMOvvSFTtu3dz4s+yQ/MfyfZsjBokdJkSCJ1m1LAkOghisC/gK9K6se/fgAmCCqJoW CtYEF2A+AfiglkRtyDocsbzWkgF8G4EtZTUvwduBizNIAfJsgIZz8e4yFLsnLt+sC9iX AqlWFTZOjw7s81IpX1sXj34urhlOwhfaaJ5Jznb9Rrlb4NwVxMthutNURmFtjuC5r8JX xK0LOqsIyLpRIShgsjNfM/bk7f84p5PjdPi8+dUtIMK2K2dM+q4QvzwjxWarxSQZRtDy 0klfBqYgoGLlKM9ka5VwmghfRieRjtsb+nSCqtFQGEvuHqy9qTmo5SX9Nv+bv2MYtPz4 9o6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ful2E+hK6ljE/z/dkhtSo9CGslHPG5yEyif9QJg9BVQ=; b=h6g0A13njxmJuFjBr5dDwb7SCZ8R7QNB1oSKf4DLHwg8G0KRsu4gZJn21sJXyKAzOX lZSqYHOlOpsAIBUgNpvOsly1pAnd5OavZRpaQ2KkJsvgwmX9eVnFUZCUfYqC6AaeE42y 8GH9KfjFvfAKeksQ9xcsnGBTYuscosGgyMOSnxJAD0NgM26wOjn4ssvPj93BywJnZToD ZLX2mI+wlrSu9HEpcu3zafmLaMDzfpJIJe1XMWDkwAA9NWfwPrMJ0LTdH07FtCU54aC/ zi38qjkIpa9IdOVTzT87lOanLAEiXJIdEl7ciUT7R3pVC/gv4xTqJgK4ujMWIjSqNuib BVzQ== X-Gm-Message-State: ALKqPwexWUy5gD32VVdT6NpNhutJ1hx/Tfs25nCv0Ffi5RbMIcIQVS4B rrcO68GBgrZdfjo25kmVlflYa/weR4hktcZtAxUvRw== X-Google-Smtp-Source: ADUXVKLTiiLA0YEd/o69mfo+RG7Qga+lK5qrR3b+FvIhTzJIIHACNqGuCgFRT/6lnRwfjQ2p2e+w0vVNv9yA3wj46Rc= X-Received: by 2002:a24:c006:: with SMTP id u6-v6mr8904979itf.149.1527453259706; Sun, 27 May 2018 13:34:19 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:8e91:0:0:0:0:0 with HTTP; Sun, 27 May 2018 13:34:19 -0700 (PDT) In-Reply-To: <5254321.ZC84c43z8L@xps> References: <1524723664-30510-11-git-send-email-arnon@qwilt.com> <1525070752-21085-1-git-send-email-arnon@qwilt.com> <5254321.ZC84c43z8L@xps> From: Arnon Warshavsky Date: Sun, 27 May 2018 23:34:19 +0300 Message-ID: To: Thomas Monjalon Cc: dev@dpdk.org, "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , Neil Horman Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v10] devtools: alert on new instances of rte_panic and rte_exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 May 2018 20:34:20 -0000 This is consuming stdin. > I guess the checkpatch.pl will have nothing to check in the next step. > We should merge Neil's patch first, because he is adding a tmpfile > to solve the issue of stdin read only once. > Yup. Missed the fact stdin is consumed. temp file is a good idea > > > + [ $? -eq 0 ] || return 0 > > This test looks reversed: if the result is not 0, we should not return 0. > And by the way, I think it is better to continue with other checks. > Neil's patch is setting ret=1, continue and return at the end. > > > report=$($DPDK_CHECKPATCH_PATH $options - 2>/dev/null) > As it was agreed that this check should only warn and not fail the tests, The actual situation is that the function check_forbidden_additions() always returns zero. Once Neils patch is in, I can align to the return value propagation, but the current code never fails (that may change of course for future different tokens) thanks /Arnon