From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f172.google.com (mail-io0-f172.google.com [209.85.223.172]) by dpdk.org (Postfix) with ESMTP id B1ED1803B for ; Fri, 27 Apr 2018 00:27:58 +0200 (CEST) Received: by mail-io0-f172.google.com with SMTP id e78-v6so356921iod.0 for ; Thu, 26 Apr 2018 15:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GII8h8Rj2/p7BfM6Y6VniUMcbJoV3b4smIWjywe/GO8=; b=R5jbT7Nu4JzYWhX6s9Ke0VCDfc00ilB0Zgg5dWvxaY1PloM0dDdM4Y6Nl9/ev+o+of 2sGQAjxDiALbIWaPZiTST+EapJkh/Z9n4OON0AzRKBH5joKcw3Jt5OkERnziHVi6aHCz teji3seqYCJoUeM6+aIO84G0dI2gqj7Sjd+D6iTWMo3SFr39G0qFQDmuruO5jZfefPoz QRd3KeByIojoT1RHbbfkX/e8xkWUwGY1pZNouNLbWHxKhAbAwNd2pIzRLGeT1y9WsEq4 P4WPQcsItDWHKbqWDInWO5uVe+lpeXXhOw3/kItqK3/BNJ9btd6FA9rMVjW+J64gs8Nv hk2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GII8h8Rj2/p7BfM6Y6VniUMcbJoV3b4smIWjywe/GO8=; b=FphKBdPN+NjwAJqDkoWOlRyGoxbixVtYzW9qHgcp0TQGEuHmDbM9YiciCePzRFmSkf y/ml0xWfyz9BLYvuMngLRhSEIMz1zurHkIg/z92EM6yyLjPYrNcmMi+bHi4t03gK05na bYv0Z6hDFdPNMHRNdQdBvzEiapq9WTxDWuzfOB/6G0lcouvJZIOuXVYKZZ9B1vyznwK9 Ah+HfwYzGldzZNy+cQ8P5goiW0JS6we4efXHWVm+eqmYQMvPNiPXVRB0bl23bc9Tl3d4 ovPZaSn+TVOtIuIDRkfMJf52QyPm+H//2WHPPLm3sTO75OcWQMu/Rz0QgZyq2zxW7Mlc lyog== X-Gm-Message-State: ALQs6tAp7Sbly46nuAonnwkKFxHbc+ADyhNlzdB9O1LcyKvTil2l5gjf ov/zb2sJY8GhYpmQk69Et1dyahLbFX+HHgsy9efCCQ== X-Google-Smtp-Source: AB8JxZq/rHCsUwD1P2K+PaqgdPQhFmmFbuz+uI2zrHVz9rk8cNGUD9Jm0iabucy/OsH6lUzgYav3PsMWw76i0yXXnC8= X-Received: by 2002:a6b:2293:: with SMTP id i141-v6mr31728670ioi.283.1524781677993; Thu, 26 Apr 2018 15:27:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.145 with HTTP; Thu, 26 Apr 2018 15:27:57 -0700 (PDT) In-Reply-To: References: <1524663944-30376-11-git-send-email-arnon@qwilt.com> <1524723664-30510-1-git-send-email-arnon@qwilt.com> <1524723664-30510-10-git-send-email-arnon@qwilt.com> <621e7964-0450-a66e-cbf3-4fbc3a5ad723@redhat.com> From: Arnon Warshavsky Date: Fri, 27 Apr 2018 01:27:57 +0300 Message-ID: To: Kevin Traynor Cc: Thomas Monjalon , "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v9 09/10] eal: replace rte_panic instances in init sequence X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 22:27:59 -0000 On Fri, Apr 27, 2018 at 1:08 AM, Arnon Warshavsky wrote: > Hi Kevin > >> > + if (rte_config_init() != 0) >> > + return -1; >> > + >> >> I'm confused, is this deliberate? there is now two rte_config_init() >> calls. > > > Please note that there are 2 eal.c files. One under linux and one under bsd > There is a copy of rte_config_init() in each. > > My bad here here Kevin. You are right! Was looking at the patch rather than the file. Will fix Thanks /Arnon