From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f54.google.com (mail-it0-f54.google.com [209.85.214.54]) by dpdk.org (Postfix) with ESMTP id D975CAAD7 for ; Mon, 16 Apr 2018 16:24:57 +0200 (CEST) Received: by mail-it0-f54.google.com with SMTP id 71-v6so11784107ith.2 for ; Mon, 16 Apr 2018 07:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=krmrHx4UH1TFIGs2cXu8dK0dl7Wp20B/4ShJVy9xE/w=; b=Z78k51pWRTyAmK8KaafqeOdr6f82CxLLZ2HxlB5+D05XaXFqbjP0v1pMkH+OCqLCKt Rg2p3rt8iH00EhZ3eZDCqQIpvSW209uOyiMAFTpoigpeI+xbtvIer7Te1f1N6fXMnwnG p8d3cxR4GosrFgD3hhSvyBDqRcTMn2UP6gJ57uI36uAaK6xRUfj0Wj1x7kGD3LjhS7SL z2HNUbaynX5cMUHUCyf/m2RMQt2bdkAvbsZ5L0CLNA0QGqqaxWCvgF1TCC/gKSN4SnWJ nEH3l0jbIzNkCcXoVkIr6lpZrAZSu8uh2mfnCg28ilX5WjGFqCUAarSGynXcyS7RjmcU mw8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=krmrHx4UH1TFIGs2cXu8dK0dl7Wp20B/4ShJVy9xE/w=; b=AC1PT6aITJjsUZlhmPKoWwwM5Tij9K+TM7sHssWAcN51n7zUAKWz5wuUuDMtDVcQeE 4fnj0+wwAyzNmoB4jxcWk8bM7VTx9pJf/sUDCVqUgbNC9Rije7Clw40B2Fl9QtaX8EMq OjeVYk0CJuxSSSL3va1r6zpUYONRs4nTlSMS09oG8OSPPLN6BS4/hiHTsUUYDoSt2rl7 yDhikda4b8uNs1g1YzpEO3yi6HQAc9kqybUwowDIU+U0U3AgjUT6uX9PmCN7n57DJpTy 5parP6n1IrP13QTT50bDmF2OheXxqGHq35NCgxLwBuiWZjUihzi5fyaS2mqzOkIertc3 4r1w== X-Gm-Message-State: ALQs6tBLhvvLInc4URtfz2jVDJOVq82ykdfe77TSm6L5qo5TfvuMOTGV QDakg5nP5TQzC+q6Wu1La4pz8Y4bdoSK1pDTB5oyrw== X-Google-Smtp-Source: AIpwx48vjUaGWkei7KisrNpSKDwcakTUOujZ6RTvascLg1Q2h04D2si1YOtP1PmmTqBaG4tEd2qtVGQXykh2DK1cq2Y= X-Received: by 2002:a24:24ce:: with SMTP id f197-v6mr2549433ita.25.1523888697176; Mon, 16 Apr 2018 07:24:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.145 with HTTP; Mon, 16 Apr 2018 07:24:56 -0700 (PDT) In-Reply-To: <20180416114912.GB25243@hmswarspite.think-freely.org> References: <1523644244-17511-1-git-send-email-arnon@qwilt.com> <1523644244-17511-2-git-send-email-arnon@qwilt.com> <20180416114912.GB25243@hmswarspite.think-freely.org> From: Arnon Warshavsky Date: Mon, 16 Apr 2018 17:24:56 +0300 Message-ID: To: Neil Horman Cc: Thomas Monjalon , "Burakov, Anatoly" , wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, Bruce Richardson , ferruh.yigit@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 01/13] crypto: replace rte_panic instances in crypto driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 14:24:58 -0000 This function is only called from locations that return a -errno code, not just > -1. > > Neil Hi Neil Looking up the references I see that some of the places looking at this return value from the probe function simply return their own -1 , and some return different enums relevant for their context. As they all look at !=0 or < 0 , but not all propagate the value they got I used an explicit -1. Do you have a specific enum in mind I should replace it with? /Arnon