From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f179.google.com (mail-io0-f179.google.com [209.85.223.179]) by dpdk.org (Postfix) with ESMTP id 26BD72BC9 for ; Wed, 25 Apr 2018 11:37:12 +0200 (CEST) Received: by mail-io0-f179.google.com with SMTP id r9-v6so10026048iod.6 for ; Wed, 25 Apr 2018 02:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DGQNfdyBa4a2LhyHJrESz9v8v6TvqZ42moe88oxHhS8=; b=clKAMWCJINbE9WLjizIBmplDJ8o8iy06dyh3aMzfrgkGqzS2BPvPr/i/xcv1nIhP9L ihFysMOYIQSdctAcnN3F1f7vgmCF/Ook6ZsrDP8dPsVuvVJOd93ZJYMJROAXCg601KQm SksiuGf30dleD2MZENKtOuX8SsMGmJPNvVyMgkojPFm5ESPOj7BKJ/b2s+x7LIoye0Wh lmoSANneTGnv66m7cvVM4rOOUZoYej8lmYf1jGJlN+YdajYIWE8R/Wc/RE9DNrf54xnO mgrTwSXVu0u/PzGXvaNVXU6zBD/cumFTghb1vCtP6cT7Piwb2rINYztRY99eJ4LxOxde jF0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DGQNfdyBa4a2LhyHJrESz9v8v6TvqZ42moe88oxHhS8=; b=FwY+rZBcVc/Tyq+WxHLuY3mSRm865Liz4KxG3hdAShV57AqNxfs3jDf2O42O5rGmZy 6S/z/J7FTwBETG0sq7zeouBalsgzLxQPfdhXw2luOcPPLNWOHmtGuV7qQhMmXd8aqT0T 0gcKO8JIT9i68Jt+0rHk8ivDre22IIV2IMyzhN7SKQ7P3Iu6tPWm7yrD3gPnBfrhCVzd 798D55BiZc/oA7rAfbTCp85UwuX/+otOZ8r+trT3KRobMTqP/6HD5CmSsMDhH9gpexVx ACVxj6pt5nBWcxAZrjxNWSd+gNbarNo/WOcTVLEifW63sBUrXP5B/ExpWz1z1W4R47Um JX1w== X-Gm-Message-State: ALQs6tAa3ukwa455AToXLHgncL7S/afgdywu+Icu0mV+WK6nbO75V00k z+ASh4nonPdrVIGmeapaeEur3oNmuToLhZe389U+Uw== X-Google-Smtp-Source: AB8JxZrCEUsCzBd3hAyzIs5Fcgqh8q7SX9cd2Bv+4oB2uP1Z86vwBqf5V/O0zd9YbnynwEBWOKhod4qKxeiSI51oVbo= X-Received: by 2002:a6b:2293:: with SMTP id i141-v6mr24045504ioi.283.1524649031050; Wed, 25 Apr 2018 02:37:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.145 with HTTP; Wed, 25 Apr 2018 02:37:10 -0700 (PDT) In-Reply-To: References: <1524608213-2080-1-git-send-email-arnon@qwilt.com> <1524608213-2080-9-git-send-email-arnon@qwilt.com> From: Arnon Warshavsky Date: Wed, 25 Apr 2018 12:37:10 +0300 Message-ID: To: "Burakov, Anatoly" Cc: Thomas Monjalon , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v7 08/11] eal: replace rte_panic instances in interrupts thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 09:37:12 -0000 > Just a general comment - i'm not too familiar with this code, but it looks > like all of these failures will only happen on thread init. Can we make > sure it starts? > > You can use similar approach to Olivier's (recently merged) thread > affinity patches, with pthread barriers etc. to ensure the thread has > initialized properly, pthread_cancel() it if it didn't, and return -1 on > thread init. Thanks for catching this one. I am now reverting it as well from this set, to be properly handled in a set dedicated to the threading issue