From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f65.google.com (mail-it0-f65.google.com [209.85.214.65]) by dpdk.org (Postfix) with ESMTP id 391587EEF for ; Fri, 27 Apr 2018 00:08:43 +0200 (CEST) Received: by mail-it0-f65.google.com with SMTP id 144-v6so284255iti.5 for ; Thu, 26 Apr 2018 15:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LqgfzrXZ9UHC/6EAVQnLNGr8qwcNIUz+MbEGoJJY/H0=; b=IB5Gup8ojKIZb8yAbc3N0ybh2+2aPJMjmZg3bqYgW00CUzEPJkEN9BZsU6hlrRZx/Z BmCIhxy7yilmpl+IHDYbriMvQzsKn28HMJ/2BFnGSKKSXEMlni86D9HubvjQyevgWDqp FnxkCn4xe/bKKYvQ4QgUjEfjtfjQrUxt7goS7N/EfIj0b4n7dAsLX8sZNddahAPQjb4N +o13xoIxO3ErlBbwFZ7Sis0M98FmQ/2KI6E901/kzJyIR+sFa7LCcHAUWhWJpUln7aXH T4RchptMR/ya/lhkIPp/7hPx7SGlBR/jMmnDSK2G6N9BmYCmsX4fJbMdnmDcCtGHw3yf sCSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LqgfzrXZ9UHC/6EAVQnLNGr8qwcNIUz+MbEGoJJY/H0=; b=sTZlW6yJaVN4wc3BEluEy9zkS7yGULTl7uyH6/NTTszUmmYjxxIs1Ha3slO0ju7HBj 1NOjTnt/SRtAJToCk5c5RGd2gSTzmAapseSg4EuKoOCD5b6/T3H2h9K6DyMkt9fpv7MK ioYf3dWTtrTUHzUbIY1RkoqbmLUp88Yr9dM/RAbreexQCCFQh4wE+mZ1VVzue2DJQzrV rlxmPvkhLhMVRoESs6flOICc0kNqTWq5mxYEX172ZM9wQt3GrdWvxZZjBaNPVVxbykW+ NPx6cjrlAjZrTHS6QGp5Kxx0pTP+yhG67LrX+bstdD+yUUXgCVOjYWGmdRMtPEB4Hjc8 v01w== X-Gm-Message-State: ALQs6tCbNMhYbaLEO6/rfH7Mi8O0ygmcC6ry7Q2sXJEW3MTey9bjdHCL EVODUCGTQhS6gV9CyUbqY3UGGldXSW5RZVGUK/KqKyYP X-Google-Smtp-Source: AB8JxZqhwV34SVrDjr/GL5YAr3gIng5P9KwAAUM3b/V6Xe3lrbcPMb/9tsk0hY0hIbxjZslvi8Jd5+41c4owECzziu8= X-Received: by 2002:a24:8d85:: with SMTP id w127-v6mr279028itd.22.1524780522603; Thu, 26 Apr 2018 15:08:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.145 with HTTP; Thu, 26 Apr 2018 15:08:42 -0700 (PDT) In-Reply-To: <621e7964-0450-a66e-cbf3-4fbc3a5ad723@redhat.com> References: <1524663944-30376-11-git-send-email-arnon@qwilt.com> <1524723664-30510-1-git-send-email-arnon@qwilt.com> <1524723664-30510-10-git-send-email-arnon@qwilt.com> <621e7964-0450-a66e-cbf3-4fbc3a5ad723@redhat.com> From: Arnon Warshavsky Date: Fri, 27 Apr 2018 01:08:42 +0300 Message-ID: To: Kevin Traynor Cc: Thomas Monjalon , "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v9 09/10] eal: replace rte_panic instances in init sequence X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 22:08:43 -0000 Hi Kevin > > + if (rte_config_init() != 0) > > + return -1; > > + > > I'm confused, is this deliberate? there is now two rte_config_init() > calls. Please note that there are 2 eal.c files. One under linux and one under bsd There is a copy of rte_config_init() in each. > Aaron's comments on v4 about rte_eal_init_alert() are missed? and > it's missing the clear once and error number like the other returns. > These comments were for code that I reverted to call panic again. As Aaron pointed out, the partial treatment of v4 did not only not-improve things, rather made them worst. This code along with other panic instances thrown from within threads will have a dedicated patchset. Thanks /Arnon