From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4039C459D8; Thu, 19 Sep 2024 21:43:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30FDC43314; Thu, 19 Sep 2024 21:43:33 +0200 (CEST) Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by mails.dpdk.org (Postfix) with ESMTP id C0CBB400EF for ; Thu, 19 Sep 2024 21:43:31 +0200 (CEST) Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-6c35357cdacso8341276d6.0 for ; Thu, 19 Sep 2024 12:43:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726775011; x=1727379811; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6q25gnpzPrn7imhx6WG0k8vldeaaMCq5+aYr3eY+/zo=; b=NeUbzwOJ30XIsnmKSlOIj8oYQBNGCnBmM7Jp6cl6f6/j+G5IOiREDH065xK/o5DydF 9ONH/fujnriK7ZuCkvfUGayYdyk4/XGBcKT/rteNhboSAihjAzya+jMgX0dDkVYPTmRi a33MMV6SKRLbRLdQo7EJhyS4bBc6cx3heY8PmBSjWdKNKAWv/7OqvZHvt7bCfCL/7e28 wv7jQoSgda0IaqlkPpyPcfprFijw4UO7SoJGj2oAHSMlUMblZQWU7G3kUqnlUnY6SwYq xOYU1SLtDI4IaMSddcHgyVT5vc5M/fBT6gDu2qBFk8jGlmO8IRYTZapK0kln3+1RhgxC yy2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726775011; x=1727379811; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6q25gnpzPrn7imhx6WG0k8vldeaaMCq5+aYr3eY+/zo=; b=QiPkfzrNu1/EOrFaxhy0ya/9RJODlijfEFRaC+vQg1u2LkGprX/EEr03Li+cmihO7M /lJBOljNDsCswyLLeRR/3O8gjkQ77otWpGQ51dqNS87+uUtsYme2mCEn+e3Vjzcu3Pcy tR0XPqAPSvbM9t+EvSDvoyQxqZ0oX0Fsi3eXRQylYJitcp9ai+DDfTMMJ3Sa7KUfP/7r soO0tO9XARckYtbhNBrV/T85MkXNd+Sxg/87tmrGZokgEa4ezm+6t4l1M61ImvhkysD/ xhad9BBcvwlVtw7N0C51u3pJqIEajhJSn73f2Mll8287dEPTVc54dEfr57EiDjqTuZEp b7cg== X-Gm-Message-State: AOJu0YxqVaEgMuHUgl2CKhgORg3SoNXloGAfHZ1OO7zo+qqdx46TqMq4 n2Ncp3jxoLT4yYMWc+xMf/sQuku3tOfLq1kPDKmD25lcRknEcSFLa/DMT8rRTHz+mdYSdK8Subi oRHPgXu068nP1GITAj08rtXyIJ/4chg== X-Google-Smtp-Source: AGHT+IE8xOQ3iqeU9nC1kly4JoZczS9b0NM1q46i5YrYEGREMo7FXpvJq29uYETj8fA+K73ucOm4xb6iMXixPbM2C2c= X-Received: by 2002:a05:6214:5346:b0:6c3:562f:568 with SMTP id 6a1803df08f44-6c7bd37ce5amr2478116d6.0.1726775011032; Thu, 19 Sep 2024 12:43:31 -0700 (PDT) MIME-Version: 1.0 References: <20240807204406.700332-1-igootorov@gmail.com> In-Reply-To: From: Igor Gutorov Date: Thu, 19 Sep 2024 22:42:55 +0300 Message-ID: Subject: Re: [PATCH v3 0/2] net/mlx5: fix reported Rx/Tx desc limits To: viacheslavo@nvidia.com Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, On Wed, Aug 7, 2024 at 11:58=E2=80=AFPM Igor Gutorov = wrote: > > Hi, > > Sorry, I used the wrong --to and --cc switches. > Adding Slava just in case. > > Sincerely, > Igor. > > On Wed, Aug 7, 2024 at 11:44=E2=80=AFPM Igor Gutorov wrote: > > > > Hi, Slava > > > > > > Is an `int` appropriate for `log_max_wq_sz`? Seems like a `uint8_t` > > > > is sufficient, but I've left it an `int` for consistency with the > > > > other `log_max_*` values. > > > > > > Right, uint8_t looks to be enough. No objection to optimize others to > > > uint8_t. > > > > Changed log_max_wq_sz to uint8_t in the main patch. The others are > > changed in a separate patch. Let me know if it'd be preferrable to > > squash the patches. > > > > > > > > > > > 4. Please, format your patch according to the "fix" template. > > > > > > > > I've reworded the commit message a little bit. But I don't see thes= e > > > > issues on Bugzilla, I've stumbled upon them independently. If you'd > > > > like the bug reports to be created, let me know. > > > > > > I meant this: https://doc.dpdk.org/guides/contributing/patches.html > > > Please see chapter "8.7. Commit Messages: Body" about "Fixes" and "Cc= : > > > stable@dpdk.org". > > > > It is a bit difficult for me to reference a commit for the "Fixes", > > since it's a bit hard to call this a regression specifically. I set thi= s > > tag to the commit that first introduced configuring the device. Is that > > appropriate? > > > > > > > > Also, please run checking script: /devtools/check-git-log.sh' -1 to > > > verify commit message compliance. > > > > Thanks! No warnings now, except for "Wrong headline prefix" for the > > first patch because it modifies both common/mlx5 and net/mlx5. I can > > split the patch into two if needed. > > > > > > v3: > > * Added uint8_t optimization > > * Fixed commit messages > > > > v2: > > * Patch reworked to query HCA attributes > > > > Igor Gutorov (2): > > net/mlx5: fix reported Rx/Tx desc limits > > common/mlx5: reduce HCA attribute type sizes > > > > drivers/common/mlx5/mlx5_devx_cmds.c | 1 + > > drivers/common/mlx5/mlx5_devx_cmds.h | 9 +++++---- > > drivers/net/mlx5/mlx5_ethdev.c | 4 ++++ > > drivers/net/mlx5/mlx5_rxq.c | 8 ++++++++ > > drivers/net/mlx5/mlx5_txq.c | 8 ++++++++ > > 5 files changed, 26 insertions(+), 4 deletions(-) > > > > -- > > 2.45.2 > > Review ping :) Thanks! Sincerely, Igor.