DPDK patches and discussions
 help / color / mirror / Atom feed
From: Igor Gutorov <igootorov@gmail.com>
To: yuying.zhang@intel.com
Cc: dev@dpdk.org, Igor Gutorov <igootorov@gmail.com>
Subject: Re: [PATCH] net/i40e: increase descriptor queue length to 8160
Date: Mon, 3 Jun 2024 13:41:59 +0300	[thread overview]
Message-ID: <CAL7bPf0YX1JYE3dPt5jjkgK3ejCcSC-iXVAFP4Hvfj09sXFU4w@mail.gmail.com> (raw)
In-Reply-To: <20240527161921.183866-1-igootorov@gmail.com>

On Mon, May 27, 2024 at 7:20 PM Igor Gutorov <igootorov@gmail.com> wrote:
>
> According to the Intel X710/XXV710/XL710 Datasheet, the maximum receive
> queue descriptor length is 0x1FE0 (8160 in base 10). This is specified
> as QLEN in table 8-12, page 1083.
>
> I've tested this change with an XXV710 NIC and it has positive effect on
> performance under high load scenarios. Where previously I'd get
> ~2000 packets/sec miss rate, now I get only ~40 packets/sec miss rate.
>
> Signed-off-by: Igor Gutorov <igootorov@gmail.com>
> ---
>  drivers/net/i40e/i40e_rxtx.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx.h b/drivers/net/i40e/i40e_rxtx.h
> index 2f2f890855..33fc9770d9 100644
> --- a/drivers/net/i40e/i40e_rxtx.h
> +++ b/drivers/net/i40e/i40e_rxtx.h
> @@ -25,7 +25,7 @@
>  #define I40E_RX_MAX_DATA_BUF_SIZE      (16 * 1024 - 128)
>
>  #define        I40E_MIN_RING_DESC      64
> -#define        I40E_MAX_RING_DESC      4096
> +#define        I40E_MAX_RING_DESC      8160
>
>  #define I40E_FDIR_NUM_TX_DESC   (I40E_FDIR_PRG_PKT_CNT << 1)
>  #define I40E_FDIR_NUM_RX_DESC   (I40E_FDIR_PRG_PKT_CNT << 1)
> --
> 2.45.1
>

CC'ing to a different email (got an address rejected error, the
MAINTAINERS file might need an update).

Also, I've noticed that an X722 NIC is also supported by the i40e
driver, but it seems the datasheet isn't on Intel's website for that
NIC. Does anybody know if X722 has 4096 or 8160 usable descriptors? If
someone could test this patch against X722, that would be great.

  reply	other threads:[~2024-06-03 10:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27 16:19 Igor Gutorov
2024-06-03 10:41 ` Igor Gutorov [this message]
2024-06-05 10:47   ` Igor Gutorov
2024-06-06  9:18     ` Morten Brørup
2024-06-18 12:12 ` Bruce Richardson
2024-06-28 12:28   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL7bPf0YX1JYE3dPt5jjkgK3ejCcSC-iXVAFP4Hvfj09sXFU4w@mail.gmail.com \
    --to=igootorov@gmail.com \
    --cc=dev@dpdk.org \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).