From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5FA54415D; Wed, 5 Jun 2024 12:47:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A227E4067B; Wed, 5 Jun 2024 12:47:44 +0200 (CEST) Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by mails.dpdk.org (Postfix) with ESMTP id 218D340289 for ; Wed, 5 Jun 2024 12:47:43 +0200 (CEST) Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-6ae0dca5929so32273276d6.0 for ; Wed, 05 Jun 2024 03:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717584462; x=1718189262; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mNMPSr9C4M2SfavIYfyT0scDBM+zLvJJY224gT3H3cM=; b=TeuWAHhKt78XCE1o4lO0GbQ+/r8s04F9vUhycbZUg6bdhfJqiOS0Guy2wE8gu2UJuS 6sjVD7ykszMr1T/wVSpVu88e0+j45TDOIME19dVaJH/suYB9j4y91KGXgckik4L1uFPX GEMYPut7gGGSdH2BSp1/e2srzj4dbKGHjNRflrJ8lzRKbI6ZGL8oTBb9NTruoKUziubU vyT5LibOf8jz3+f/ONRrItYvXKqr4ac5vUAbatjt9zfmszpI8uFWu35eFQbuYbvIM1Sb i06CwvKDoGrFPWTj0epSo/DnJYRpHPgv2EAqhuYgsRTbbgwSdInM/yQzCjG66fWpVAMF w/fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717584462; x=1718189262; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mNMPSr9C4M2SfavIYfyT0scDBM+zLvJJY224gT3H3cM=; b=a2pqa1U4ntycI1R7w6at9Gb5Bv6jO44OZmjQ860de5NsEO9ueo491SDFl5ZEllmWlz DZ2k4LYnbYMOazKELrYeDlge71LlNQYWRz4SzCQcRLmzUeFSaRPa9ua2+ENOrfiS2r3o Oih1pjRTACB/7EwGwhAgzYaN+sMd892UXNJqPDPkifj1zrKkGBn61Vcyf18rCYGVqFdO ekEp16Q5vNbULbIfLthtaHVrF6jDn9uxOIo+HVv6k6SUq5sYZPuc0r86FAba043T/04E /dJynixgEl+MdswIzfsaRxEOF05Z9NVBiWEDub13n9Y3uSzns2VipaO39FFV8d2zgdEK +Ylg== X-Gm-Message-State: AOJu0Yw4MEF+RQQgiscYDWrFqimnyOtDgXIUSyQMFuspfjEZaDmye9UM UpiR2zaVOO/xrPMTcDVaflqd5vsg//olLNIqz2j3zMqTCQlAdzlN+gETw9YVyUg1R0aOxRwDwhP irteoFy5S+NPGPzZwLmIkYxC9xdb6LROB X-Google-Smtp-Source: AGHT+IGptDW7KRmjedYgnDLE4eqYfGGFj15QKy7G7m0FD7a9fWrUWlMdqq2+awuZeLQ8P16w7GqwgVfj2fEJyUgpyt0= X-Received: by 2002:a05:6214:3b84:b0:6ad:a239:2431 with SMTP id 6a1803df08f44-6b030a7e3dbmr17742966d6.57.1717584462445; Wed, 05 Jun 2024 03:47:42 -0700 (PDT) MIME-Version: 1.0 References: <20240527161921.183866-1-igootorov@gmail.com> In-Reply-To: From: Igor Gutorov Date: Wed, 5 Jun 2024 13:47:06 +0300 Message-ID: Subject: Re: [PATCH] net/i40e: increase descriptor queue length to 8160 To: yuying.zhang@intel.com Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 3, 2024 at 1:41=E2=80=AFPM Igor Gutorov w= rote: > > On Mon, May 27, 2024 at 7:20=E2=80=AFPM Igor Gutorov wrote: > > > > According to the Intel X710/XXV710/XL710 Datasheet, the maximum receive > > queue descriptor length is 0x1FE0 (8160 in base 10). This is specified > > as QLEN in table 8-12, page 1083. > > > > I've tested this change with an XXV710 NIC and it has positive effect o= n > > performance under high load scenarios. Where previously I'd get > > ~2000 packets/sec miss rate, now I get only ~40 packets/sec miss rate. > > > > Signed-off-by: Igor Gutorov > > --- > > drivers/net/i40e/i40e_rxtx.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/i40e/i40e_rxtx.h b/drivers/net/i40e/i40e_rxtx.= h > > index 2f2f890855..33fc9770d9 100644 > > --- a/drivers/net/i40e/i40e_rxtx.h > > +++ b/drivers/net/i40e/i40e_rxtx.h > > @@ -25,7 +25,7 @@ > > #define I40E_RX_MAX_DATA_BUF_SIZE (16 * 1024 - 128) > > > > #define I40E_MIN_RING_DESC 64 > > -#define I40E_MAX_RING_DESC 4096 > > +#define I40E_MAX_RING_DESC 8160 > > > > #define I40E_FDIR_NUM_TX_DESC (I40E_FDIR_PRG_PKT_CNT << 1) > > #define I40E_FDIR_NUM_RX_DESC (I40E_FDIR_PRG_PKT_CNT << 1) > > -- > > 2.45.1 > > > > CC'ing to a different email (got an address rejected error, the > MAINTAINERS file might need an update). > > Also, I've noticed that an X722 NIC is also supported by the i40e > driver, but it seems the datasheet isn't on Intel's website for that > NIC. Does anybody know if X722 has 4096 or 8160 usable descriptors? If > someone could test this patch against X722, that would be great. Apologies for pinging again. Who should I send my patch to? The MAINTAINERS file shows Yuying Zhang as the maintainer of the net/i40e driver and contains 2 emails, but both Yuying.Zhang@intel.com and yuying.zhang@intel.com emails are non-existent (550 Address rejected).