From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D1B845761; Wed, 7 Aug 2024 22:59:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3539440E01; Wed, 7 Aug 2024 22:59:01 +0200 (CEST) Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by mails.dpdk.org (Postfix) with ESMTP id 90FD540DFD for ; Wed, 7 Aug 2024 22:58:59 +0200 (CEST) Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-6b795574f9dso2054166d6.0 for ; Wed, 07 Aug 2024 13:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723064339; x=1723669139; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gIkjTeNypraJrpps2BOEMNgnCOFdh5NfZ7lJcTUsQWE=; b=O8AXMLN4sYbyN3dzFLW4/thrZfy2Hp5n2uHw6JIp4QVGWQuoQvVRp/eZZcwyoqZ+o9 gRJ6QYi4ZeQk95s2jqgFy31b/CIlhrV76zLRFak4rRzO7x7TPFgiz0NgXp9pt/Fp/pOM fOMJxtC7FNAUGYFc76yvvoXe6WyablA9hzNovaKYCikDOsTEqrWOE8Y50HSfiZQNJHeo K4alUn9gv2y4NzcGj8VKRbqOqBKClYQG2MNbKNGOby/RthzTC+idPW+jZyIFXTQk3n59 QoBBohQUm9nzGadnPNYZppwWdFSKNK0J0zmcy1pvq8hI+C3hkPLyRYFtjAZR1MkOGcC6 nHhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723064339; x=1723669139; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gIkjTeNypraJrpps2BOEMNgnCOFdh5NfZ7lJcTUsQWE=; b=iZNuQCrJuz4SOmG8jVz843qlGB0PMDrI7DUZaf3YUEm9+wagx6UQ009X+SRr0033/V NbYrEpAgxdKGsmP59Zz2BA4wDlK8PRrOlQlRotQo+QGKzV+2nw4PEiyOGgGNAnicI9Nd o5Ow/5dmanTYMZ4MIrZJT7TbYXkEOxByGAVAgOUfHjpMwzqIPgr3HbsL1Hqas5r5+EA0 lCzelg76SyD0r1gyokoi6HxDB/PnFxqOFActsaA7fncq1f1KOFiK7XwSsLfbE5y4I0Xi F3l3Q0yBAAiFjYisSWLqsfN4gw1Zb4YA6snjQNqHm3tHUDl9PmLnoFCptNcL6vHvzp7f cQCQ== X-Gm-Message-State: AOJu0Yzh52i0DZKYgBANIRpGk3M6kdE21iFXczhs9bROtkpO6VcgRwFg 2lLzteso2m4x3eoA/Jeh7HwsFlytZuK1l2pPJXv+DTihdNRNJfAkvgvz4e2QUBLrW1851eGoOFx Q0XWCgFlXIHY1RwVuSP8AZ+N/kkw= X-Google-Smtp-Source: AGHT+IFWdlRermFhPv0ggIoqJ+ELdTC1eft6Uv4FegI+xmc3DQQwNJGxvKuaLzHqppdYHPsbfyL4lw1A8uXAvGx9Gls= X-Received: by 2002:a05:6214:3384:b0:6b5:7e70:3537 with SMTP id 6a1803df08f44-6bb984192b9mr191097876d6.50.1723064338633; Wed, 07 Aug 2024 13:58:58 -0700 (PDT) MIME-Version: 1.0 References: <20240807204406.700332-1-igootorov@gmail.com> In-Reply-To: <20240807204406.700332-1-igootorov@gmail.com> From: Igor Gutorov Date: Wed, 7 Aug 2024 23:58:22 +0300 Message-ID: Subject: Re: [PATCH v3 0/2] net/mlx5: fix reported Rx/Tx desc limits To: viacheslavo@nvidia.com Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Sorry, I used the wrong --to and --cc switches. Adding Slava just in case. Sincerely, Igor. On Wed, Aug 7, 2024 at 11:44=E2=80=AFPM Igor Gutorov = wrote: > > Hi, Slava > > > > Is an `int` appropriate for `log_max_wq_sz`? Seems like a `uint8_t` > > > is sufficient, but I've left it an `int` for consistency with the > > > other `log_max_*` values. > > > > Right, uint8_t looks to be enough. No objection to optimize others to > > uint8_t. > > Changed log_max_wq_sz to uint8_t in the main patch. The others are > changed in a separate patch. Let me know if it'd be preferrable to > squash the patches. > > > > > > > > 4. Please, format your patch according to the "fix" template. > > > > > > I've reworded the commit message a little bit. But I don't see these > > > issues on Bugzilla, I've stumbled upon them independently. If you'd > > > like the bug reports to be created, let me know. > > > > I meant this: https://doc.dpdk.org/guides/contributing/patches.html > > Please see chapter "8.7. Commit Messages: Body" about "Fixes" and "Cc: > > stable@dpdk.org". > > It is a bit difficult for me to reference a commit for the "Fixes", > since it's a bit hard to call this a regression specifically. I set this > tag to the commit that first introduced configuring the device. Is that > appropriate? > > > > > Also, please run checking script: /devtools/check-git-log.sh' -1 to > > verify commit message compliance. > > Thanks! No warnings now, except for "Wrong headline prefix" for the > first patch because it modifies both common/mlx5 and net/mlx5. I can > split the patch into two if needed. > > > v3: > * Added uint8_t optimization > * Fixed commit messages > > v2: > * Patch reworked to query HCA attributes > > Igor Gutorov (2): > net/mlx5: fix reported Rx/Tx desc limits > common/mlx5: reduce HCA attribute type sizes > > drivers/common/mlx5/mlx5_devx_cmds.c | 1 + > drivers/common/mlx5/mlx5_devx_cmds.h | 9 +++++---- > drivers/net/mlx5/mlx5_ethdev.c | 4 ++++ > drivers/net/mlx5/mlx5_rxq.c | 8 ++++++++ > drivers/net/mlx5/mlx5_txq.c | 8 ++++++++ > 5 files changed, 26 insertions(+), 4 deletions(-) > > -- > 2.45.2 >