From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0566045B00; Thu, 10 Oct 2024 11:07:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1256402D8; Thu, 10 Oct 2024 11:07:27 +0200 (CEST) Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by mails.dpdk.org (Postfix) with ESMTP id C9B6C400D6 for ; Thu, 10 Oct 2024 11:07:26 +0200 (CEST) Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6cbe53a68b5so4927216d6.1 for ; Thu, 10 Oct 2024 02:07:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728551246; x=1729156046; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1od4PXxUlWAXgUobEOhjaZ+oOmjfV9qwJ/qrFoNubIA=; b=RBghSOcIIrFeya5bDoEwyBIp4HLQMJPnaPKMEkWHfMX0nE5wMenWNDIZH8ZWOCRMto 7tTVZf3buNx1h+IBDgtHiocHP8fEKhsNSuHdPUqboAFDCQnpzQLaIKduahJgs6wmvLL1 fpGZJyg8mYvcLTkZMaYiQgP6ncLvfXfGV0l7+M8y2r/trbXQ9ZEffusNdJQ1AelAYGyG y6gZtiFt2ktiJ56lLJvn88z614jPlxsoX/fg7LuxTVWn/aO4JoyHzkAxN5ZyazmCT0Ce 7csGWOXsMRL0kDs56WCX8rHhO2P3SwGmNMOUO51tnjrAYW0pBFIUzHZVnle2iM42uauP 3tpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728551246; x=1729156046; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1od4PXxUlWAXgUobEOhjaZ+oOmjfV9qwJ/qrFoNubIA=; b=wD+PMNSAFG/9WCm7R5xrBkQty3Q/m7iyU2qKXgyUSSb4UDTzOT7AGZNIq30LrTkPbn Zc2/b4j1IOoYFkCBzJHmoUidRb5+RSKCg/kxfukPa8vN24OvYQaZMr1ebmFNqCP3lhdy PiY9N30Y/IG1GcvyT69Ef2qRt0nDU0i2xQ8yCUeuTaae00U0iqDclm/2tnKkycXUH4gW MfwPV+8HQch9M/gEtkVGXs6ueXI6GKMUK161Dgm2wKCiZ4gwShPRqvTmNCVVRPdgIMeo dhYLodBwdRC3B8oW0mMpuImppytHVHU9eRrrs5yMXF3EtRuBoPWRW9c3y928Ry89zq5h Xwwg== X-Forwarded-Encrypted: i=1; AJvYcCXxvSvgGpMP7XqBvl8vTz1xk3lFmC7AbLpcsGnkXEMF+iOdleN4Lwv+JbXhXr5H869jPlo=@dpdk.org X-Gm-Message-State: AOJu0Yw2Tm9LR67JsvPaOefLeH9Qi4IlFZwqt1ApsyyqevFI9HKrVpKH i1iEYWaT7rgCCpBw19mUGidNjUzDVaJYPvNhLtdHhWAhn28gdy35HSAW9yfRiB0N+jdxqbWtimg DCOUGOWM+7IT52uSb/zSJ8P/U60M= X-Google-Smtp-Source: AGHT+IEO0a/RhLGbh61qwTX1W6J+M2HuBPLUjZ0MQFFZbRdjxxZIqYy/icFdQpwpnOPiHOwDfJ/CbgT4I4GdLXDJ4xM= X-Received: by 2002:a05:6214:468c:b0:6cb:d512:e6ea with SMTP id 6a1803df08f44-6cbe4a2c263mr39128776d6.11.1728551246043; Thu, 10 Oct 2024 02:07:26 -0700 (PDT) MIME-Version: 1.0 References: <20240616173803.424025-1-igootorov@gmail.com> <20240616173803.424025-2-igootorov@gmail.com> <20241009171853.77e8dce7@hermes.local> In-Reply-To: <20241009171853.77e8dce7@hermes.local> From: Igor Gutorov Date: Thu, 10 Oct 2024 12:06:50 +0300 Message-ID: Subject: Re: [PATCH 1/1] net/mlx5: show rx/tx descriptor ring limitations in rte_eth_dev_info To: Stephen Hemminger Cc: Slava Ovsiienko , Dariusz Sosnowski , Ori Kam , Suanming Mou , Matan Azrad , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen, On Thu, Oct 10, 2024 at 3:18=E2=80=AFAM Stephen Hemminger wrote: > > On Mon, 17 Jun 2024 07:18:58 +0000 > Slava Ovsiienko wrote: > > > Hi, Igor > > > > Thank you for the patch. > > > > 1. The absolute max descriptor number supported by ConnectX hardware is= 32768. > > 2. The actual max descriptor number supported by the port (and its rela= ted representors) > > reported in log_max_wq_sz in HCA.caps. This value should be querie= d and save in mlx5_devx_cmd_query_hca_attr() routine. > > 3. mlx5_rx_queue_pre_setup() should check requested descriptor number a= nd reject if it exceeds log_max_wq_sz > > 4. Please, format your patch according to the "fix" template. > > > > With best regards, > > Slava > > > Marking this patch as Changes Requested. > Yes, this comment expands the scope of the original patch; but if this pa= rt of the mlx5 > is going to change, might as well get it right. I'm new to DPDK development, but if it makes sense, I guess this can be marked as "Canceled" (or something like that). There's a v2 of this patch [1], and a v3 [2]. You've left some suggestions on v2, so I'm going to send a v4. [1]: https://lore.kernel.org/all/20241009171853.77e8dce7@hermes.local/T/#me= cef40b9e98711313e4189d42b0d50676e6d9e5e [2]: https://lore.kernel.org/all/20241009171853.77e8dce7@hermes.local/T/#md= 042e15b4642df69127b023144948681b3072af5 -- Igor