From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7DD7A04C2; Fri, 15 Nov 2019 08:32:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8AA3D1BE86; Fri, 15 Nov 2019 08:32:56 +0100 (CET) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id D756A1BE82 for ; Fri, 15 Nov 2019 08:32:54 +0100 (CET) Received: by mail-io1-f68.google.com with SMTP id s3so9404122ioe.3 for ; Thu, 14 Nov 2019 23:32:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K+gcEkq/S5f+/U6K9V8ehFecUEaEYYNloYA0jJYDD2c=; b=c7KQZ9EPjGx4rHmzrPyFyQVP6RDbQzmNnneURHBsb+uIr+8yb+h5BrfodAl5CmcXUZ rmjJ7zqORVcevdyDdX2H+HSQHRFJcXhyrWZZSMMWLR2SNadakJ4yyHucyBpmaOeMh3fD LRVAheXd76gdehMjDX3qnRk6yeiTs1GS8SV7DPUMPm3J3QePbWjy60/O/uthFTtKGlfL LvZ5q431z0AP0i1gD37e+dca6O/V+jtiO7VrjqpEAYKw2EvvyjG53y6cOsqsAsVxNsLr qrYe44i6drOuF0ROZGhoYvmSPUleskinlxm57gOAthRtQZr3tOTfTIT9TJKSGICvU2F/ L5XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K+gcEkq/S5f+/U6K9V8ehFecUEaEYYNloYA0jJYDD2c=; b=LnAZDCRmEydXOoORmbnx4ZCkAxw9khGSFLHoJfzqhUBzMDzfbI+Wc+cJlNI407yyib Fgjq33RGtJzPiYgJiohdAeY0SI8Rp8yyuRadfnflcly7DCXgmMo4W0TtWLNr5o98rOAk D0UheuEZqGu4lx5ffPqmEBqLr8A2UR+lvC2nB0IKXOhwa/cRkD2BDEmTvyYYYHW6KAYT QZwroAX4/4nuKaxL9sK3zjExRSpP+cchJSGRyl8OIzOY4JaxJGW3Au+lQ4Y/81uTTVyR bFKeo8a4euswNFzIZuffmbhjvwEt084pZpnp/SF8P0XXi1odfi0W0DdMATePNQNOD/0v 0A/A== X-Gm-Message-State: APjAAAUBpBQNh27bXFbohirj0EhD8vBP6pBmq3iI0k18iqPgVDcWKp0s OOadHnQcQCeaGrqz1JsA7+jIp/IBsv3v5luIchQ= X-Google-Smtp-Source: APXvYqxTVgHZDXQf7LaevBp5aRUhY+2ZQqPMupTvrAZ6fKppdtjjL2GodvA/eQAtS3XrhRV0Qfv8Wg+WvOXNOe1jmpI= X-Received: by 2002:a05:6638:6b6:: with SMTP id d22mr11475811jad.60.1573803173534; Thu, 14 Nov 2019 23:32:53 -0800 (PST) MIME-Version: 1.0 References: <1573478474-17984-1-git-send-email-anoobj@marvell.com> In-Reply-To: <1573478474-17984-1-git-send-email-anoobj@marvell.com> From: Jerin Jacob Date: Fri, 15 Nov 2019 13:02:37 +0530 Message-ID: To: Anoob Joseph Cc: Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Ferruh Yigit , Andrew Rybchenko , Narayana Prasad , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: fix exit paths after cq init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 11, 2019 at 6:51 PM Anoob Joseph wrote: > > After otx2_nix_register_cq_irqs() is called and the IRQs are setup, > otx2_nix_unregister_cq_irqs() need to be called in the subsequent error > exit paths. > > Fixes: d34db5ccbf30 ("net/octeontx2: fix driver reconfiguration") > > Signed-off-by: Anoob Joseph Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > --- > drivers/net/octeontx2/otx2_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c > index aab34db..18aa0f5 100644 > --- a/drivers/net/octeontx2/otx2_ethdev.c > +++ b/drivers/net/octeontx2/otx2_ethdev.c > @@ -1700,13 +1700,13 @@ otx2_nix_configure(struct rte_eth_dev *eth_dev) > rc = cgx_intlbk_enable(dev, eth_dev->data->dev_conf.lpbk_mode); > if (rc) { > otx2_err("Failed to configure cgx loop back mode rc=%d", rc); > - goto q_irq_fini; > + goto cq_fini; > } > > rc = otx2_nix_rxchan_bpid_cfg(eth_dev, true); > if (rc) { > otx2_err("Failed to configure nix rx chan bpid cfg rc=%d", rc); > - goto q_irq_fini; > + goto cq_fini; > } > > rc = otx2_nix_mc_addr_list_install(eth_dev); > -- > 2.7.4 >