From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E74F743B95; Thu, 29 Feb 2024 19:27:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D33A5402ED; Thu, 29 Feb 2024 19:27:39 +0100 (CET) Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) by mails.dpdk.org (Postfix) with ESMTP id 66A51402CD; Thu, 29 Feb 2024 19:27:38 +0100 (CET) Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-4d35ab44ba9so71956e0c.1; Thu, 29 Feb 2024 10:27:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709231257; x=1709836057; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=i5xeFLW4cJKTH5+EXyyPXGtTy9dYMPHq2f8qN3Efy0o=; b=POcbHsppvt/fIE3jZ4Z1uTKNjWJQ1l4+olZUAfUDxLRxGux8E0rWVCXgJ07gOiS9ZS JFC7sz6CCMFwBXSYSfD84pUQO3NSNgiZiELVDvUatdNWH8Idi95Vyq7RX0+1xTnlTRXH YQYRw+M252rtYt64KedbT4cOMsMvtqoCo036OiU9Fr+ZOZZfIJvAbJh97SP8PeCnms84 l4/GetgcQ3llTsuaGN6BkJXdoNnvG9UNVz9/dW+wTD0Tzn2pBcpV0X1/xYs1SMuSkSq2 MUVojUP4Poo0+B5JwRi0xhEFNMYYMAqGPLU/7r32cBTQjH1pQDYx5e4hdwpNh6o5fN46 3Jyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709231257; x=1709836057; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i5xeFLW4cJKTH5+EXyyPXGtTy9dYMPHq2f8qN3Efy0o=; b=b2wkYsrx+47O+mQdSoOa3ogS/USnmh1XmOlUYw2QewNMzpEPM55kWIuQnkJlAAaFXS 7gR2Z2nqv9OgTTofJo0AG/LSH1bHSntVJX7i6/dPJR00Gpc8dLgnINAxjhHZX/Um/fC9 Vw1/NjWJcUfPNTEgbAT5iZIfcYgOWjCLW1MbeZVA9OoKqQxkMW+4bvG+c7EfXwWi7rrc S5pFN9cd/rt0fprATyjKRH+K9iSs7b/+MwR5erfulXvybqdep29aryxxmV/gDQW3Lk3g xNeuqBhjDgZKZoNC1nGwfmBnsjYW98E18DzzVdVAaY986fwDp7hSDzfXp8btd80fQfzl i+8w== X-Forwarded-Encrypted: i=1; AJvYcCVJUvzLaAMpcW/VA0SfyvBked25lKNpn3VLocNzKx1NBQQGCqTOALvIsFpBiTyZP5S3xF2GXa+DzVso6Lurzq4= X-Gm-Message-State: AOJu0YxdsSESToK9P5dRTzSgJYDLWUuP5+1Wodae7J3bC9KHmafhmljJ MxEgExyviETcEVvEKveQTmjPkppgF9VH9ehJ/gZoUm3W45e/71zPuC1AoKxUfqgoClijfitAbdJ MxIUFM+ji9uOXLMhhtiidJgdFRZ0= X-Google-Smtp-Source: AGHT+IFM/mTdn+NgGue4fWClq8uhBOyQrKaXjdxMO1M3IR4etnSG59yeClzqFyOeX1XjSnJC9HPk/fBbwTrTsOjR3iM= X-Received: by 2002:a1f:da42:0:b0:4d1:3f5a:75f3 with SMTP id r63-20020a1fda42000000b004d13f5a75f3mr2625952vkg.15.1709231257614; Thu, 29 Feb 2024 10:27:37 -0800 (PST) MIME-Version: 1.0 References: <20240227144247.1562499-1-rbhansali@marvell.com> In-Reply-To: <20240227144247.1562499-1-rbhansali@marvell.com> From: Jerin Jacob Date: Thu, 29 Feb 2024 23:57:11 +0530 Message-ID: Subject: Re: [PATCH] net/cnxk: performance improvement for SW mbuf free To: Rahul Bhansali Cc: dev@dpdk.org, Pavan Nikhilesh , Shijith Thotton , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rakesh Kudurumalla , jerinj@marvell.com, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 27, 2024 at 8:13=E2=80=AFPM Rahul Bhansali wrote: > > Performance improvement is done for Tx fastpath flag MBUF_NOFF when > tx_compl_ena is false and mbuf has an external buffer. > In such case, Instead of individual external mbuf free before LMTST, > a chain of external mbuf will be created and free all after LMTST. > This not only improve the performance but also fixes SQ corruption. > > CN10k performance improvement is ~14%. > CN9k performance improvement is ~20%. > > Fixes: 51a636528515 ("net/cnxk: fix crash during Tx completion") > Cc: stable@dpdk.org > > Signed-off-by: Rahul Bhansali > --- > Depends-on: series-31225 ("[v5,01/14] common/cnxk: remove cn9k Inline IPs= ec FP opcode defines") There are CI failures[1] due to dependency. Now that the above series is merged, Could you resend it again. Also, Please update the release note for the PMD section. [1] https://patches.dpdk.org/project/dpdk/patch/20240227144247.1562499-1-rbhans= ali@marvell.com/