From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A82BDA2F67 for ; Fri, 4 Oct 2019 10:49:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BAE181C1DE; Fri, 4 Oct 2019 10:49:33 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 0EEAF1C1D0; Fri, 4 Oct 2019 10:49:32 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id v2so11796765iob.10; Fri, 04 Oct 2019 01:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4CSRus18glkb/TmvRoy0xImTODZkxizgNBGpK1oH9gk=; b=ks70/yHMgjRitZMVam+w/l1YO7refuxKETaBG4Z0sucL82VaFyR2tKsRmF9n1o9l71 JF5gEbeKMA2w3fAWm3Kh/ruDNpgj7e6HlCB1/z6NdaL7zdCMD3HCLceEPQ8LUwV3jO98 sNjS5sFVqHv5EK0mC95yecuezA61ZmvhKkHeAUWHUxV05CnB5wgRuARSVoQxHLufA9DB KSMwRs30YEsmcqwA0ZemChz11UowBwJ5aJP8vc41H+9xMu57pEtB/kDlWTzTtx3Ut/UW Kpx8mZulOQv7HCwv+eCwfP6l+M85QevXpOPUEGVdKNzhGndZWn73nWd/DlVm5jT0J3ym jyrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4CSRus18glkb/TmvRoy0xImTODZkxizgNBGpK1oH9gk=; b=l4begjM8XF/hY9ptNdVDWWjPT3YVB6Iiyz9MPLR3OdtPqlGrYALya4NuvIloatJrkh zOr+/u9N7/dDORsBT/FX/h3tY9KtlQK+kGjd7+yhNcMUCX1pwB4zleQXNHT2SqHR/lxl LWecD0UNoxAyNgegkIeHRIZeeu5KvqQKfCUg7xahhFuroyDLanzbQKPdOWo5R0HxxOys 1m0speMsDLRnn8YJgvgdcsrSA0E4ErrDudJNG/1P/blF/X80FEVGJ9X8C7a2dVOI+l8E u3vgaKjGRVcAkXj3tiKyornDKPYBPWK6U2XlDVx8ltEq22+Cd9tF8Ypfo9iIelz16JT1 cinA== X-Gm-Message-State: APjAAAXqL0mBqvpb5Aqg5Un8yCELdZhw7SqW3RpKML4sORQ+eoCklwFd vQfpV2TaR992bnelW/U35AuLDrLr+ZwO2KtKwf4= X-Google-Smtp-Source: APXvYqwJbfEnPBU4Tk8iffDbObj5gspKX6wLqkpJDMVwluGkWpivAcMbjEznWeix2/kmeisK28cDcDZ4CTWLQDef1G4= X-Received: by 2002:a92:bbd2:: with SMTP id x79mr14849293ilk.162.1570178971260; Fri, 04 Oct 2019 01:49:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jerin Jacob Date: Fri, 4 Oct 2019 14:19:20 +0530 Message-ID: To: Rasesh Mody Cc: David Marchand , "dev@dpdk.org" , "stable@dpdk.org" , Shahed Shaikh , Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/qede: only access sw rx ring index for debug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 3, 2019 at 11:59 PM Rasesh Mody wrote: > > >From: David Marchand > >Sent: Friday, September 27, 2019 4:29 AM > > > >---------------------------------------------------------------------- > >Caught by clang, this idx value is only used for a debug message when the > >mbufs allocation fails. > >No need to use idx as a temporary storage. > > > >Fixes: 8f2312474529 ("net/qede: fix performance bottleneck in Rx path") > >Cc: stable@dpdk.org > > > >Signed-off-by: David Marchand > >--- > > Acked-by: Rasesh Mody Changed the subject to "net/qede: only access SW Rx ring index for debug" to fix check-git-log.sh warning. Applied to dpdk-next-net-mrvl/master. Thanks > > drivers/net/qede/qede_rxtx.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > >diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c > >index c38cbb9..1fbeba2 100644 > >--- a/drivers/net/qede/qede_rxtx.c > >+++ b/drivers/net/qede/qede_rxtx.c > >@@ -46,8 +46,6 @@ static inline int qede_alloc_rx_bulk_mbufs(struct > >qede_rx_queue *rxq, int count) > > int i, ret = 0; > > uint16_t idx; > > > >- idx = rxq->sw_rx_prod & NUM_RX_BDS(rxq); > >- > > if (count > QEDE_MAX_BULK_ALLOC_COUNT) > > count = QEDE_MAX_BULK_ALLOC_COUNT; > > > >@@ -56,7 +54,9 @@ static inline int qede_alloc_rx_bulk_mbufs(struct > >qede_rx_queue *rxq, int count) > > PMD_RX_LOG(ERR, rxq, > > "Failed to allocate %d rx buffers " > > "sw_rx_prod %u sw_rx_cons %u mp entries %u free > >%u", > >- count, idx, rxq->sw_rx_cons & NUM_RX_BDS(rxq), > >+ count, > >+ rxq->sw_rx_prod & NUM_RX_BDS(rxq), > >+ rxq->sw_rx_cons & NUM_RX_BDS(rxq), > > rte_mempool_avail_count(rxq->mb_pool), > > rte_mempool_in_use_count(rxq->mb_pool)); > > return -ENOMEM; > >-- > >1.8.3.1 >