From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCE59440E7; Mon, 27 May 2024 17:20:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB693402D8; Mon, 27 May 2024 17:20:18 +0200 (CEST) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by mails.dpdk.org (Postfix) with ESMTP id C8E514068A for ; Mon, 27 May 2024 17:20:17 +0200 (CEST) Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-43f984101e4so28540991cf.0 for ; Mon, 27 May 2024 08:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716823217; x=1717428017; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MAJcpHUDkZPEpTCLu9ySyNyNyS9GzczXF7hmGZhhpVk=; b=fG1PtKDTTXLnDTBDffT4w5QeThOR1urqgGikQ5ejDHMM41kAhF4WcnV8AgMrmXUAQ9 sCcgN+LgrKwfJrUSTHTMu6kNceXVRIbsWstjN79LgZu9nbmJ3fXbFEe5c7t/e/ZiRwlK EjI7X1jY99bvacKCB1Nl33y8cgNcBFX4TU2/gCCr62qXso97lCz4tVZnpyIrrmTvtpNK 5Oks3XWzp+u6t73pafhi+sLPzihmge0qgW5XN/ZOFrmmqpnpcQLOWFDaRT8G5S72bZRf 62Bu2KWJaSHO6swjAOYucpAosDv1ZeOcTsMYcAhPLynnpcLFrlCPTyyHMVpNYnFGy2DP r5rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716823217; x=1717428017; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MAJcpHUDkZPEpTCLu9ySyNyNyS9GzczXF7hmGZhhpVk=; b=eoLrtVH5RbKTyDKN1jqiyUlNp22e4yOv7jYNS05862N/t9Tztn2lXA/rYdOlHU+lI/ KPYyOOQ8EnMNPY0424/M9PYBVFXs5KxdJBlOiWEONi5N0fQ7HZt/ywTvp7TNec66ufSn aoq5hEJclP+fmS219LamhDqiIfQCltEw6YfyVg015p0m5S0LEjgCMHOzUJ+nN3JQ4gYH /PmW+qXEnxcpEMBh9t2DwMo9fqj4DrsVEDon5sSz62tY83pukew7ickjI7UUPyfS+Ziz 7rhUs31D11C5pgE5rfisnDxewUTRZZoifzU0rvFWAwzLyQdwI6otqvp5z6BdTM/GfMLd DP1Q== X-Gm-Message-State: AOJu0YzGc7wLLA6mQPXZkav/i737Hnv9TRapHl/CldCvJXDeo+x0zWr9 UQtUaktPjAc6lsbtHibMgd0vpgatXI+JeCmnQGyXwpfWd8I64OM9SNvwYVbLz5Q9CMHXBPcCMr0 K7LY6FIBa1kKmF56CY9bcfl+H5xg= X-Google-Smtp-Source: AGHT+IENVmMMTlir/rAbbbaDGbni9TlowxYrYc1Z3ksBIW1B+mNvR1E4gexsy9XXdubW5TEHW7RayZKp4j77yZ3CDxA= X-Received: by 2002:ac8:5984:0:b0:43d:f8a0:5802 with SMTP id d75a77b69052e-43fb0f06767mr120524071cf.63.1716823217023; Mon, 27 May 2024 08:20:17 -0700 (PDT) MIME-Version: 1.0 References: <20240501194620.1199357-1-abdullah.sevincer@intel.com> <20240501194620.1199357-2-abdullah.sevincer@intel.com> In-Reply-To: <20240501194620.1199357-2-abdullah.sevincer@intel.com> From: Jerin Jacob Date: Mon, 27 May 2024 20:49:51 +0530 Message-ID: Subject: Re: [PATCH v4 1/3] event/dlb2: add support for HW delayed token To: Abdullah Sevincer Cc: dev@dpdk.org, jerinj@marvell.com, mike.ximing.chen@intel.com, tirthendu.sarkar@intel.com, pravin.pathak@intel.com, shivani.doneria@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, May 2, 2024 at 1:16=E2=80=AFAM Abdullah Sevincer wrote: > > In DLB 2.5, hardware assist is available, complementing the Delayed > token POP software implementation. When it is enabled, the feature > works as follows: > > It stops CQ scheduling when the inflight limit associated with the CQ > is reached. So the feature is activated only if the core is > congested. If the core can handle multiple atomic flows, DLB will not > try to switch them. This is an improvement over SW implementation > which always switches the flows. > > The feature will resume CQ scheduling when the number of pending > completions fall below a configured threshold. To emulate older 2.0 > behavior, this threshold is set to 1 by old APIs. SW sets CQ to > auto-pop mode for token return, as tokens withholding is not > necessary now. As HW counts completions and not tokens, events equal > to HL (History List) entries will be scheduled to DLB before the > feature activates and stops CQ scheduling. 1) Also tell about adding new PMD API and update the release notes for PMD section for new feature. 2) Fix CI http://mails.dpdk.org/archives/test-report/2024-May/657681.html > > Signed-off-by: Abdullah Sevincer +/** Set inflight threshold for flow migration */ > +#define DLB2_FLOW_MIGRATION_THRESHOLD RTE_BIT64(0) Fix the namespace for public API, RTE_PMD_DLB2_PORT_SET_F_FLOW_MIGRATION_..= . > + > +/** Set port history list */ > +#define DLB2_SET_PORT_HL RTE_BIT64(1) RTE_PMD_DLB2_PORT_SET_F_PORT_HL > + > +struct dlb2_port_param { fix name space, rte_pmd_dlb2_port_params > + uint16_t inflight_threshold : 12; > +}; > + > +/*! > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior no= tice > + * > + * Configure various port parameters. > + * AUTO_POP. This function must be called before calling rte_event_port_= setup() > + * for the port, but after calling rte_event_dev_configure(). > + * > + * @param dev_id > + * The identifier of the event device. > + * @param port_id > + * The identifier of the event port. > + * @param flags > + * Bitmask of the parameters being set. > + * @param val > + * Structure coantaining the values of parameters being set. Why not use struct rte_pmd_dlb2_port_params itself instead of void *. > + * > + * @return > + * - 0: Success > + * - EINVAL: Invalid dev_id, port_id, or mode > + * - EINVAL: The DLB2 is not configured, is already running, or the port= is > + * already setup > + */ > +__rte_experimental > +int > +rte_pmd_dlb2_set_port_param(uint8_t dev_id, > + uint8_t port_id, > + uint64_t flags, > + void *val);