From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6260A2EDB for ; Mon, 30 Sep 2019 08:43:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5F7092A6C; Mon, 30 Sep 2019 08:43:35 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id A9ECE29C6; Mon, 30 Sep 2019 08:43:24 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id a1so35361454ioc.6; Sun, 29 Sep 2019 23:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Th4158HvZ0fqSBI7lWOGYfyU320FFXJBZlpUpAlyHPI=; b=bsfQ0r8ZNx/en6afSHCvfRjzdPq74etj5lcvtOGdYSNfaZcG2jpaZdkoT68UDxfW8K 07M/1+iR3TSbM8yowXpPYvaQBj2yk+D6kXadZgyPKBBJr3LBCyI+1u99+5/5eLVCxDPT 8Zl3eAXKYDC08tQhpsr7l+H6I+OF1SPmh1XYdMYsOsFvd2YtP3aZu9DEVBcDDmGDboDm jBI/eMPpWkpAPCaMPzOwsqr9g8H9wa7E8J0KQfB2G9Lq5d3OuAIKGH3OvcWTJlJEvQRT hILxBrTJNwDnAAYZU0K/UNh+ifmQ4792E3preBfGI8YQCi25OxHuwY9sN0Xn+Vo5tGbt cUhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Th4158HvZ0fqSBI7lWOGYfyU320FFXJBZlpUpAlyHPI=; b=LTn8K2i4AE+wbRAn5BSATCXli0ysVHb2KJBJSy9/Y2j3riJ86H6CfbIgKWhfYbYvF5 zJz9Wvc2Gw3UKeM42dNKeoDS9pPQXVEKKUz7TBjJZOWRWUmRHZcIUtlX608xhaLIB6gg jcbCNj27bnJC9AVFUBCx4KAdUGBOg+Qb4QZ6g1KRGdTcho+tJlItXU6Jei2KKu9pG40i ZIDt5qMBu8fMzQL6m1XGFouqDoqpoz0U+bWX7YUbQN+a4uq1tdhqaAqG+ROIhvYylz2g w6Czx4PulL7Vm8CBrzsp5h+E/njQYOTRAYBk4+y8y26KE9Hin6cuNCwEDgYnhYJWBknH pd/A== X-Gm-Message-State: APjAAAVi22UF/S5hYIdipiuMq755nGMXaO86MEMP7rAwenboYmhDizFy /MYYy4IdjzaHyrF2aV4KHgRfjJpwrORnVb2ZU6g= X-Google-Smtp-Source: APXvYqwclnmhWpdrcoeO+dSKB2d9gUed/PuFqzSaYkPAJjnLbDbZL6ebYIKHcFy6s8RbAryq8o+yr1ebxEXWn+J84+Y= X-Received: by 2002:a92:1598:: with SMTP id 24mr17483474ilv.60.1569825803895; Sun, 29 Sep 2019 23:43:23 -0700 (PDT) MIME-Version: 1.0 References: <20190907064209.30686-1-hemant.agrawal@nxp.com> <20190927075841.21841-1-hemant.agrawal@nxp.com> <20190927075841.21841-2-hemant.agrawal@nxp.com> In-Reply-To: <20190927075841.21841-2-hemant.agrawal@nxp.com> From: Jerin Jacob Date: Mon, 30 Sep 2019 12:13:13 +0530 Message-ID: To: Hemant Agrawal Cc: dpdk-dev , Jerin Jacob , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/6] event/dpaa2: fix def queue conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 27, 2019 at 1:31 PM Hemant Agrawal wrote: > > Test vector expect only one type of scheduling as default. > The old code is provide support scheduling types instead of default. > > Fixes: 13370a3877a5 ("eventdev: fix inconsistency in queue config") > Cc: stable@dpdk.org > Signed-off-by: Hemant Agrawal 1) Patch version is missing 2) Shared library build failure. http://mails.dpdk.org/archives/test-report/2019-September/099288.html Please send the next version with fixes. /usr/bin/ld: dpaa2_eventdev_selftest.o: in function `rte_mempool_get_ops': dpaa2_eventdev_selftest.c:(.text+0x224): undefined reference to `rte_mempool_ops_table' /usr/bin/ld: dpaa2_eventdev_selftest.o: in function `rte_mbuf_raw_alloc': dpaa2_eventdev_selftest.c:(.text+0x8d4): undefined reference to `rte_mempool_check_cookies' /usr/bin/ld: dpaa2_eventdev_selftest.c:(.text+0x8f5): undefined reference to `rte_mbuf_sanity_check' /usr/bin/ld: dpaa2_eventdev_selftest.o: in function `rte_pktmbuf_reset': dpaa2_eventdev_selftest.c:(.text+0xa26): undefined reference to `rte_mbuf_sanity_check' /usr/bin/ld: dpaa2_eventdev_selftest.o: in function `__rte_pktmbuf_free_direct': dpaa2_eventdev_selftest.c:(.text+0xb47): undefined reference to `rte_mbuf_sanity_check' /usr/bin/ld: dpaa2_eventdev_selftest.c:(.text+0xc15): undefined reference to `rte_mempool_check_cookies' /usr/bin/ld: dpaa2_eventdev_selftest.o: in function `rte_pktmbuf_free': dpaa2_eventdev_selftest.c:(.text+0x23cf): undefined reference to `rte_mbuf_sanity_check' /usr/bin/ld: dpaa2_eventdev_selftest.c:(.text+0x2408): undefined reference to `rte_mbuf_sanity_check' /usr/bin/ld: dpaa2_eventdev_selftest.c:(.text+0x2535): undefined reference to `rte_mbuf_sanity_check' /usr/bin/ld: dpaa2_eventdev_selftest.c:(.text+0x2603): undefined reference to `rte_mempool_check_cookies' /usr/bin/ld: dpaa2_eventdev_selftest.o: in function `_eventdev_setup': dpaa2_eventdev_selftest.c:(.text+0x4142): undefined reference to `rte_pktmbuf_pool_create' /usr/bin/ld: dpaa2_eventdev_selftest.o: in function `eventdev_teardown': dpaa2_eventdev_selftest.c:(.text+0x465d): undefined reference to `rte_mempool_free' collect2: error: ld returned 1 exit status > --- > drivers/event/dpaa2/dpaa2_eventdev.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c > index 926b7edd8..b8cb437a0 100644 > --- a/drivers/event/dpaa2/dpaa2_eventdev.c > +++ b/drivers/event/dpaa2/dpaa2_eventdev.c > @@ -1,7 +1,5 @@ > /* SPDX-License-Identifier: BSD-3-Clause > - * > - * Copyright 2017 NXP > - * > + * Copyright 2017,2019 NXP > */ > > #include > @@ -470,8 +468,7 @@ dpaa2_eventdev_queue_def_conf(struct rte_eventdev *dev, uint8_t queue_id, > RTE_SET_USED(queue_conf); > > queue_conf->nb_atomic_flows = DPAA2_EVENT_QUEUE_ATOMIC_FLOWS; > - queue_conf->schedule_type = RTE_SCHED_TYPE_ATOMIC | > - RTE_SCHED_TYPE_PARALLEL; > + queue_conf->schedule_type = RTE_SCHED_TYPE_PARALLEL; > queue_conf->priority = RTE_EVENT_DEV_PRIORITY_NORMAL; > } > > -- > 2.17.1 >