From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30CC9A057B; Wed, 1 Apr 2020 19:52:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 077021C0BD; Wed, 1 Apr 2020 19:52:22 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 0094E1C0B6 for ; Wed, 1 Apr 2020 19:52:19 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id m15so628734iob.5 for ; Wed, 01 Apr 2020 10:52:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AL3glxiI1KSwS1zmUA8AabutYQg/RLr0Gx5VY2qcMAY=; b=LZ2XWVYZqa5Y2agdP3f4Rn4itpfLIXqRUO0wfZvKAAgTS35bV4e5kNZ7gKfdtArEWE 2Kk7xSphCxxjiBIiJMCtKuva9J9w3K/NiCZq2mE7mZ6Z/v79Y0prUyN61t7WSJvQLKlm tdBGDtTydcmAAHdeKCaXdBfn+qxbKucH4XVTHaN/kEGFNDzIb+Ed2gfkpGu6P1zYCxta JqsSyT1fY1bptxOSi/CEvXh9bTxJn7k1V82jK0Hq4Fwnf1y9SacnTuqyCdKiy2Ji8Ton oQ796Xln4sv+0EAD0MITh4nBVjF1fdXV0O4spicssNp3aD/MZ40itFVD9IQMjdVFDT1X k/tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AL3glxiI1KSwS1zmUA8AabutYQg/RLr0Gx5VY2qcMAY=; b=nHanptf9A1Vtkfc+CQM42YmqEqFlXjZ6yn6b5qxFWz69y0s83wnvB5Lp5ejFKlMFEC IS2PJ8tWS+vmDPvKEgm6FsZiax2mlbGKKqkcrb3rXSQ+y36klcyZIFFVZ2cwfXZeaORY vhmBoSm4D8dVVtG5Vth3g/TMnf0HUlogkmy8ircxGWqfPK4x5XYvJA4wmuZFsIO9kfM/ 1/vNuMj1U1K0viZtViilVbcw2D6gUWipBngh9OKK2gN6J6q6OiE9z4esYtaleaT+djvx 8+yhVJi1YSUED4h83eiQVEH4dKm9Oj45Q+hqxn4sJouoEuoQ0hBHNgf/JPsRys8qys3o PSNA== X-Gm-Message-State: ANhLgQ0zPDyIZEXlNwREesI4+vMz4H+JaGF0aw89zG15afU0EQU4Xx4f Y7twEqm1YMqA82UwXEmPoFav5CyHt1k93OY7YSM= X-Google-Smtp-Source: ADFU+vs8myM9TqBJ3Jn/34vYAGYg9ijvFx2FRafJSgPrypwf/xb3HcdRPUa65fwxG8sGEYUGipqugk9dX6fzHnAP6JI= X-Received: by 2002:a5d:87c6:: with SMTP id q6mr16384253ios.163.1585763539117; Wed, 01 Apr 2020 10:52:19 -0700 (PDT) MIME-Version: 1.0 References: <20200325211603.240288-1-jerinj@marvell.com> <20200329144342.1543749-1-jerinj@marvell.com> In-Reply-To: From: Jerin Jacob Date: Wed, 1 Apr 2020 23:22:01 +0530 Message-ID: To: David Marchand Cc: Jerin Jacob Kollanukkaran , Thomas Monjalon , dev , Bruce Richardson , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Sunil Kumar Kori , "Yigit, Ferruh" , Andrew Rybchenko , Declan Doherty , Olivier Matz , Neil Horman , Ray Kinsella Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 1, 2020 at 11:02 PM David Marchand wrote: > > On Wed, Apr 1, 2020 at 6:25 PM Jerin Jacob wrote: > > On Wed, Apr 1, 2020 at 7:42 PM David Marchand wrote: > > > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob wrote: > > > > I assume the patch content will be: > > > > 1) Removing experimental API from app, lib, drivers, examples with > > > > make and meson > > > > 2) Have it enabled at the global level. > > > > > > examples are a special case as they can be compiled out of the dpdk sources. > > > This is why I excluded them of the list in my mail before. > > > > There are a lot of examples already that have ALLOW_EXPERIMENTAL_API. > > What is the issue in enabling ALLOW_EXPERIMENTAL_API in the in tree > > example application? > > I did not say there is an issue in keeping this flag in the example makefiles. > > examples makefile should be self sufficient (like an external > application makefile would be) and are called directly in our building > test scripts: see devtools/test-meson-builds.sh. > So I don't see how it would work if you remove this flag from all > examples makefiles and rely on some global thing. Thanks for the clarification. I will update meson.build and Makefile in examples. devtools/test-meson-builds.sh tests[1] the the below apps, "cmdline helloworld l2fwd l3fwd skeleton time" What is your preference, Adding in all the examples or above selected ones? [1] # if pkg-config defines the necessary flags, test building some examples if pkg-config --define-prefix libdpdk >/dev/null 2>&1; then export PKGCONF="pkg-config --define-prefix" for example in cmdline helloworld l2fwd l3fwd skeleton timer; do echo "## Building $example" $MAKE -C $DESTDIR/usr/local/share/dpdk/examples/$example clean all done fi > > > -- > David Marchand >