From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E450A04EF; Mon, 25 May 2020 13:00:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6C7C81D8E3; Mon, 25 May 2020 13:00:37 +0200 (CEST) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id 042CF1D8CC; Mon, 25 May 2020 13:00:36 +0200 (CEST) Received: by mail-il1-f194.google.com with SMTP id a14so16985919ilk.2; Mon, 25 May 2020 04:00:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AyifmEZUqCwmxmX3ts1cfLKSCbVQmOplUAi7iygp0mI=; b=TWKtryaqb80J4+0svXHTM8kiMWlVI4PtHjHW6NHOh+tjXIk1xd3EEwcz/gZjO3tS2h VSTS4k3dAg20Cj4mYyCg+eIZSyLqTlgiGLK3qxzIN7/qELtRO6WkSLrmnbw3+qD8aEwa Sr3cCqjNgN3IXMJg0EyXnbcF64iba69ZZdE5KKUpdEX5FuGl6EG2+B4wWpXE7Z0nZRR6 YFfwev0MmCNu0neWywoTTOBd1vRwitIAAbwHEfEV11EO++YIIy+da4N/CoydSbk26Rd0 1UATLUoT7EXsBCKsJ8gN4A7yKrkb3PmgPdgJx4i8Z7c2kyVvYEmMZHvQcELiV08TUvq9 F+Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AyifmEZUqCwmxmX3ts1cfLKSCbVQmOplUAi7iygp0mI=; b=Dv1x+54LuODKfdo3kKB0B2CfmyIgHtE1Lj2YVKV7YMx7HBY6A5z1cmoslceo1f8RBu R6aJhGJabHHOxqe6ZMaCZ7//Gem0xFqb1y+yJcOvN8bE5Vy6deocx3PBJh6EW1CTFGrc uwKj1uDIwiNC7yAc0VVeHBuBZH9W73O8G19vtb6QIHii86I+mnBNbGVf7CRZoC+MuZfr mKdmDT9ah3roi36S5dGaSpAXYKxPr9U3NfxbiDP1x0HK4wf3GwlXrNmko8WHtbMc6Onn q1X5ixjQmpGuymoB8AJIvbiIkvrcaDLl1S1N+rB+qwZkl16prLNUniHwX7RBjimxS74W 0vuA== X-Gm-Message-State: AOAM533j5EDwm/9j8nxmNGgxhjPnG0jBlxhVXo5iV2l+1nHdk87vzG71 CqzslHTYrR3ekBTFfrcsZWh3mD+g8qHlUj+VToY= X-Google-Smtp-Source: ABdhPJzi23ORnbS+K1A9hZ8bNvwoqa0Maa1v4ohVQkHSztr68YBg/ppuSBdzDkSdOivMsXe4Kc7gtmr++V+5nryyjcI= X-Received: by 2002:a92:d188:: with SMTP id z8mr22489151ilz.60.1590404436268; Mon, 25 May 2020 04:00:36 -0700 (PDT) MIME-Version: 1.0 References: <98CBD80474FA8B44BF855DF32C47DC35C60FEA@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C60FEA@smartserver.smartshare.dk> From: Jerin Jacob Date: Mon, 25 May 2020 16:30:20 +0530 Message-ID: To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: techboard@dpdk.org, dpdk-dev , "Jim St. Leger" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] Consider improving the DPDK contribution processes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Here are a couple of anonymous examples from the mailing list: > > An infrequent contributor got minor coding style suggestions to a patch, = although the coding style was similar to that of a closely related function= in the same library, but not perfectly matching the official coding style.= I think we could be more lax about coding style, except if the coding styl= e directly violates automatic coding style validation tools. > > Another infrequent contributor got patch style feedback about a small pat= ch, suggesting to split it up into three patches. The official contributing= guide says that small changes should be kept together in the same patch. T= he patch in question could be considered three bug fixes, so splitting it u= p might be appropriate, or it could be considered fixing three variations o= f the same bug, so keeping it together as one would be appropriate. I think= we could be more lax about patch style, except if the patches are complete= ly incomprehensible. > A lot of patch style can be fixed automatically through clang-format. Please find below the Linux kernel documentation for its clang-format and u= sage. https://www.kernel.org/doc/html/latest/process/clang-format.html https://github.com/torvalds/linux/blob/master/.clang-format Maybe we could add .clang-format file for DPDK. I have been using the following clang-format configuration for DPDK[1] May be for once, we need to fix the coding standard issue with the existing codebase using clang-format. [1] "{ BasedOnStyle: LLVM, IndentWidth: 8, TabWidth: 8, UseTab: Always, AllowShortIfStatementsOnASingleLine: false, IndentCaseLabels: false, ColumnLimit: 80, AllowShortFunctionsOnASingleLine: false, AlwaysBreakAfterReturnType: AllDefinitions, ColumnLimit: 80, ConstructorInitializerAllOnOneLineOrOnePerLine: true, ConstructorInitializerIndentWidth: 8, ContinuationIndentWidth: 8, BreakBeforeBraces: Linux, AllowShortBlocksOnASingleLine: false, AlignConsecutiveAssignments: false, AlignEscapedNewlines: Right, AlignConsecutiveMacros : true, MaxEmptyLinesToKeep : 1, Cpp11BracedListStyle : true, AlignTrailingComments : true, ForEachMacros: ['STAILQ_FOREACH', 'rte_graph_foreach_node', 'TAILQ_FOREACH', 'RTE_ETH_FOREACH_DEV']}",