From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48FD342BDF; Tue, 30 May 2023 09:35:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 221E540F18; Tue, 30 May 2023 09:35:15 +0200 (CEST) Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) by mails.dpdk.org (Postfix) with ESMTP id 2330C406BC for ; Tue, 30 May 2023 09:35:14 +0200 (CEST) Received: by mail-vk1-f181.google.com with SMTP id 71dfb90a1353d-45a0ee1c411so1260095e0c.0 for ; Tue, 30 May 2023 00:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685432113; x=1688024113; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=v+6AYDFX5riW1Awz6iBpK2MtUgRVBh415kDPGzXU3I8=; b=aOaqw7XxLogr3/YdwlS3ik5d6fzoA3KizgAsSMzDC7sjU/rpVjsF3kYB1/7gjjIgLh rjZcmbEGH/RTs7VfDVbQjlQCiIBKXk0qVQ8BoH9qORoJcNv0fUSpDd/E44D083EaPthk 92OOULpy/7UZW7S7p0+EKbkETqSW5dQNgQRvmWGg59Y74ABQL9RZFBJL5zMcTqQ95ssx hgv+Ic+qZwPdY9oEo5/FddAK5aPjY6lP8WrSTi7BImNKmT+6UyfEZmjD12Vr6h9kCGFC tMUTVNzI/HDe09l7z8LOt8vxjSIvf//mGocvCgyca1yb4WU/82KPcpefEfxJtLVtNLPS T1RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685432113; x=1688024113; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v+6AYDFX5riW1Awz6iBpK2MtUgRVBh415kDPGzXU3I8=; b=UvLZbqSSRID5R0IZDjfU7g4jMjq9SThJ4uFA8HROj33AaKcsdOwIYeIU99OKfCntT7 boEeJ8QBmlSVcAeNO9G8xZAVVEwmSdzjIBlSiz2GZaiGRYt5JWkJIGch7UtBHdP/5rRx WGOT+c9XU/fdd8o1QhLCmIPSUv9eRSqh7HVfCxCa2RF7zQAXJY03vz7FV3dIN62VQ6xa LA4jCA9ewcnL9K3k8t4VJC+qafyOQCpywNK9vTQzLTlCyx1DOvwvmOSJBxJSphX4++Bp gol/fJb39Zsuxf/YkRBe4wyAAtmU06acCJeMVZJdUlf5OLtKF/DqYcPAaQVqMrmIWS6n qvDw== X-Gm-Message-State: AC+VfDwrS4gBhJ/TE6A1tGZgV3mS/ShOrqMYcnpcs98YS337uZjXJiQD +nrJ7rf2nXpkc7VRuEoFV8mLKoy98IaxIgvxsoI= X-Google-Smtp-Source: ACHHUZ5uLsRSdOcjs8Mr3D6vZO+/UMp/TXbY95X/d3nIW15ktbTSzX2xqTRCTkG3Z1GwT+tgRHfYXE+ofZON+SpUNgM= X-Received: by 2002:a1f:5ecd:0:b0:457:400a:f3fc with SMTP id s196-20020a1f5ecd000000b00457400af3fcmr320959vkb.2.1685432113300; Tue, 30 May 2023 00:35:13 -0700 (PDT) MIME-Version: 1.0 References: <20230421060245.3136217-1-vattunuru@marvell.com> <20230425131516.3308612-1-vattunuru@marvell.com> <20230425131516.3308612-5-vattunuru@marvell.com> In-Reply-To: From: Jerin Jacob Date: Tue, 30 May 2023 13:04:47 +0530 Message-ID: Subject: Re: [PATCH v2 4/4] app: add testgraph application To: Vamsi Krishna Attunuru Cc: "Yan, Zhirun" , "dev@dpdk.org" , "thomas@monjalon.net" , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , "Liang, Cunming" , "Wang, Haiyue" , Sunil Kumar Kori Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, May 22, 2023 at 12:37=E2=80=AFPM Vamsi Krishna Attunuru wrote: > > > +static int > > > +link_graph_nodes(uint64_t valid_nodes, uint32_t lcore_id) > > > +{ > > > + int ret =3D 0; > > > + > > > + num_patterns =3D 0; > > > + > > > + if (valid_nodes =3D=3D (TEST_GRAPH_ETHDEV_TX_NODE | I think, if we need to extend the C code for adding new use case, then it will not scale. IMO, We should look at more runtime and file based interface. Something like https://github.com/DPDK/dpdk/blob/main/examples/ip_pipeline/= examples/l2fwd.cli In nutshell, 1) File based interface to kick-start the valid use case enablement 2) Less logic in C code and everything should be driven from config file 3) Allow runtime change. examples/ip_pipeline provides telent interface to update . Similar concept can be followed. I think, we should push the app for next release. Not on this release. Sorry for reviewing late.