From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C58442D04; Tue, 20 Jun 2023 08:56:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4CE2042BD9; Tue, 20 Jun 2023 08:56:54 +0200 (CEST) Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by mails.dpdk.org (Postfix) with ESMTP id E21E942BD9 for ; Tue, 20 Jun 2023 08:56:52 +0200 (CEST) Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-76391e63725so180870085a.3 for ; Mon, 19 Jun 2023 23:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687244212; x=1689836212; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=P13E+QgoeA+OPaL3th7v0s7w5yxOIKyFupF8zgJr3N0=; b=NiBP1ieGIN/N4PW4kiyAQtOicwyNZJ0yHSPaWkANUVxPNmWo2H5od76+hnPCwWumby X1tWsWEcTjoe2BJdQlRHeIHNxj0aKpxCK2oB/wUg9ExAPcYt3e45dBBQvWOiiNkt1HrK S1jNTxf6DJaGNsiK2prAF+fAhhAaqHeMynlqCr6dwUen9LO++MVZbu0hw8IJsF+T2fB4 x9YQmd6QJm5dsViGZHn8GwpcfOeZjF/bwdq1bPobWhqsC452cmAJNlhDFu6XdKtnrT8Z hi8a3lr+oo3Yo+G9rBLQBaksxjYpzn+LqsHke502M8LNUYoVKvp63AbD/VMmQWaLOeaH k62g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687244212; x=1689836212; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P13E+QgoeA+OPaL3th7v0s7w5yxOIKyFupF8zgJr3N0=; b=Z11tkgYfSSJWNACVOIqla3c7QYRci1CwxRuOm37tEGI15xAUl6cRMXkdgvmwae6BZh pGSqFVQr6SkxOErmXsMnIAtnj5SnPphjL9ogihUweLuvoggGXG7MnFP8Hi+5UJBgV1HV oSKlOi7mv93m8ZRuc2R0O3VAb/tId0E38GH3sTV8Pp73iiZeoldYroZjYkvkU8sHYMfJ EwelDdf/KNK1yGd3ZuhZcz7QqGIYHpL4o913/Rn9y3SurQmBc2q16sFsp/DyDFXdGgL6 ijBwIDdVgwq4rND6GepWydUoHKDz9P0ASQtbGfEYL5G1IaMB+zbdr9AEnoODcWKOgbB2 t0dw== X-Gm-Message-State: AC+VfDz7uO9OxKsDK9sEHNv00Sk1BbSObsB1HuM3UK9AKSIZfZNS9Wuo wrR9d12E32hjqVTtQCI6tw6YwP48HjpHFGa4EkTzCZRF+09z3A== X-Google-Smtp-Source: ACHHUZ4OeEcbnyQ643YDRas9yszHVXmwqKBDnVjbr42go5QyviGiWG2T5Wa/TVFlgLm/U92YkTIZy41eRfoP5YCGnQQ= X-Received: by 2002:a37:db01:0:b0:762:1cf8:f01a with SMTP id e1-20020a37db01000000b007621cf8f01amr9939674qki.14.1687244212205; Mon, 19 Jun 2023 23:56:52 -0700 (PDT) MIME-Version: 1.0 References: <20230619204650.3348681-1-david.marchand@redhat.com> <20230619204650.3348681-2-david.marchand@redhat.com> In-Reply-To: <20230619204650.3348681-2-david.marchand@redhat.com> From: Jerin Jacob Date: Tue, 20 Jun 2023 12:26:26 +0530 Message-ID: Subject: Re: [PATCH 2/2] lib: make graph optional To: David Marchand Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 20, 2023 at 2:17=E2=80=AFAM David Marchand wrote: > > Allow disabling of the graph library in builds. Good to make graph as optional. I did not check the build, will examples/l3fwd-graph/ skip automatically ? > > Signed-off-by: David Marchand > --- > +if dpdk_conf.has('RTE_LIB_GRAPH') Can devtools/test-meson-builds.sh updated to check build with disabling all optional libs? > + test_sources +=3D 'test_graph.c' > + fast_tests +=3D [['graph_autotest', true, true]] > + fast_tests +=3D [['node_list_dump', true, true]] > + test_sources +=3D 'test_graph_perf.c' > + perf_test_names +=3D 'graph_perf_autotest'