From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B39DA0505; Thu, 7 Apr 2022 16:40:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3FA441143; Thu, 7 Apr 2022 16:40:01 +0200 (CEST) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by mails.dpdk.org (Postfix) with ESMTP id E4B1C41141 for ; Thu, 7 Apr 2022 16:39:59 +0200 (CEST) Received: by mail-io1-f53.google.com with SMTP id z6so7071332iot.0 for ; Thu, 07 Apr 2022 07:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=g5JWLGMQkhnuexXzEihHze/wDT6EwDP42CrSjsdOEzU=; b=qAVEnPLZl5lPwGzQ8lyWFAjDhv+FZW87WFdxr99+flh6ORezT0Bc/MljIwzbs/jP4G lGO0RuQV4aAruA1+dsCAiBXdNZLfPlDCXAqw4PbxJbSZiQ1hHyH2kNYPfzkraAE5JZ6Z GTkaCjIz/0IIT7qml0yDbHZ4J6F/qMNvvx0AHaEBNPSN3EumAf+kSdAH9C4YUxhJrChx LzH6vlZYOEaQIqmyAosrb1jLuBPhlipbGALEPUwZv2bOn2Ai2XjuN7zETgLbseSjtlGr IQfyohmGS45eJC2b/yqCjwwCHJMlAHi4P6+rCtu2kQ364vmOMeh9jeZIZqeOcm55EfYX OPpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=g5JWLGMQkhnuexXzEihHze/wDT6EwDP42CrSjsdOEzU=; b=X5ze0xidEirO5a765Hv+J5IRbIbjM8N5KWAPAoDrOSN61aFTfSBLWwupGjFOL9swKI 3kS9hr7WOCgr0jVNsyCdrIdBhZNceg+zm31kdPXmZH3G1Ea+Kw16ZDBBRLSvXSZXaqlU aM1fXCwKd96EFNVtE09PI5Rpkogsu94KAU++1HjEhoBjYm6Lk29x3y1rDsm21rjAR+zo ljJLoTG98PQvIaMksFt9CGLsYJ1srnDWPnq2QqtWjzyIgTT/QJMB5gDpWoJ0HUFm/NnU yoHTPZWqfF1J9H/01iLqUkZy3Z3LZAwpF2K9tyL8BGuNpS3HGv7d7uGr3KYmMQMQKLBO xXVg== X-Gm-Message-State: AOAM531OveDfEKwZ3Z0Oh3P4wpML631aAg0x5o8naH0U6kAEzp2neCm5 TNjG9Odq7nIwiMP+HFRaTGwJWUGKQGbYbfWeaPU= X-Google-Smtp-Source: ABdhPJwu8iARuiANLM1kfEDpI5MU3M8hEA5EEo5HyFOBhBYk+88Vyj0gxrktJcg7c7/VSQbfAcEMHT6dZR+4HUJ+ZO4= X-Received: by 2002:a05:6638:1503:b0:323:ef25:d6f8 with SMTP id b3-20020a056638150300b00323ef25d6f8mr7234703jat.158.1649342399268; Thu, 07 Apr 2022 07:39:59 -0700 (PDT) MIME-Version: 1.0 References: <20220214120246.4181470-1-jerinj@marvell.com> <20220301085824.1041009-1-skori@marvell.com> In-Reply-To: From: Jerin Jacob Date: Thu, 7 Apr 2022 20:09:33 +0530 Message-ID: Subject: Re: [PATCH v3 1/1] ethdev: mtr: support input color selection To: "Dumitrescu, Cristian" Cc: "skori@marvell.com" , Thomas Monjalon , "Yigit, Ferruh" , Andrew Rybchenko , Ray Kinsella , "dev@dpdk.org" , Jerin Jacob Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 7, 2022 at 6:55 PM Dumitrescu, Cristian wrote: > > > > > To summarize we have 4 attributes, Please find below the truth table > > 1) Outer VLAN > > 2) Outer IP > > 3) Inner VLAN > > 4) Inner IP > > > > > > Inner IP -Inner VLAN- Outer IP-Outer VLAN > > 0 0 0 0 > > - Not valid case > > 0 0 0 1 > > - RTE_MTR_INPUT_COLOR_METHOD_OUTER_VLAN > > 0 0 1 0 > > - RTE_MTR_INPUT_COLOR_METHOD_OUTER_IP > > 0 0 1 1 > > - RTE_MTR_INPUT_COLOR_METHOD_OUTER_VLAN_OUTER_IP - If found outer > > VLAN > > then vlan else outer IP > > 0 1 0 0 > > - RTE_MTR_INPUT_COLOR_METHOD_INNER_VLAN > > 0 1 0 1 > > - RTE_MTR_INPUT_COLOR_METHOD_INNER_VLAN_OUTER_VLAN - If found > > inner > > VLAN else outer VLAN > > 0 1 1 0 - > > RTE_MTR_INPUT_COLOR_METHOD_INNER_VLAN_OUTER_IP > > 0 1 1 1 - > > RTE_MTR_INPUT_COLOR_METHOD_INNER_VLAN_OUTER_IP_OUTER_VLAN - > > If found > > inner vlan then inner vlan else outer IP else outer VLAN > > 1 0 0 0 - > > RTE_MTR_INPUT_COLOR_METHOD_INNER_IP > > 1 0 0 1 - > > RTE_MTR_INPUT_COLOR_METHOD_INNER_IP_OUTER_VLAN > > 1 0 1 0 - > > RTE_MTR_INPUT_COLOR_METHOD_INNER_IP_OUTER_IP > > 1 0 1 1 - > > RTE_MTR_INPUT_COLOR_METHOD_INNER_IP_OUTER_IP_OUTER_VLAN > > 1 1 0 0 - > > RTE_MTR_INPUT_COLOR_METHOD_INNER_IP_INNER_VLAN > > 1 1 0 1 - > > RTE_MTR_INPUT_COLOR_METHOD_INNER_IP_INNER_VLAN_OUTER_VLAN > > 1 1 1 0 - > > RTE_MTR_INPUT_COLOR_METHOD_INNER_IP_INNER_VLAN_OUTER_IP > > 1 1 1 1 - > > > > RTE_MTR_INPUT_COLOR_METHOD_INNER_IP_INNER_VLAN_OUTER_IP_OUTE > > R_VLAN > > > > Is this above enumeration fine, If not, Please suggest. > > > > In Interms of name, > > a) We could omit explicit OUTER to reduce the length as suggestion. > > b) or change IIP, OIP, IVLAN, OVLAN kind of scheme to reduce the name. > > > > Let me know the names and enumeration you prefer, I will change > > accordingly in the next version? > > > > Hi Jerin, > > The above table looks confusing to me, I suggest we have a meeting next w= eek to go over it and then report back to the list? Scheduled a meeting at 11th April - 6:30 IST Agenda: To discuss https://patches.dpdk.org/project/dpdk/patch/20220301085824.10410= 09-1-skori@marvell.com/ patch Let me know, If time needs to change to include any interested participants= . Hi there, Jerin Jacob is inviting you to a scheduled Zoom meeting. Topic: Jerin Jacob Kollanukkaran's Personal Meeting Room Join Zoom Meeting: https://marvell.zoom.us/j/9901077677?pwd=3DT2lTTGMwYlc1YTQzMnR4eGRWQXR6QT09 Password: 339888 Or Telephone=EF=BC=9A Dial(for higher quality, dial a number based on your current location)= =EF=BC=9A US: +1 301 715 8592 or +1 312 626 6799 or +1 346 248 7799 or +1 646 558 8656 or +1 669 900 6833 or +1 253 215 8782 or 888 788 0099 (Toll Free) or 833 548 0276 (Toll Free) or 833 548 0282 (Toll Free) or 877 853 5247 (Toll Free) Meeting ID: 990 107 7677 Password: 358309 International numbers available: https://marvell.zoom.us/u/adpcCpMHYt Or a Video Conference Room: >From Touchpad: Tap Join Zoom button. When prompted, enter 990 107 7677 Password: 358309 For China locations, from Touchpad: Dial* then 990 107 7677 Password: 358309 > > Regards, > Cristian