From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE5DBA0588; Thu, 16 Apr 2020 15:26:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 18E8C1DCB0; Thu, 16 Apr 2020 15:26:13 +0200 (CEST) Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id 60A9C1DCAB for ; Thu, 16 Apr 2020 15:26:12 +0200 (CEST) Received: by mail-il1-f195.google.com with SMTP id i2so6816727ils.12 for ; Thu, 16 Apr 2020 06:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o3tGL5qfUm722yI0RLzWEXHUuTOYbCAw66iyvs1OB5E=; b=oMB6g66e03jJeFdkX88G3U2Pup6qu7A2oJF7jMAW+VRjCOYzQpgfvG4UJA5JHwMGoX 12XWTpS4VJ7ZLDbOu+wCCveSKVrbTHXIC6sskfHNuKxwC9Dc2d/dyC6H7WDSzWdaarSA Ejmty6h0Kk/YFwO3tKHgTUZfbCsRYkBIYSYUS0Pot2BFNzUslKZ7PzELV3Kp//gNF66/ CaZL+JibUjeUu4L7KKs6FtkngeJqGEsok7LtkMvYUarmuVk0dzagX5Ll/FUjs9NPyj+E o4W3V/AUYgSd0q1GjUAmi/fnjhLnR/CJIPSktxSQntcHscT2/vBx0EQ5w5zHMkzKD12X 7j/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o3tGL5qfUm722yI0RLzWEXHUuTOYbCAw66iyvs1OB5E=; b=X2DWY7L2PBG5tO0FcTV0zyw2+lAxkJM9dNpQGDUbKSv2/XP0RoS2DURPihd6aL0UIv BVNYKrxCVPbNt45b/VF0s2Y/vgzBT5PWfESj12jCW3gkpjbd1C5dcgTXpaF4Dt58Op8+ ZqzNK5S/opSwu7Pnvoipg2Wj90FFTxEHhvAKm4OBC9Z4ARzZ13j/nmHarUqdIHFowpHp W0yY6iXyzw8t+B3NP6QwmdvBchD4bM26scc95WVhBwsnUdOd4NvYEEo5dpjEtcOuo6yZ jzCDwCphn/nl72BwSMIknPMRF983GwNcCseMh/gStmSgba6+NmUIdGJkWtMu9Ed6jon1 xt9w== X-Gm-Message-State: AGi0PuZeGjijEnAvtXJThJqOamCKlF0gyDBmIOUZCN3JMVwWlCiigxvE plmx9obAmkNC2HpBORGGDGffjcLsLQL/6mvYFRW04w== X-Google-Smtp-Source: APiQypILucweILg9eglm31FfYqUDic0TxsM2lk/gXq5r4cURnnBnH6A1iMHdFRvx+YP0i3gY60NwrpoRJw1vrZdZu0c= X-Received: by 2002:a05:6e02:790:: with SMTP id q16mr6047275ils.60.1587043571513; Thu, 16 Apr 2020 06:26:11 -0700 (PDT) MIME-Version: 1.0 References: <1587043415-10955-1-git-send-email-lbartosik@marvell.com> In-Reply-To: <1587043415-10955-1-git-send-email-lbartosik@marvell.com> From: Jerin Jacob Date: Thu, 16 Apr 2020 18:55:55 +0530 Message-ID: To: Lukasz Bartosik Cc: Pavan Nikhilesh , Jerin Jacob , Anoob Joseph , Narayana Prasad , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] event/octeontx2: fix queue removal from Rx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 16, 2020 at 6:54 PM Lukasz Bartosik wrote: > > When eth port queue is removed from Rx adapter using > rte_event_eth_rx_adapter_queue_del() it incorrectly > initializes CQ context instead of modifying it. This > might lead to a crash when CQ context is modified > as a part of rte_eth_dev_stop() sequence as CQ will > hold invalid entries. This is responsibility of an > application to call rte_event_eth_rx_adapter_queue_del() > to remove eth port queue from Rx adapter in tear down > sequence. Please add Fixes: tag and cc stable. > Signed-off-by: Lukasz Bartosik > --- > drivers/event/octeontx2/otx2_evdev_adptr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/event/octeontx2/otx2_evdev_adptr.c b/drivers/event/octeontx2/otx2_evdev_adptr.c > index 233cba2..8bdcfa3 100644 > --- a/drivers/event/octeontx2/otx2_evdev_adptr.c > +++ b/drivers/event/octeontx2/otx2_evdev_adptr.c > @@ -133,7 +133,7 @@ sso_rxq_disable(struct otx2_eth_dev *dev, uint16_t qid) > aq = otx2_mbox_alloc_msg_nix_aq_enq(mbox); > aq->qidx = qid; > aq->ctype = NIX_AQ_CTYPE_CQ; > - aq->op = NIX_AQ_INSTOP_INIT; > + aq->op = NIX_AQ_INSTOP_WRITE; > > aq->cq.ena = 1; > aq->cq.caching = 1; > @@ -144,7 +144,7 @@ sso_rxq_disable(struct otx2_eth_dev *dev, uint16_t qid) > > rc = otx2_mbox_process(mbox); > if (rc < 0) { > - otx2_err("Failed to init cq context"); > + otx2_err("Failed to enable cq context"); > goto fail; > } > > -- > 2.7.4 >