From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B3FAA0351; Mon, 10 Jan 2022 08:20:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7FD8B411C9; Mon, 10 Jan 2022 08:20:27 +0100 (CET) Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by mails.dpdk.org (Postfix) with ESMTP id 92E714013F; Mon, 10 Jan 2022 08:20:25 +0100 (CET) Received: by mail-io1-f47.google.com with SMTP id h23so16224954iol.11; Sun, 09 Jan 2022 23:20:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5ddQjVIKIJJB3x7Hf56ukJ4/97UZm8bfmHG4P2vdvYI=; b=D4KnfK9tJYaXnc7uZ5LPQCj2slbLsTP4xE2BHnI8RnT/P/LIiSi60q3jKGoHmlTfVB GvJEKmz/9wT89eXn7FcUZaOAxO24vzmuT6drzfAqRqtho4+TLgYbMLrnHkJiMj6UZeEl 7UlWDqXI/6tpoKe+KaHIyfJDdLEZQCvUNFrTJgjJ/8h78AfHvZjf5DFihgwKkrhYVgQj mKCNQNQ7I+TZBzT0l9aVqIwlxfFmm7+U2sugSbo6GSSNw2/h79mL/hqXdCb92Wwqr8f1 CiDHwmUYw00SVg5P+Q/dwyAQgJt6orueOeTd4ATXvnNoprxJBoRQM88wCSDxmEOWjYme cE2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5ddQjVIKIJJB3x7Hf56ukJ4/97UZm8bfmHG4P2vdvYI=; b=5RRsGNHoijJ8nJ8X6JnYmDlVfKLhsABM3XdQyLKGuhO9bPf4DuNd5HZZGxyjDE0Ddj o8+rxU9S7prlK+B1llt7In09DWqJyxvbFpQ2KocZMb27NRqhlapOIqCrjGthvz0PFENz w1o7lfbq+nnyxPI01ezepsEdehSDTEfECNl4o+XcDG5I+WkLrMDwgI0tiIfB/ihCj2Ek 0baM6JzFgKC0LhO5eAZGBk+Qy5vlHwrB0qNo+454Jap8eEihwfd7t49FuxQvIFb6re+c 8DkPxtUvxuxsElCfO72EYI3MqfUkWAybX2pL5P0mHn1Q6vtgiEj+NCWTJAN6VdeXhus/ 2MYQ== X-Gm-Message-State: AOAM533EZ4ONWeQanNJdNUyd+/kD/MnOAHcydX6jiwgxrKe2VkqKDaIK DedkG07FHL78FHHAqkFv67txwbcLudmNmXaRnAM= X-Google-Smtp-Source: ABdhPJzs2vbERKyXkEfHMQk9PscSuTmCJuA+tk7JWQclIORIMGEtit7ppKOpmA83Tp4fjBQiWMmrURqIY0K8JMh0Xjg= X-Received: by 2002:a05:6602:1410:: with SMTP id t16mr36401374iov.160.1641799224612; Sun, 09 Jan 2022 23:20:24 -0800 (PST) MIME-Version: 1.0 References: <7105742b042a813a391466d6706bb809c1bd9569.1638291548.git.anatoly.burakov@intel.com> In-Reply-To: <7105742b042a813a391466d6706bb809c1bd9569.1638291548.git.anatoly.burakov@intel.com> From: Jerin Jacob Date: Mon, 10 Jan 2022 12:49:58 +0530 Message-ID: Subject: Re: [PATCH v1 1/1] net/qede: fix redundant condition in debug code To: Anatoly Burakov Cc: dpdk-dev , Rasesh Mody , Devendra Singh Rawat , Igor Russkikh , dpdk stable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 30, 2021 at 10:29 PM Anatoly Burakov wrote: > > Expression "a && 1" is equivalent to just "a", so fix the accidental > inclusion of a literal in code. > > Cc: stable@dpdk.org > > Fixes: ec55c118792b ("net/qede: add infrastructure for debug data collection") > Cc: rmody@marvell.com Hi @Rasesh Mody @Devendra Singh Rawat @Igor Russkikh Please review this patch to merge. > > Signed-off-by: Anatoly Burakov > --- > > Notes: > This isn't a bug, this is just a syntactic anomaly, likely a remnant of some > kind of debugging code. > > This issue was found with Control Flag [1], which i ran on DPDK codebase just > out of curiosity. This was the only issue worth addressing that the tool > produced output for. > > [1] https://github.com/IntelLabs/control-flag > > drivers/net/qede/qede_debug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/qede/qede_debug.c b/drivers/net/qede/qede_debug.c > index 2297d245c4..ba807ea680 100644 > --- a/drivers/net/qede/qede_debug.c > +++ b/drivers/net/qede/qede_debug.c > @@ -3522,7 +3522,7 @@ static enum dbg_status qed_grc_dump(struct ecore_hwfn *p_hwfn, > > /* Dump MCP HW Dump */ > if (qed_grc_is_included(p_hwfn, DBG_GRC_PARAM_DUMP_MCP_HW_DUMP) && > - !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP) && 1) > + !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP)) > offset += qed_grc_dump_mcp_hw_dump(p_hwfn, > p_ptt, > dump_buf + offset, dump); > -- > 2.25.1 >