From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E37545A11; Mon, 23 Sep 2024 17:28:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EBE34027C; Mon, 23 Sep 2024 17:28:40 +0200 (CEST) Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by mails.dpdk.org (Postfix) with ESMTP id 555BA40274 for ; Mon, 23 Sep 2024 17:28:39 +0200 (CEST) Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-457cfc2106aso37899801cf.2 for ; Mon, 23 Sep 2024 08:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727105318; x=1727710118; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=s49ZfpmvUlNztm8n1K6ijGmbuM4psswxIrqqGfoDhXY=; b=XwE9NsTP+AGg4VRvCcINWqvRXxoSjdJjBRoySb4Z68pRWT9++vpj3Ou1uics5gwGV8 snAAubq81UhqeMQNrFY65HC/cE1wO0jeGcL0GjN316xPBN5hN2hKofch2jmuM11XYacz 0oFkGwhzpB8r2lKHYYQDPz2JbvYSOh/Y+ahTvzZVS8WqdSgIOa7vVb/jEJCkV8+HlhLT 41CgpIu/3w5fMM9JyeIMPdNdPh0mR4/tsRr0cHquJTcQau7/YJZDPtFzDv0XnvYsOPx/ 8q2nvBjj7q6q1iYVOsEFz0RQe148GM+FiIqjCPNjttVEGn7Xn19FEaGSBbhNqYpcdn1/ OTCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727105319; x=1727710119; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s49ZfpmvUlNztm8n1K6ijGmbuM4psswxIrqqGfoDhXY=; b=KkIgK/S+sByKVKuAn5303mfeiWW+T7/Mg66mMZArulZva0wBT2jjZQPo9an4krNJva 4KIpNsVCr2HEY2qoJ6BbTW3xUWexx0kkVpbg9AvO2Xaf+4iOC/bBUwO04szn8owWQfxI PAIe47+q4+u6YQmSrPicOV6Zo51GFiBJmdBRdQJvF+qgclrSu0E3XuXuB636WKBbUGx6 h8So41eMaIoBPYAepxHXLHvpyNIonUYmCkG2q+XUYMmMQCi4Dq222ThSflAzutZnm65p 2w7cPdFJIbVo4e1J3fxmzyp4AMvJGETN+PO4xuUa9kelJ8NQqbd+8CvNSS0YvY60Tzwa sfsw== X-Gm-Message-State: AOJu0YxpFz979sZSiBRrOnsIvPvJ6CfZWMdo8g/vZRnzJVjPiyrHIz/h VsPwdOl/6SVoh0bhRAV/ofrwGD4e/814LhEAElAgD/O5/prwI2N9BzqnGY1gipASgvz1akgN7oU D1tZqVg2gIV02Sg5rbjvqGRt7PfE= X-Google-Smtp-Source: AGHT+IG3WHjjFxqDlgzksOEWVrg6c7sN4s/iNr7+sF0NZ/Lkp6Rt6NZD5ghkMUryP5Jx+IsdM8orH/UovH8VpJvFg/0= X-Received: by 2002:a05:622a:4d1:b0:458:4bf1:1f46 with SMTP id d75a77b69052e-45b205858efmr185581451cf.53.1727105318411; Mon, 23 Sep 2024 08:28:38 -0700 (PDT) MIME-Version: 1.0 References: <20240907193311.1342310-1-gakhil@marvell.com> <20240907193311.1342310-3-gakhil@marvell.com> In-Reply-To: <20240907193311.1342310-3-gakhil@marvell.com> From: Jerin Jacob Date: Mon, 23 Sep 2024 20:58:12 +0530 Message-ID: Subject: Re: [PATCH 2/9] drivers/raw: introduce cnxk rvu lf device driver To: Akhil Goyal Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com, hemant.agrawal@nxp.com, jerinj@marvell.com, hkalra@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Sep 8, 2024 at 1:28=E2=80=AFAM Akhil Goyal wro= te: > > CNXK product families can have a use case to allow PF and VF > applications to communicate using mailboxes and also get notified > of any interrupt that may occur on the device. > Hence, a new raw device driver is added for such RVU LF devices. > These devices can map to a PF or a VF which can send mailboxes to > each other. > > Signed-off-by: Akhil Goyal > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(C) 2024 Marvell. > +# > + > +deps +=3D ['bus_pci', 'common_cnxk', 'rawdev'] > +sources =3D files( > + 'cnxk_rvu_lf.c', > +) > +require_iova_in_mbuf =3D false > diff --git a/drivers/raw/cnxk_rvu_lf/rte_pmd_rvu_lf.h b/drivers/raw/cnxk_= rvu_lf/rte_pmd_rvu_lf.h > new file mode 100644 > index 0000000000..2d3cd032b7 > --- /dev/null > +++ b/drivers/raw/cnxk_rvu_lf/rte_pmd_rvu_lf.h > @@ -0,0 +1,39 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(C) 2024 Marvell. > + */ > + > +#ifndef _CNXK_RVU_LF_H_ > +#define _CNXK_RVU_LF_H_ > + > +#include > + > +#include > +#include > +#include > +#include > +#include Missing update to doc/api/doxy-api-index.md > + > +/** > + * @file rte_pmd_rvu_lf.h > + * > + * Marvell RVU LF raw PMD specific structures and interface > + * > + * This API allows applications to manage RVU LF device in user space al= ong with > + * installing interrupt handlers for low latency signal processing. > + */ > + > +#ifdef __cplusplus > +extern "C" { > +#endif > +extern int cnxk_logtype_rvu_lf; Public symbol. Please add Doxygen symbol > + > +#define CNXK_RVU_LF_LOG(level, fmt, args...) \ Public symbol. Please add Doxygen symbol > + rte_log(RTE_LOG_ ## level, cnxk_logtype_rvu_lf, \ > + "%s(): " fmt "\n", __func__, ## args) > + Do we need to make this public symbols?