* [PATCH] config/cn10k: align mempool elements to 128 bytes
@ 2021-12-13 11:06 pbhagavatula
2021-12-14 9:23 ` Ruifeng Wang
2021-12-14 10:30 ` Kevin Traynor
0 siblings, 2 replies; 6+ messages in thread
From: pbhagavatula @ 2021-12-13 11:06 UTC (permalink / raw)
To: jerinj, Jan Viktorin, Ruifeng Wang, Bruce Richardson; +Cc: dev, Pavan Nikhilesh
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Mempool elements are by default aligned to CACHELINE_SIZE.
In CN10K cacheline size is 64B but the RoC requires buffers to be
aligned to 128B.
Set RTE_MEMPOOL_ALIGN to 128 to force mempool buffers to be aligned
128 bytes.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
config/arm/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 213324d262..33afe1a9ad 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -276,7 +276,8 @@ soc_cn10k = {
'implementer' : '0x41',
'flags': [
['RTE_MAX_LCORE', 24],
- ['RTE_MAX_NUMA_NODES', 1]
+ ['RTE_MAX_NUMA_NODES', 1],
+ ['RTE_MEMPOOL_ALIGN', 128]
],
'part_number': '0xd49',
'extra_march_features': ['crypto'],
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] config/cn10k: align mempool elements to 128 bytes
2021-12-13 11:06 [PATCH] config/cn10k: align mempool elements to 128 bytes pbhagavatula
@ 2021-12-14 9:23 ` Ruifeng Wang
2022-01-20 9:51 ` Jerin Jacob
2021-12-14 10:30 ` Kevin Traynor
1 sibling, 1 reply; 6+ messages in thread
From: Ruifeng Wang @ 2021-12-14 9:23 UTC (permalink / raw)
To: pbhagavatula, jerinj, Jan Viktorin, Bruce Richardson; +Cc: dev, nd
> -----Original Message-----
> From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> Sent: Monday, December 13, 2021 7:06 PM
> To: jerinj@marvell.com; Jan Viktorin <viktorin@rehivetech.com>; Ruifeng
> Wang <Ruifeng.Wang@arm.com>; Bruce Richardson
> <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@marvell.com>
> Subject: [PATCH] config/cn10k: align mempool elements to 128 bytes
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Mempool elements are by default aligned to CACHELINE_SIZE.
> In CN10K cacheline size is 64B but the RoC requires buffers to be aligned to
> 128B.
> Set RTE_MEMPOOL_ALIGN to 128 to force mempool buffers to be aligned
> 128 bytes.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> config/arm/meson.build | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> 213324d262..33afe1a9ad 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -276,7 +276,8 @@ soc_cn10k = {
> 'implementer' : '0x41',
> 'flags': [
> ['RTE_MAX_LCORE', 24],
> - ['RTE_MAX_NUMA_NODES', 1]
> + ['RTE_MAX_NUMA_NODES', 1],
> + ['RTE_MEMPOOL_ALIGN', 128]
> ],
> 'part_number': '0xd49',
> 'extra_march_features': ['crypto'],
> --
> 2.17.1
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] config/cn10k: align mempool elements to 128 bytes
2021-12-13 11:06 [PATCH] config/cn10k: align mempool elements to 128 bytes pbhagavatula
2021-12-14 9:23 ` Ruifeng Wang
@ 2021-12-14 10:30 ` Kevin Traynor
1 sibling, 0 replies; 6+ messages in thread
From: Kevin Traynor @ 2021-12-14 10:30 UTC (permalink / raw)
To: pbhagavatula, jerinj, Jan Viktorin, Ruifeng Wang, Bruce Richardson; +Cc: dev
On 13/12/2021 11:06, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Mempool elements are by default aligned to CACHELINE_SIZE.
> In CN10K cacheline size is 64B but the RoC requires buffers to be
> aligned to 128B.
It would be good to say what the implication is in the commit message.
> Set RTE_MEMPOOL_ALIGN to 128 to force mempool buffers to be aligned
> 128 bytes.
>
Fixes: 1b4c86a721c9 ("config/arm: add Marvell CN10K")
This is for backport? If so please add stable@ tag
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> config/arm/meson.build | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 213324d262..33afe1a9ad 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -276,7 +276,8 @@ soc_cn10k = {
> 'implementer' : '0x41',
> 'flags': [
> ['RTE_MAX_LCORE', 24],
> - ['RTE_MAX_NUMA_NODES', 1]
> + ['RTE_MAX_NUMA_NODES', 1],
> + ['RTE_MEMPOOL_ALIGN', 128]
> ],
> 'part_number': '0xd49',
> 'extra_march_features': ['crypto'],
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] config/cn10k: align mempool elements to 128 bytes
2021-12-14 9:23 ` Ruifeng Wang
@ 2022-01-20 9:51 ` Jerin Jacob
2022-01-21 9:37 ` Jerin Jacob
0 siblings, 1 reply; 6+ messages in thread
From: Jerin Jacob @ 2022-01-20 9:51 UTC (permalink / raw)
To: Ruifeng Wang
Cc: pbhagavatula, jerinj, Jan Viktorin, Bruce Richardson, dev, nd
On Tue, Dec 14, 2021 at 2:53 PM Ruifeng Wang <Ruifeng.Wang@arm.com> wrote:
>
> > -----Original Message-----
> > From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> > Sent: Monday, December 13, 2021 7:06 PM
> > To: jerinj@marvell.com; Jan Viktorin <viktorin@rehivetech.com>; Ruifeng
> > Wang <Ruifeng.Wang@arm.com>; Bruce Richardson
> > <bruce.richardson@intel.com>
> > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@marvell.com>
> > Subject: [PATCH] config/cn10k: align mempool elements to 128 bytes
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Mempool elements are by default aligned to CACHELINE_SIZE.
> > In CN10K cacheline size is 64B but the RoC requires buffers to be aligned to
> > 128B.
> > Set RTE_MEMPOOL_ALIGN to 128 to force mempool buffers to be aligned
> > 128 bytes.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > ---
> > config/arm/meson.build | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/config/arm/meson.build b/config/arm/meson.build index
> > 213324d262..33afe1a9ad 100644
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -276,7 +276,8 @@ soc_cn10k = {
> > 'implementer' : '0x41',
> > 'flags': [
> > ['RTE_MAX_LCORE', 24],
> > - ['RTE_MAX_NUMA_NODES', 1]
> > + ['RTE_MAX_NUMA_NODES', 1],
> > + ['RTE_MEMPOOL_ALIGN', 128]
> > ],
> > 'part_number': '0xd49',
> > 'extra_march_features': ['crypto'],
> > --
> > 2.17.1
>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
Added
Fixes: 1b4c86a721c9 ("config/arm: add Marvell CN10K")
Cc: stable@dpdk.org
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] config/cn10k: align mempool elements to 128 bytes
2022-01-20 9:51 ` Jerin Jacob
@ 2022-01-21 9:37 ` Jerin Jacob
2022-02-12 14:14 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Jerin Jacob @ 2022-01-21 9:37 UTC (permalink / raw)
To: Ruifeng Wang, Ferruh Yigit, Thomas Monjalon
Cc: pbhagavatula, jerinj, Jan Viktorin, Bruce Richardson, dev, nd
On Thu, Jan 20, 2022 at 3:21 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> On Tue, Dec 14, 2021 at 2:53 PM Ruifeng Wang <Ruifeng.Wang@arm.com> wrote:
> >
> > > -----Original Message-----
> > > From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> > > Sent: Monday, December 13, 2021 7:06 PM
> > > To: jerinj@marvell.com; Jan Viktorin <viktorin@rehivetech.com>; Ruifeng
> > > Wang <Ruifeng.Wang@arm.com>; Bruce Richardson
> > > <bruce.richardson@intel.com>
> > > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@marvell.com>
> > > Subject: [PATCH] config/cn10k: align mempool elements to 128 bytes
> > >
> > > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > >
> > > Mempool elements are by default aligned to CACHELINE_SIZE.
> > > In CN10K cacheline size is 64B but the RoC requires buffers to be aligned to
> > > 128B.
> > > Set RTE_MEMPOOL_ALIGN to 128 to force mempool buffers to be aligned
> > > 128 bytes.
> > >
> > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > > ---
> > > config/arm/meson.build | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/config/arm/meson.build b/config/arm/meson.build index
> > > 213324d262..33afe1a9ad 100644
> > > --- a/config/arm/meson.build
> > > +++ b/config/arm/meson.build
> > > @@ -276,7 +276,8 @@ soc_cn10k = {
> > > 'implementer' : '0x41',
> > > 'flags': [
> > > ['RTE_MAX_LCORE', 24],
> > > - ['RTE_MAX_NUMA_NODES', 1]
> > > + ['RTE_MAX_NUMA_NODES', 1],
> > > + ['RTE_MEMPOOL_ALIGN', 128]
> > > ],
> > > 'part_number': '0xd49',
> > > 'extra_march_features': ['crypto'],
> > > --
> > > 2.17.1
> >
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
>
> Applied to dpdk-next-net-mrvl/for-next-net. Thanks
As per @Ferruh Yigit suggestion, This patch will be taken through the
main tree.
I changed state as New and Delegate as @Thomas Monjalon for this patch in pw.
>
>
> Added
> Fixes: 1b4c86a721c9 ("config/arm: add Marvell CN10K")
> Cc: stable@dpdk.org
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] config/cn10k: align mempool elements to 128 bytes
2022-01-21 9:37 ` Jerin Jacob
@ 2022-02-12 14:14 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2022-02-12 14:14 UTC (permalink / raw)
To: Ruifeng Wang, Ferruh Yigit, pbhagavatula, jerinj
Cc: dev, Jan Viktorin, Bruce Richardson, dev, nd, Jerin Jacob
21/01/2022 10:37, Jerin Jacob:
> On Thu, Jan 20, 2022 at 3:21 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> >
> > On Tue, Dec 14, 2021 at 2:53 PM Ruifeng Wang <Ruifeng.Wang@arm.com> wrote:
> > >
> > > > -----Original Message-----
> > > > From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> > > > Sent: Monday, December 13, 2021 7:06 PM
> > > > To: jerinj@marvell.com; Jan Viktorin <viktorin@rehivetech.com>; Ruifeng
> > > > Wang <Ruifeng.Wang@arm.com>; Bruce Richardson
> > > > <bruce.richardson@intel.com>
> > > > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@marvell.com>
> > > > Subject: [PATCH] config/cn10k: align mempool elements to 128 bytes
> > > >
> > > > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > > >
> > > > Mempool elements are by default aligned to CACHELINE_SIZE.
> > > > In CN10K cacheline size is 64B but the RoC requires buffers to be aligned to
> > > > 128B.
> > > > Set RTE_MEMPOOL_ALIGN to 128 to force mempool buffers to be aligned
> > > > 128 bytes.
> > > >
> > > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > > > ---
> > > > config/arm/meson.build | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/config/arm/meson.build b/config/arm/meson.build index
> > > > 213324d262..33afe1a9ad 100644
> > > > --- a/config/arm/meson.build
> > > > +++ b/config/arm/meson.build
> > > > @@ -276,7 +276,8 @@ soc_cn10k = {
> > > > 'implementer' : '0x41',
> > > > 'flags': [
> > > > ['RTE_MAX_LCORE', 24],
> > > > - ['RTE_MAX_NUMA_NODES', 1]
> > > > + ['RTE_MAX_NUMA_NODES', 1],
> > > > + ['RTE_MEMPOOL_ALIGN', 128]
> > > > ],
> > > > 'part_number': '0xd49',
> > > > 'extra_march_features': ['crypto'],
> > > > --
> > > > 2.17.1
> > >
> > > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> >
> > Applied to dpdk-next-net-mrvl/for-next-net. Thanks
>
> As per @Ferruh Yigit suggestion, This patch will be taken through the
> main tree.
> I changed state as New and Delegate as @Thomas Monjalon for this patch in pw.
>
> >
> >
> > Added
> > Fixes: 1b4c86a721c9 ("config/arm: add Marvell CN10K")
> > Cc: stable@dpdk.org
Applied
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-12 14:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-13 11:06 [PATCH] config/cn10k: align mempool elements to 128 bytes pbhagavatula
2021-12-14 9:23 ` Ruifeng Wang
2022-01-20 9:51 ` Jerin Jacob
2022-01-21 9:37 ` Jerin Jacob
2022-02-12 14:14 ` Thomas Monjalon
2021-12-14 10:30 ` Kevin Traynor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).