From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A323A0C4D; Tue, 2 Nov 2021 05:33:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C83B24069F; Tue, 2 Nov 2021 05:33:26 +0100 (CET) Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by mails.dpdk.org (Postfix) with ESMTP id 268FA4068F for ; Tue, 2 Nov 2021 05:33:25 +0100 (CET) Received: by mail-il1-f175.google.com with SMTP id k1so5343770ilo.7 for ; Mon, 01 Nov 2021 21:33:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5Qmh7AyBADMvDYf1XWwuRgRhyK+tyJMDvmTaecR5qs0=; b=hhLpdSK+4jk2l9bJPYGJRwNZk91QDxYR7m6pUOKst//GHEgm604BqM/0xkOkXf9pQO oG9kOwm0vmpwuGBE+beC2VUxvTscxGicfgoxiNvdeAnUooVcpjp6clC6JHBltIdLHDZl SisJAwHtknHay2vAYuoYQVgOB4p1mGL8ps/RU2ILpYDWu087OdEzeZ3jVzxMCrmFL53J dyDddsbSR63VdBA1VikAXZhSp4GEpIE0DFe+6zsjjC3dsGg+eddtQpP5QjAymCQiKC/l ugA9M5lLRbuCc3UKRoNMBTbKKM5lQX789WG3XgdlE/OyAeJqk8c7T/TKAo9dNyqamxfa QtLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5Qmh7AyBADMvDYf1XWwuRgRhyK+tyJMDvmTaecR5qs0=; b=4L5JdvL8UqRM3XJ9lJCakO2v+SyS9QJDxHLFO4v0YNyPtJaC++kKjLUTExX8y1arq6 jlfo6+HLEgEzuv+JK0ncHtn2ZpNcNQhab+Psjyne/1+7N8gA2SIMgHQx7Jls6pmiqLYe igu+5HGnOyf65nuxYP+PHXkYuQulXC8VRIsSe6zj85mCOGtMyVU29K0b8EE28bNuvQ3N uc8WYAyzI4FsbyzfFNzGLMQk2hGzIh0t6wEOKKqqGVkIhND+73Gb7sGFkOFrG0D37gBu XfVyRBfwDt2Pt5GQjpz7oojHRaGwGcC0R844gZNHQW2zzHIZ3MjDSgiCwMaa7qgX5K2j vUkA== X-Gm-Message-State: AOAM530fCkGmKmXIbVPrDKUm/MEOIicBGGv3L4j/fcjeMYVwUF8CFlof F7w6GDwPceIrld+PjgkRezf9KxE7PxLIuDoW+7g= X-Google-Smtp-Source: ABdhPJzXZP98W8+Q8vx9RE9DWzRq6qcmpqoFry3rQR1x1fT+rVlDzyynpUmaS0+ralX88x+Elil0LFxJK+68W3a1Msc= X-Received: by 2002:a05:6e02:174d:: with SMTP id y13mr23387275ill.251.1635827604491; Mon, 01 Nov 2021 21:33:24 -0700 (PDT) MIME-Version: 1.0 References: <20211005074620.2224968-1-tduszynski@marvell.com> <20211022115625.1956708-1-tduszynski@marvell.com> <4832f0a8-67a4-ec48-30b6-01aa7d80ab1a@intel.com> In-Reply-To: <4832f0a8-67a4-ec48-30b6-01aa7d80ab1a@intel.com> From: Jerin Jacob Date: Tue, 2 Nov 2021 10:02:58 +0530 Message-ID: To: Ferruh Yigit Cc: Tomasz Duszynski , dpdk-dev , Jerin Jacob , Harman Kalra , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Jakub Palider Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] common/cnxk: support BPHY telemetry X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 1, 2021 at 8:32 PM Ferruh Yigit wrote: > > On 10/22/2021 12:56 PM, Tomasz Duszynski wrote: > > Add initial support for baseband telemetry. > > > > Signed-off-by: Tomasz Duszynski > > --- > > v2: > > - make bphy telemetry available only on platforms supporting baseband > > - use platform types where possible > > - remove unused header > > > > drivers/common/cnxk/cnxk_telemetry_bphy.c | 52 +++++++++++++++++++++++ > > Since the telemetry support is for 'raw/cnxk_bphy', why it is implemented > in common code, instead of driver? It can be raw/cnxk_bphy, thought of keeping it in common due to 1) To reuse it for another common code consumer 2) roc_bphy_sso_pf_func_get() and roc_bphy_npa_pf_func_get() manged by common code. aka there is no reverse dependency on the raw driver framework in common code. > > > drivers/common/cnxk/meson.build | 3 +- > > drivers/common/cnxk/roc_model.h | 5 +++ > > drivers/raw/cnxk_bphy/cnxk_bphy.c | 11 +++++ > > drivers/raw/cnxk_bphy/cnxk_bphy_irq.h | 1 + > > 5 files changed, 71 insertions(+), 1 deletion(-) > > create mode 100644 drivers/common/cnxk/cnxk_telemetry_bphy.c >