From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F856A0524; Sat, 20 Mar 2021 14:15:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67D641410B7; Sat, 20 Mar 2021 14:15:11 +0100 (CET) Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by mails.dpdk.org (Postfix) with ESMTP id 747511410B6; Sat, 20 Mar 2021 14:15:10 +0100 (CET) Received: by mail-io1-f44.google.com with SMTP id e8so9065332iok.5; Sat, 20 Mar 2021 06:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2KOeBWZFesV3Fdsc7ZaoiTWdKD7SQuGwsU+9zdB+zQ0=; b=M61XD5/fYf3/69P8uTk3xndhX8oK7CTCzo2HErJ1uAhWwrFEVVo20wihvpTi5m4BdM GMiQt+SWEifwDSe8driAz86DrQxhGHbxuFDNod0PNdNmM0klDU2eCOiN/lHUUJG0oQDo YiSVZ/dxipdUfIhwCbuF0dt6UnzCxDyo1MMyxgxrj/Bz+io1oG6OZZFEpy8IENNi6fUH PySbGd4WfcyFvBEQQuvee68ggUZtKLQ97TzWYffGM6CFyK1D1fetu67f2Pe34vszYx3D XLHhwjXi0oGXXgchjvFoBvgJRyGG+gzr9L7+7fOTXZSSsSYdQAc4uGnPgeeKPclz1Gdi S3Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2KOeBWZFesV3Fdsc7ZaoiTWdKD7SQuGwsU+9zdB+zQ0=; b=VoFWcgHfHca5vop4hSpPSHfeAdgjmeeiTz0G/Zazr3LWurmUUmWPpkI7UR9TpKtHaP LC/SaK6GNhDGEIEhfXjCHWr23s5b9qIS49pEHhEHC9LiTSDN4iHpoxs34iSXo4kEd9B+ rO6JESIInM2ifb0bp/QuvvBOtya6w3XGjYuJXdter5lKx9IVpIlbeHHqArGQYCiC4GCP KHM8MtmeDrCyvPk99L6fJ5od9SUPL/rj1QFdW079aztNUf+IhhHd0MvExaY8aQ6wECI1 uWbB799/aMAsf3jN4T4jg/0DxfkVzsdPU3lvPB3G5KdDQJoDZ/NUp5DEqKlfHzat7p16 fQBg== X-Gm-Message-State: AOAM531oc7bvShaoLS6dasp10/11O0vPtejhKLQIiqDv+mdCM1Nj3e3W 6OC53oNxXFwF4tY/giqq2B6XjnBIsMHLRy2rqvE= X-Google-Smtp-Source: ABdhPJy/E+58eEIEN3SdAB7xDvEgA2WvINPgxu8u7Fl4ct0Y68AB84f4Er0H51nhMYwo9Z6UqKpxlQtK8NXqMr/osDw= X-Received: by 2002:a02:7086:: with SMTP id f128mr4969409jac.104.1616246109789; Sat, 20 Mar 2021 06:15:09 -0700 (PDT) MIME-Version: 1.0 References: <20210319094656.5576-1-irusskikh@marvell.com> <20210319094656.5576-3-irusskikh@marvell.com> In-Reply-To: <20210319094656.5576-3-irusskikh@marvell.com> From: Jerin Jacob Date: Sat, 20 Mar 2021 18:44:53 +0530 Message-ID: To: Igor Russkikh Cc: dpdk-dev , Rasesh Mody , Devendra Singh Rawat , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 2/2] qede: make driver accept bigger rss tables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 19, 2021 at 3:17 PM Igor Russkikh wrote: > > We found some dpdk applications blindly pass fixed side rss hash tables, Could you rewrite the git commit by removing "We". > and do not check driver/device capabilities. > > Moreover, many other drivers do not do such a strong check as well. > > So here we fix it, making qede accept any size rss_key. For larger key Could you rewrite the git commit by removing "we". > tables we just crop it with notice trace message. > > CC: stable@dpdk.org > Signed-off-by: Igor Russkikh Waiting for Ack to merge this. > --- > drivers/net/qede/qede_ethdev.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c > index ab5f5b106..bfd38a977 100644 > --- a/drivers/net/qede/qede_ethdev.c > +++ b/drivers/net/qede/qede_ethdev.c > @@ -2139,8 +2139,10 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev, > /* RSS hash key */ > if (key) { > if (len > (ECORE_RSS_KEY_SIZE * sizeof(uint32_t))) { > - DP_ERR(edev, "RSS key length exceeds limit\n"); > - return -EINVAL; > + len = ECORE_RSS_KEY_SIZE * sizeof(uint32_t); > + DP_NOTICE(edev, false, > + "RSS key length too big, trimmed to %d\n", > + len); > } > DP_INFO(edev, "Applying user supplied hash key\n"); > rss_params.update_rss_key = 1; > -- > 2.25.1 >