From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54A4BA0C47; Tue, 12 Oct 2021 10:48:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B77B40151; Tue, 12 Oct 2021 10:48:27 +0200 (CEST) Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by mails.dpdk.org (Postfix) with ESMTP id 166804003C for ; Tue, 12 Oct 2021 10:48:25 +0200 (CEST) Received: by mail-il1-f169.google.com with SMTP id i11so19868982ila.12 for ; Tue, 12 Oct 2021 01:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7fy2P4C/SfJVu852L2Nkt8AhhX4FDPQOO0LKypP2XKU=; b=oo2dF/rPUyxkk222iL3XML/blTtGYK+RRGFlRVWu/0DdNgycRAnr5d4NXn/Mr7L0mb RZQJqa41AGRUSxxZ0iRFof7fR7/YWyEYB6K4FqJNIvH/RtItyZR3Okk8bHBs0RqScSuJ rdn1XS/tKPgcFiFNESwe6KT/iR50oigGZTf/LMmV+RWVaMCzxQ8o7Pa0Fcqumqg5bMWl Hj9+2CBJGR439UiRD/nr0H5Oz2eIvRKhkMTp2HUQhSYhaUTn1X5XQNngJkGcudhPH4X7 0Pq9B8Fvs4tpBDRipIRAzesXQ5maPDWfFd5tBDRywFDfMjhQbYPLBN8KJXL0yGCWKWWR npwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7fy2P4C/SfJVu852L2Nkt8AhhX4FDPQOO0LKypP2XKU=; b=eI/sUz9opbtxDBFQ4Nzb8yNlkXasDEhLoNpeJzl8rLfUGK3KWDikNheL0Svh9Pjx6/ YTzc5NfnaUzhcwAnb/MuDgv7F1Nf66habk+XT3dbj6t2i0jWSP/ufuiANFBZdlgxBKHZ JkG3l2zgsP4W0fgtS7L56XLnRzD6seR8ttcLaDHb/ALy7PXJJthbVT8dEajVHmGfVP6B jYYQkTVdIQWP7IvMYPggg8Dp7KL5Ix+6Ry8RpjIYlhzUxBI9VB24irDxzWYt8g9VeMY9 kNQCDv5RLHG8sGVO7oO52yOp6bBZWlaZEpfAkllKcg1LYTOx1MON5ynGLNwdQqw2WMfp yACw== X-Gm-Message-State: AOAM533gryTQtO63I3d4YU71jS4YnLa5xrc9uBRbvtiJN1U8tA1VAS7l 00KrfAZaT0wPSK3qyTmSDYQe/eXPQiTqzDH8YcA= X-Google-Smtp-Source: ABdhPJxuXR0UrTgLDKV7OPuERDTumChQ1tMnyysJcTaQQq1uUN3kPie4wsq6QEuf9os+1EmSCKu6yRn5y8iS7RlxQbE= X-Received: by 2002:a05:6e02:190a:: with SMTP id w10mr757716ilu.243.1634028504475; Tue, 12 Oct 2021 01:48:24 -0700 (PDT) MIME-Version: 1.0 References: <20211007125734.2326512-1-ganapati.kundapura@intel.com> In-Reply-To: From: Jerin Jacob Date: Tue, 12 Oct 2021 14:17:58 +0530 Message-ID: To: "Kundapura, Ganapati" , Ray Kinsella , Thomas Monjalon , David Marchand Cc: dpdk-dev , "Jayatheerthan, Jay" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] eventdev/rx-adapter: add telemetry callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 12, 2021 at 2:05 PM Kundapura, Ganapati wrote: > > Hi Jerin, > > > -----Original Message----- > > From: Jerin Jacob > > Sent: 11 October 2021 21:44 > > To: Kundapura, Ganapati > > Cc: dpdk-dev ; Jayatheerthan, Jay > > > +que_id"); } > > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h > > > b/lib/eventdev/rte_event_eth_rx_adapter.h > > > index 70ca427..acabed4 100644 > > > --- a/lib/eventdev/rte_event_eth_rx_adapter.h > > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.h > > > @@ -216,6 +216,10 @@ struct rte_event_eth_rx_adapter_stats { > > > /**< Eventdev enqueue count */ > > > uint64_t rx_enq_retry; > > > /**< Eventdev enqueue retry count */ > > > + uint64_t rx_event_buf_count; > > > + /**< Rx event buffered count */ > > > + uint64_t rx_event_buf_size; > > > > > > Isn't ABI breakage? CI did not warn this. Isn't this a public structure? > Please confirm if moving the above two members to end of the structure overcomes ABI breakage? + @Ray Kinsella @Thomas Monjalon @David Marchand It will still break the ABI. IMO, Since it is an ABI breaking release it is OK. If there are no other objections, Please move the variable to end of the structure and update release notes for ABI changes. > > > > > > > > > + /**< Rx event buffer size */ > > > uint64_t rx_dropped; > > > /**< Received packet dropped count */ > > > uint64_t rx_enq_start_ts; > > > -- > > > 2.6.4 > > >