From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6BC5CA0547;
	Thu, 21 Oct 2021 10:43:31 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DE6DC411C2;
	Thu, 21 Oct 2021 10:43:30 +0200 (CEST)
Received: from mail-io1-f52.google.com (mail-io1-f52.google.com
 [209.85.166.52]) by mails.dpdk.org (Postfix) with ESMTP id 9743040142
 for <dev@dpdk.org>; Thu, 21 Oct 2021 10:43:29 +0200 (CEST)
Received: by mail-io1-f52.google.com with SMTP id 188so27948479iou.12
 for <dev@dpdk.org>; Thu, 21 Oct 2021 01:43:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=mBOJPAPgoLs+HBrO/5DPRIgqHya1ZteuDlaVPSJzjVg=;
 b=JJqPSpss8lL+GbTtwyqJq+TuzvHUdrNissgoNglENWDQSmeF6EkRIxOh/fuzR4ss/f
 WZk4SV1kiOGk9XyiqxQkjOCzs2KrNgfHHOPhvCa2Dz3Zs6SPcrmvVjYcyVcLjpZf7Su1
 92Ad3wB/IXUddXbijkcFt4ftnYSvQy6bvfxNfRTbXIBQO2w0hpSjEIxx0F20SOgl402H
 DbMYU2JvIzWI6R+RIdMshl68pgMgy0S9fU3lSy/ZD3ewoA9QnPfsAksPamA0m8xS/VX5
 k0JH6a8y1YxwMsIrUWwpKHtoqKAUc+IiBovnY8i5zHUKVimf8AFFDa3DRxpIrbLhfczT
 BoHA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=mBOJPAPgoLs+HBrO/5DPRIgqHya1ZteuDlaVPSJzjVg=;
 b=4FtMVYa39F4L7SUXB/kdgdJoVBIrwOruOhzEVF/2qLIEySOpqB61qBpGqSb4BOEByr
 L8q7ExLFcId1a4z0u6WBbgMnSBHBZ1K0YxYa2UMl3H6gMM9twhhJ3lIVkXPNjPo63VOZ
 H4iNqpDpWT0vDLfQ+QeL+w3yM8Mog1wHBYMYk5yKuMQO2zyUkxM631dfPruKYkofPGlM
 byt0MNxtkiicDMzZF/WPD8MKvG+YtVzkieAYvN+zy7Yep+G22+Dq8FY6tFO7Pzztp3ns
 kmoL/pwVI2MUCFMduGCAVNGHyqE/r0V2n/fTPYooPiLWGNOD44PheFRoasGL8qEgi72L
 qAsQ==
X-Gm-Message-State: AOAM532yn4OB2fjoiZwmp1eGy9izK8hpu7Gq0Ey9WXpmOeCxoEt8VUIR
 tuBUl1Vdj4UzxcyPA+2PfaUu1VBXOmS/WDwb6J0=
X-Google-Smtp-Source: ABdhPJxMu+qsTVpZKhgr8HwaRgAODmp/aAY15hukKIzXyZG/pg4djGFWdWMAv3cyEesWs32J0wzpHVTqIDMqQ14jWJg=
X-Received: by 2002:a02:a14d:: with SMTP id m13mr3065536jah.126.1634805808892; 
 Thu, 21 Oct 2021 01:43:28 -0700 (PDT)
MIME-Version: 1.0
References: <20211020202021.1205135-1-erik.g.carrillo@intel.com>
 <PH0PR18MB40860E3F35F2E930CD353FFDDEBF9@PH0PR18MB4086.namprd18.prod.outlook.com>
In-Reply-To: <PH0PR18MB40860E3F35F2E930CD353FFDDEBF9@PH0PR18MB4086.namprd18.prod.outlook.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Thu, 21 Oct 2021 14:13:02 +0530
Message-ID: <CALBAE1MEHp9Qh=V-7CphP9dc5nS5Z_UNG5Gsmg4d=bqdXDBCTg@mail.gmail.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Cc: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>, 
 Jerin Jacob Kollanukkaran <jerinj@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [EXT] [PATCH] eventdev: fix free of adapters storage
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Oct 21, 2021 at 1:05 PM Pavan Nikhilesh Bhagavatula
<pbhagavatula@marvell.com> wrote:
>
>
>
> >-----Original Message-----
> >From: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> >Sent: Thursday, October 21, 2021 1:50 AM
> >To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Pavan Nikhilesh
> >Bhagavatula <pbhagavatula@marvell.com>
> >Cc: dev@dpdk.org
> >Subject: [EXT] [PATCH] eventdev: fix free of adapters storage
> >
> >External Email
> >
> >----------------------------------------------------------------------
> >Fix a typo that can cause the hugepage memory that backs the adapters
> >array to be freed unexpectedly.
> >
> >Fixes: e9caa6a09a "eventdev: move timer adapters memory to
> >hugepage")
> >
> >Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
>
> LGTM, Jerin please squash as the series is not in main branch yet.

Thanks Eric. Squashed the patch in the series in next-event


>
> Thanks.
>
> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> >---
> > lib/eventdev/rte_event_timer_adapter.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/lib/eventdev/rte_event_timer_adapter.c
> >b/lib/eventdev/rte_event_timer_adapter.c
> >index 86b6c3fc6f..0e21b7c475 100644
> >--- a/lib/eventdev/rte_event_timer_adapter.c
> >+++ b/lib/eventdev/rte_event_timer_adapter.c
> >@@ -407,7 +407,7 @@ rte_event_timer_adapter_free(struct
> >rte_event_timer_adapter *adapter)
> >       ret = 0;
> >       for (i = 0; i < RTE_EVENT_TIMER_ADAPTER_NUM_MAX; i++)
> >               if (adapters[i].allocated)
> >-                      ret = adapter[i].allocated;
> >+                      ret = adapters[i].allocated;
> >
> >       if (!ret) {
> >               rte_free(adapters);
> >--
> >2.23.0
>