From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D9C043861; Mon, 8 Jan 2024 08:54:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E6EEB402B0; Mon, 8 Jan 2024 08:54:15 +0100 (CET) Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by mails.dpdk.org (Postfix) with ESMTP id 38A8840263; Mon, 8 Jan 2024 08:54:14 +0100 (CET) Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-42786ec994bso16021481cf.1; Sun, 07 Jan 2024 23:54:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704700453; x=1705305253; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=diamXurcxwE6MmItczlNfuqLmpCrgMtsm8syiarNxrI=; b=XHY/w2MKlYNv4KrMdqdGgeg04of6xvP7LiXVT6RybF0IbX4QhWjrK4U3AKC1mPJWWD 55nacbzNuFcjLDp5+ZK/fLLkNculZ38h3HvkuRKdX1G0M+N+zSNv3TCXUsyaOG67M3Ol ebVxdbJyym9+E0DKFcfA508nhYskXP0s8xKyMuMNXCYNBnZoP0k2Z4sy1QEWjXQOCCiq 0/FFKnNvz+/bfNHAIVsaG+IS2qlDQjgQXxTlO37iaxyxC78D65CdcgyuyFQRRqeh9abb pLz4zMSqtBtBv/T7kxXutJsjbKyq8rNa1H0jg16/O+8jOVdzXD1ii0rejeRrE5KAywjU Xg8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704700453; x=1705305253; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=diamXurcxwE6MmItczlNfuqLmpCrgMtsm8syiarNxrI=; b=m1Pslf9G0RB9ITFqZP8nD3FL+mlPDCYXAssLFpF20mumoBehx7qCdnuoNdA93vA2R7 xRRvusVpPZBt5V3QUZ+t2tGmJOpw/4WKKeWWrGsamU2kNPXs+Bkbg5PhdQ7YU8LUmjZi ve2MyiqBWiKj6aBG94q+3yKENpnkHI+wqv3qltwbAxPdycuZM9JX5AZasAzAOVXFkXzP x+X+KCCmYP4Vxxo4AWFqxguTvRqKyKbNEgF/i6rxpCZfqzz0J5eI5JR79ksXlz5iVL33 vczmiyzYWkkmSOfmmoRE1XX3N6VD1C8WZVln3/YBJJJQFl4RSOSrqAAh6a9SQYXVXs+I NJ+w== X-Gm-Message-State: AOJu0YyBNL1tb3TiEmpTv57stNQfXaZLzK2aayfIjl/5N77TeNAK+ag4 gF7uPSXIh6E8vHz6ElOX/K2nuijKgFArKjrjIG8= X-Google-Smtp-Source: AGHT+IFITc2OCk9S5RPE4Zm030FTdQ0Q7q+PmCf7/kufkPWXRPi9fiLZ+wBdzfpmT8LDLw8w9f/C3GsNUrgQvV4AEzk= X-Received: by 2002:ac8:5b8e:0:b0:429:99b9:d428 with SMTP id a14-20020ac85b8e000000b0042999b9d428mr546853qta.91.1704700453317; Sun, 07 Jan 2024 23:54:13 -0800 (PST) MIME-Version: 1.0 References: <20230928054036.645183-1-jerinj@marvell.com> <20240105121215.3950532-1-jerinj@marvell.com> <20240105092725.4f21045e@hermes.local> In-Reply-To: <20240105092725.4f21045e@hermes.local> From: Jerin Jacob Date: Mon, 8 Jan 2024 13:23:46 +0530 Message-ID: Subject: Re: [dpdk-dev] [v3] doc: define qualification criteria for external library To: Stephen Hemminger Cc: jerinj@marvell.com, dev@dpdk.org, techboard@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Jan 6, 2024 at 12:14=E2=80=AFAM Stephen Hemminger wrote: > > On Fri, 5 Jan 2024 17:42:15 +0530 > wrote: > > > > I would a clause about optional dependency. > Something like: > > If external dependency is not available, then it must be detectab= le by the > build process. Missing external library must not impact the core = functionality > of the DPDK; only the library or driver in DPDK will not be built= . OK. I will send the next verison with following update [main][dpdk.org] $ git diff diff --git a/doc/guides/contributing/library_dependency.rst b/doc/guides/contributing/library_dependency.rst index 367e380a89..7b008d7e8a 100644 --- a/doc/guides/contributing/library_dependency.rst +++ b/doc/guides/contributing/library_dependency.rst @@ -44,3 +44,9 @@ used as dependencies in DPDK drivers or libraries. - Optional dependencies should use stubs to minimize ``ifdef`` clutter, promoting improved code readability. + +#. **Dependency nature:** + + - The external library dependency should be optional. + i.e Missing external library must not impact the core functionality of the DPDK, specififc + library and/or driver will not built if dependencies are not meet.