From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DA69A04B4; Fri, 8 Nov 2019 18:29:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 633021D155; Fri, 8 Nov 2019 18:29:09 +0100 (CET) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id 9B6861C2E9 for ; Fri, 8 Nov 2019 18:29:08 +0100 (CET) Received: by mail-il1-f194.google.com with SMTP id n18so5796552ilt.9 for ; Fri, 08 Nov 2019 09:29:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IMEqEf6YJKPXNBFMBZA30KoZSHtAMLLJkC3hSAsVTbI=; b=XO8xDD7mCOx+yfBcJsMr7FnQWamnAISWF55Aztv1YWBWvF+Y4aqN7awZHn++npjPaX RRbJ51dpjkoxNbbDroHfvMGd1hC8FsjzCFe7ldCSzBxxUrgb8HnAZBHiVzISxpj9NpZQ oIu9mD3iAtarUlw9e1DOTUxj2qYyB+kWJHWQAuVKKDy3e+lsc9CNC8ip7o04P8Yl9He5 6hZu0Qd2gEgdOJYTP2Ycxac/Kg4Q/n93YnirR/3haCKXLbGqgqRVqkNAyLn/YPU4tfjW hpN6sqUEfcjgfb7Woazd8doNSF93k/wwrK0+2TSt3YEdTdCBydbBZ8wZ1q9PNmF4pUwS hIFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IMEqEf6YJKPXNBFMBZA30KoZSHtAMLLJkC3hSAsVTbI=; b=hSbmEpO22qtxy+SJnLuk87bYr+eMDYIXXPOX2UKEdek6zQ3tkI7C2JGkwmRtcZ0bNX uH65l23cFPEs0c0eCpOqKfB8SKm9km1hZslf5fjyhyKQZw90jWDho51TJ83rziRMYyaT SH4r3YQLQimu0zVWqDZRyjnKKfFlZH9Zb4pTxJYicLp9+BBo272Aj94RBYLK71Jq0DMk usLQ/O8rYAYZNDJa9hXBN3jiuY2idbrDdvkPNCLvQyJ21t3gtbYJf18h50cmSUbX19Xo 8nb1I8vkda8Onew1eGw7D8Lu/g8ogRrfTEdmqNfpniiwPrV78JnOt4Skq5G1Cc/uCy5C ifzA== X-Gm-Message-State: APjAAAVbn8eXkBerSJxqCZnK70wHF39a6teH9aawo4W83LNAhFBzmLeU Ps2s1pJSQTxX/45YgaLsM7kD4gk/YHtGCn6n+eKGgnidtLFQng== X-Google-Smtp-Source: APXvYqxSIWXo1YtBqXGwtDW7b//fN/e8VL0BhV/4A1tlqC62qLHv5Z7tPpVqvr8NXvssiP7ktEHIXML49LOusQVNj5I= X-Received: by 2002:a92:5e49:: with SMTP id s70mr14663472ilb.130.1573234147697; Fri, 08 Nov 2019 09:29:07 -0800 (PST) MIME-Version: 1.0 References: <20191106112649.24484-1-skori@marvell.com> In-Reply-To: <20191106112649.24484-1-skori@marvell.com> From: Jerin Jacob Date: Fri, 8 Nov 2019 22:58:51 +0530 Message-ID: To: Sunil Kumar Kori Cc: Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , John McNamara , Marko Kovacevic , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 1/1] net/octeontx2: add Rx/Tx burst mode get callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 6, 2019 at 4:57 PM Sunil Kumar Kori wrote: > > Retrieve burst mode information according to the selected Rx/Tx mode and > offloads. > > Signed-off-by: Sunil Kumar Kori > --- > v3: > - Rebased the patch over patches.dpdk.org/patch/62368/ > v2: > - Rebased the patch on latest commit. > - Update feature matrix for the support. > > doc/guides/nics/features/octeontx2.ini | 1 + > drivers/net/octeontx2/otx2_ethdev.c | 2 + > drivers/net/octeontx2/otx2_ethdev.h | 4 ++ > drivers/net/octeontx2/otx2_ethdev_ops.c | 87 +++++++++++++++++++++++++ > 4 files changed, 94 insertions(+) > > > +int > +otx2_rx_burst_mode_get(struct rte_eth_dev *eth_dev, > + __rte_unused uint16_t queue_id, > + struct rte_eth_burst_mode *mode) > +{ > +#define STRING_SIZE 1024 Use RTE_ETH_BURST_MODE_INFO_SIZE instead of hardcoded 1024 > + struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev); > + char info[STRING_SIZE] = {'\0'}; No need for intermediate "info", use rte_eth_burst_mode::info > + ssize_t bytes = 0; > + > + if (dev->scalar_ena) > + bytes += rte_strscpy(info, "Scalar", 7); Please avoid hardcoding of '7'. ssize_t sz = 0, rc; rc = rte_strscpy(mode->info + sz, "Scalar", STRING_SIZE - sz); if (rc < 0) goto done; sz += rc; rc = rte_strscpy(mode->info + sz, "Vector Neon", STRING_SIZE - sz); if (rc < 0) goto done; sz += rc; > + else > + bytes += rte_strscpy(info, "Vector Neon", 12); > + > + bytes += rte_strscpy(info + bytes, ", Rx Offloads:", 15); > + > + if (dev->rx_offload_flags & NIX_RX_OFFLOAD_RSS_F) > + bytes += rte_strscpy(info + bytes, " RSS,", 6); > + > + if (dev->rx_offload_flags & NIX_RX_OFFLOAD_PTYPE_F) > + bytes += rte_strscpy(info + bytes, " Ptype,", 8);