From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 194FEA034F; Sun, 28 Mar 2021 11:11:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9343540042; Sun, 28 Mar 2021 11:11:48 +0200 (CEST) Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) by mails.dpdk.org (Postfix) with ESMTP id 16E6440040 for ; Sun, 28 Mar 2021 11:11:48 +0200 (CEST) Received: by mail-il1-f180.google.com with SMTP id h7so1627616ilj.8 for ; Sun, 28 Mar 2021 02:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aVBhlkY/jbIw7L7uGpEdOcYXa42nuHQO5qQwhp8yfNE=; b=r9KCA236DFuQQgiteuDUA2+dK5P5uHXrgULKdNgIga0cc0VjWGS3Mj3x45s8HYdMIa Uo99WV9egLhuYkelnzp7s56kgZ4sKvPxz2QlbNRLyeNO3PBSovRYMnVBIwauw15URE6W ygy5b4JfdbkDAQj/jpbdfWrQg8p/jHvAH4qMCLxeqsZAb7HDZeqUX0bSjNgVl64Eevf0 RKg+yBxwpWs0KUew5IxpzpOQ4ZMuFzRE9l/Q266QUudO8O12Bk0LlTf5pHGjMzOllf9/ uKIrXzRrGmMvtAMNX29HBYdP82S/mMO7Df4Z4FmMyNvyDOv8jZND1LmRle5g1TPBDB9P mrJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aVBhlkY/jbIw7L7uGpEdOcYXa42nuHQO5qQwhp8yfNE=; b=tnq+Q48FhC5ST4D5uMGJ3hvC9dV035Zc4jeGJtU1bxnU+pCe9DyJv8D0owrzN/OPiy sQpwtta3uapmww9rdSGW0gmqg7bWFwk3jDU/kIMHAPvKMluHijroiXRnl+3zYhxw9svt /XC/KAjMbzD7VbRljbYSr2HYyteWsHJmNheebyYXFaV0CpXOhHkOw5ioymdeTReDJxT7 UJuD/F3yGLMH/wza/tFydSZDIDTXmfxGlHtwoj1S6CjPGS/PsdACu805F1PRcOFds+Xp J6S7yPtlEZyDU0WaCdyc6yh2rNFEjD6BKODjhvEV2EQUD35Wlf3lukcFSLwVnc9/bTcZ 8n0g== X-Gm-Message-State: AOAM532/3ddbm9U1Q6Ha5fpuaOUQc0O71D5ua757Vu08BuIHbFO5bTeO bsr7W5aODQvZntlavJwEYRdjrtKp6ww03uO7wDE= X-Google-Smtp-Source: ABdhPJxmLZbkCqBDN892hsF9UJlmI/yCHjXFWkgHbfNoOGVQC0MQIlJDHD5RdAO3Zwz9/opKp53Vv6jsPSjOTIkX/o4= X-Received: by 2002:a05:6e02:198e:: with SMTP id g14mr15942214ilf.271.1616922707391; Sun, 28 Mar 2021 02:11:47 -0700 (PDT) MIME-Version: 1.0 References: <20210305162149.2196166-1-asekhar@marvell.com> <20210305162149.2196166-2-asekhar@marvell.com> In-Reply-To: <20210305162149.2196166-2-asekhar@marvell.com> From: Jerin Jacob Date: Sun, 28 Mar 2021 14:41:31 +0530 Message-ID: To: Ashwin Sekhar T K Cc: dpdk-dev , Jerin Jacob , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Pavan Nikhilesh , Kiran Kumar K , Satheesh Paul Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/6] mempool/cnxk: add build infra and device probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 5, 2021 at 11:43 PM Ashwin Sekhar T K wrote: > > Add the meson based build infrastructure along > with mempool device probe. > > Signed-off-by: Ashwin Sekhar T K > --- > drivers/mempool/cnxk/cnxk_mempool.c | 212 ++++++++++++++++++++++++++++ > drivers/mempool/cnxk/cnxk_mempool.h | 12 ++ > drivers/mempool/cnxk/meson.build | 29 ++++ > drivers/mempool/cnxk/version.map | 3 + > drivers/mempool/meson.build | 3 +- > 5 files changed, 258 insertions(+), 1 deletion(-) > create mode 100644 drivers/mempool/cnxk/cnxk_mempool.c > create mode 100644 drivers/mempool/cnxk/cnxk_mempool.h > create mode 100644 drivers/mempool/cnxk/meson.build > create mode 100644 drivers/mempool/cnxk/version.map > > diff --git a/drivers/mempool/cnxk/cnxk_mempool.c b/drivers/mempool/cnxk/cnxk_mempool.c > new file mode 100644 > index 0000000000..c24497a6e5 > --- /dev/null > +++ b/drivers/mempool/cnxk/cnxk_mempool.c > @@ -0,0 +1,212 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(C) 2021 Marvell. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "roc_api.h" > +#include "cnxk_mempool.h" > + > +#define CNXK_NPA_DEV_NAME RTE_STR(cnxk_npa_dev_) > +#define CNXK_NPA_DEV_NAME_LEN (sizeof(CNXK_NPA_DEV_NAME) + PCI_PRI_STR_SIZE) > +#define CNXK_NPA_MAX_POOLS_PARAM "max_pools" > + > +uintptr_t *cnxk_mempool_internal_data; Could you remove this global variable, either move to dev structure or use memzone lookup. > + > +#endif > diff --git a/drivers/mempool/cnxk/meson.build b/drivers/mempool/cnxk/meson.build > new file mode 100644 > index 0000000000..23a171c143 > --- /dev/null > +++ b/drivers/mempool/cnxk/meson.build > @@ -0,0 +1,29 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(C) 2021 Marvell. > +# > + > +if is_windows > + build = false > + reason = 'not supported on Windows' > + subdir_done() > +endif > +if not dpdk_conf.get('RTE_ARCH_64') > + build = false > + reason = 'only supported on 64-bit' > + subdir_done() > +endif Please make it as positive logic and limit driver only for "64bit Linux" > + > +sources = files('cnxk_mempool.c') > + > +deps += ['eal', 'mbuf', 'kvargs', 'bus_pci', 'common_cnxk', 'mempool'] > + > +cflags_options = [ > + '-Wno-strict-prototypes', > + '-Werror' Please limit the driver to "64bit Linux" and please remove this fixup.