From: Jerin Jacob <jerinjacobk@gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dpdk-dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Gaetan Rivet <grive@u256.net>
Subject: Re: [dpdk-dev] [PATCH] doc: announce PCI resources map API removal
Date: Tue, 4 Aug 2020 14:22:11 +0530 [thread overview]
Message-ID: <CALBAE1ML3RN0ELFH3X80zhU=maXn7zHPCXH7sW-sch1gsrGd5w@mail.gmail.com> (raw)
In-Reply-To: <20200804084732.882-1-david.marchand@redhat.com>
On Tue, Aug 4, 2020 at 2:18 PM David Marchand <david.marchand@redhat.com> wrote:
>
> The PCI resources map API (pci_map_resource/pci_unmap_resource) was
> imposing use of Unix mmap flags while it does not make sense on Windows.
> This API was only used to internally setup PCI devices in the PCI bus
> driver and has no known external users.
>
> Announce its removal in 20.11 with its associated structures.
>
> The workaround implemented in the commit 9d2b24593724 ("pci: keep API
> compatibility with mmap values") will be removed at the same time.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index ea4cfa7a48..24808c002c 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -67,6 +67,17 @@ Deprecation Notices
> us extending existing enum/define.
> One solution can be using a fixed size array instead of ``.*MAX.*`` value.
>
> +* pci: The PCI resources map API (``pci_map_resource`` and
> + ``pci_unmap_resource``) was not abstracting the Unix mmap flags (see the
> + workaround for Windows support implemented in the commit
> + 9d2b24593724 ("pci: keep API compatibility with mmap values")).
> + This API will be removed from the public API in 20.11 and moved to the PCI
> + bus driver along with the PCI resources lists and associated structures
> + (``pci_map``, ``pci_msix_table``, ``mapped_pci_resource`` and
> + ``mapped_pci_res_list``).
> + With this removal, there won't be a need for the mentioned workaround which
> + will be reverted.
> +
> * ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible
> will be done in 20.11.
> Currently the ``struct eth_dev_ops`` struct is accessible by the application
> --
> 2.23.0
>
next prev parent reply other threads:[~2020-08-04 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 8:47 David Marchand
2020-08-04 8:52 ` Jerin Jacob [this message]
2020-08-04 11:20 ` Gaëtan Rivet
2020-08-05 23:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1ML3RN0ELFH3X80zhU=maXn7zHPCXH7sW-sch1gsrGd5w@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=grive@u256.net \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).