From: Jerin Jacob <jerinjacobk@gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Wires, Kent" <kent.wires@intel.com>
Subject: Re: [PATCH v4] event/dlb2: add support for single 512B write of 4 QEs
Date: Thu, 9 Jun 2022 23:10:00 +0530 [thread overview]
Message-ID: <CALBAE1MLhhN=mP28dEEtDQ0w7zNwYfy9iN_N=omDxS8QsQXVxA@mail.gmail.com> (raw)
In-Reply-To: <You8a1wJJtW5fNxZ@bricha3-MOBL.ger.corp.intel.com>
On Mon, May 23, 2022 at 10:25 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Mon, May 23, 2022 at 05:52:06PM +0100, McDaniel, Timothy wrote:
> >
> >
> > >
> > > Instead, I'd recommend doing as other places in DPDK - such as in ACL
> > > library, or i40e or ice net drivers - where we not only check the current
> > > build support, but also check the compiler support. That way, even if we
> > > are building for e.g. a target of AVX2, we can still build the AVX-512
> > > parts using the appropriate compiler flags, and choose them
> > > opportunistically at runtime.
> >
> > I do not understand what you are getting at here.
> >
> Check out net/i40e/meson.build and hopefully things may become clearer.
I am updating the patchwork status as "Changes requested" for this patch.
@McDaniel, Timothy Please send the updated version. Also, the
following patch depends on this. I will wait for the merging below
after this patch is merged.
https://patches.dpdk.org/project/dpdk/patch/20220410225602.1524724-1-timothy.mcdaniel@intel.com/
https://patches.dpdk.org/project/dpdk/patch/20220410224755.1524117-1-timothy.mcdaniel@intel.com/
>
> /Bruce
next prev parent reply other threads:[~2022-06-09 17:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 15:18 [PATCH] " Timothy McDaniel
2022-05-14 12:07 ` Jerin Jacob
2022-05-16 8:42 ` Bruce Richardson
2022-05-16 17:00 ` McDaniel, Timothy
2022-05-19 20:24 ` [PATCH v3] " Timothy McDaniel
2022-05-23 16:09 ` [PATCH v4] " Timothy McDaniel
2022-05-23 16:34 ` Bruce Richardson
2022-05-23 16:52 ` McDaniel, Timothy
2022-05-23 16:55 ` Bruce Richardson
2022-06-09 17:40 ` Jerin Jacob [this message]
2022-06-09 18:02 ` McDaniel, Timothy
2022-05-23 16:37 ` Bruce Richardson
2022-05-23 16:45 ` McDaniel, Timothy
2022-06-10 12:43 ` [PATCH v6] " Timothy McDaniel
2022-06-10 15:41 ` [PATCH v7] " Timothy McDaniel
2022-06-10 16:15 ` Bruce Richardson
2022-06-10 16:27 ` [PATCH v8] " Timothy McDaniel
2022-06-13 6:30 ` Jerin Jacob
2022-06-13 20:39 ` [PATCH v9] " Timothy McDaniel
2022-06-14 10:40 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1MLhhN=mP28dEEtDQ0w7zNwYfy9iN_N=omDxS8QsQXVxA@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kent.wires@intel.com \
--cc=timothy.mcdaniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).