From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBC6E433A2; Thu, 23 Nov 2023 05:11:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E292402BD; Thu, 23 Nov 2023 05:11:25 +0100 (CET) Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by mails.dpdk.org (Postfix) with ESMTP id 2167740041 for ; Thu, 23 Nov 2023 05:11:24 +0100 (CET) Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-41cda69486eso2466601cf.3 for ; Wed, 22 Nov 2023 20:11:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700712683; x=1701317483; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RDzOvM0QlIYDZ23PMrLjJnV5kqBNGC8NgiS8WOjNUQ8=; b=IRKu8wea/D6Q27XpTFzz/mBkXZBxpo+CwtVtjYT7RH1kuqRnJFjnxw3uNeAhcU9PTU agoJQNnkxlmX01CIZe63+6xsX0yP6eKuVBtb9TGWshLlzfGddfzzuuEQ0ekOJyY8XBhl Ohs0TOaqLlx66vgKUiNR2qcg7g7DjLTxNkvIOjwqjUcJD/hBh1W8sVvSMsClP+WlIgyd 2mygF9izy2XebOZqv4yZ4run1nFmIV9DTLBefJ1Tc8FX+tfB19hefv5A2VAA6qN040Ft DNPzuSeuzLtDj5NtmGUWTdk7Pwg1A+n6ro/alxZCpRYUJw0KGhwfHUrVrXmKCSTaChQ3 B/1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700712683; x=1701317483; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RDzOvM0QlIYDZ23PMrLjJnV5kqBNGC8NgiS8WOjNUQ8=; b=HJeN2ipXNaRHQKR7/OWYb8C0BN35Fg8XY8eamU2hLJTTL7voCvCCHHNxSYf1HNB/tj IaQsdylAQcnYv293k38HSCXQl2TGOsiSpnPEasnDiuADBaLiaNehpnDjjYEYOHd+/0j9 e2FcLofRAjviFvT6vXDCDh+7sg6tmUlB2IOirRf0lJ3mHT50wVZRvObK6mF4viHmAOOu FeQc26TSnxI/w2CazdQ9lrLD+1iRM1LaHDzXEuT4Ve0T7g1sCsDeNfsL8e4vOp2SsqJK R0NomLWAQeGGpXnLgcEv0uG4lOsw3hSx+evnU5DvK0LwYnGPgEyLID1iCflzXe2YrS0b kHrw== X-Gm-Message-State: AOJu0YyzeLGVDncyrxZD0+sitdOYZFwwh0SglaDQOlXU3uHHFsN0N+DX u7uDMuJNrfsIvtvDlRCb3JrevcpFFqnOqvs0iTI= X-Google-Smtp-Source: AGHT+IHiwRg/4YB/7aZmmkWNiNfr7Zwkuo9AEnNf0/ha7/qxhZMf+PjCH8TrhFj0GZPSXJ50BrBb4Ew6m/xRfSpHiBM= X-Received: by 2002:a05:622a:1e12:b0:423:8c36:55fb with SMTP id br18-20020a05622a1e1200b004238c3655fbmr530340qtb.66.1700712683386; Wed, 22 Nov 2023 20:11:23 -0800 (PST) MIME-Version: 1.0 References: <20231120172606.505579-1-bruce.richardson@intel.com> <20231121115437.96500-1-bruce.richardson@intel.com> <20231121115437.96500-9-bruce.richardson@intel.com> In-Reply-To: <20231121115437.96500-9-bruce.richardson@intel.com> From: Jerin Jacob Date: Thu, 23 Nov 2023 09:40:57 +0530 Message-ID: Subject: Re: [PATCH 24.03 v2 8/9] event/opdl: add schedule-type capability flags To: Bruce Richardson Cc: dev@dpdk.org, Liang Ma , Peter Mccarthy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 21, 2023 at 11:47=E2=80=AFPM Bruce Richardson wrote: > > Document explicitly the scheduling types supported by this driver, both > via info_get() function, and via table in the documentation. > > Signed-off-by: Bruce Richardson > --- > > Maintainers, please check this patch carefully, as I'm not sure the > correct way to document this. > > According to the docs for this driver, it supports parallel only via > ordered. Therefore, I've actually made the docs inconsistent from the > flags claimed in the API. I've documented that PARALLEL is supported in > the info_get() flags, so code that checks for that will run, but I've > omitted it from the table in the docs, since it is not directly > supported. Is this a good compromise, or an accurate reflection of the > driver? > --- > doc/guides/eventdevs/features/opdl.ini | 2 ++ > drivers/event/opdl/opdl_evdev.c | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/doc/guides/eventdevs/features/opdl.ini b/doc/guides/eventdev= s/features/opdl.ini > index 5cc35d3c77..7adccc98de 100644 > --- a/doc/guides/eventdevs/features/opdl.ini > +++ b/doc/guides/eventdevs/features/opdl.ini > @@ -4,6 +4,8 @@ > ; Refer to default.ini for the full list of available PMD features. > ; > [Scheduling Features] > +atomic_scheduling =3D Y > +ordered_scheduling =3D Y Missed parallel > burst_mode =3D Y > carry_flow_id =3D Y > maintenance_free =3D Y > diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_ev= dev.c > index 0cccaf7e97..b34a5fcacd 100644 > --- a/drivers/event/opdl/opdl_evdev.c > +++ b/drivers/event/opdl/opdl_evdev.c > @@ -376,6 +376,9 @@ opdl_info_get(struct rte_eventdev *dev, struct rte_ev= ent_dev_info *info) > .max_event_port_enqueue_depth =3D MAX_OPDL_CONS_Q_DEPTH, > .max_num_events =3D OPDL_INFLIGHT_EVENTS_TOTAL, > .event_dev_cap =3D RTE_EVENT_DEV_CAP_BURST_MODE | > + RTE_EVENT_DEV_CAP_ORDERED | > + RTE_EVENT_DEV_CAP_ATOMIC | > + RTE_EVENT_DEV_CAP_PARALLEL | > RTE_EVENT_DEV_CAP_CARRY_FLOW_ID | > RTE_EVENT_DEV_CAP_MAINTENANCE_FREE, > .max_profiles_per_port =3D 1, > -- > 2.39.2 >