From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6A7CA00C2; Wed, 23 Feb 2022 17:59:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98D0940E5A; Wed, 23 Feb 2022 17:59:05 +0100 (CET) Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) by mails.dpdk.org (Postfix) with ESMTP id BE33440DF6 for ; Wed, 23 Feb 2022 17:59:03 +0100 (CET) Received: by mail-il1-f171.google.com with SMTP id n5so15772128ilk.12 for ; Wed, 23 Feb 2022 08:59:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ClnfNxbBEpwlXqXYbD5zwt/Xj/rF6Uk/p8jvTum6G8o=; b=a3oSIiY6hNTUG748x6mN8IRyNgyWUQWcgLBq9P9iKpX8e+p5gHDRAN6gZ/ejWluDOU FrTHnLKCOgDFw7YGq5qwTZpOnoVXk5JHzZZJTNu8f3asixpzcQK+l8C7CgFYFLJq/j3j Gp77HIfkKPv49ftQx5zQ9F0m+PtdIvGTDMFMA442dKPOftwf+RyThLOsvywsFj4Wg+xh rUiyZP+ltT5SZZEDIffngu5khXKjlcMdTCoV2YLfL6+C2WBND9c6gpnuKJkZdWmlRZhH 23TbTIlCwwsUIRkdTyOuQPAEZNLQbDiiuTGA2YI6m3iOaGGwcMHfWrsg0n+ucSJvFCAw al2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ClnfNxbBEpwlXqXYbD5zwt/Xj/rF6Uk/p8jvTum6G8o=; b=5wCJwWax2GJp6/HVTno/fpmdVjmsjmCRYcl6el1Gr5xhfo+AXQDEnV81KUH8FuFNZQ Fe92sZ+34DlIc9IxIas1LZLpYPvjWqawW5y+/8ZaqZ4DoArkz5+0FXN0zz3qQ6HLFq/R Tkek78PW5LBVtd4nzBflgoHOBobMGMkCPrpTniEwDY1J33Z5DeGPtDo1LD8xBcZSjeeb a6FbHRCxxva8935GhExkVI4iV1wNlHHjLxTfjOwTYPj3qg+sy8IUxK5m00UF+qZRMSWc ml8zWFTYubVC2GHFq7nC0xhnGuLP2ZEDtcX1FXEScGfMETT6n2oMTUosmu4rUlO8RNMG 1vXg== X-Gm-Message-State: AOAM5310XyPN8TYVY3TMz49bm6s/8ldrnl3RnGGr3OrmcY4hj/TcQuov Aeu2/+fwI+ICnNuUB2E3TWYDy3bQh4PSi4fBdUTRGYmSpuY= X-Google-Smtp-Source: ABdhPJyIJGC2C8jwfcI42fEruh/y6iOwLkDuTxyhDfRiRufhweL8w96XR0COrG6Ms5/1ywEavsAwjInbr/Jq9MtEtjc= X-Received: by 2002:a05:6e02:16c9:b0:2c2:431c:d0df with SMTP id 9-20020a056e0216c900b002c2431cd0dfmr517856ilx.294.1645635543112; Wed, 23 Feb 2022 08:59:03 -0800 (PST) MIME-Version: 1.0 References: <20220223073443.647695-1-ganapati.kundapura@intel.com> In-Reply-To: <20220223073443.647695-1-ganapati.kundapura@intel.com> From: Jerin Jacob Date: Wed, 23 Feb 2022 22:28:37 +0530 Message-ID: Subject: Re: [PATCH v1] eventdev/crypto_adapter: remove logically dead code To: Ganapati Kundapura Cc: "Jayatheerthan, Jay" , "Gujjar, Abhinandan S" , dpdk-dev Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 23, 2022 at 1:04 PM Ganapati Kundapura wrote: > > eca_cryptodev_cdev_flush() is internal function and called with > valid range of cdevs. > > crypto_cdev_info structure is allocated at adapter creation time > and retrieved from the adapter for a valid cdevs which cannot be NULL > and hence no need for NULL check. > > Fixes: 2ae84b39ae7b ("eventdev/crypto: store operations in circular buffer") > > Signed-off-by: Ganapati Kundapura @Jayatheerthan, Jay @Gujjar, Abhinandan S Could you review this?