From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09E0BA00C2; Tue, 27 Sep 2022 12:57:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A552741133; Tue, 27 Sep 2022 12:57:51 +0200 (CEST) Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by mails.dpdk.org (Postfix) with ESMTP id 40EA7410D0 for ; Tue, 27 Sep 2022 12:57:50 +0200 (CEST) Received: by mail-qt1-f169.google.com with SMTP id c11so5732398qtw.8 for ; Tue, 27 Sep 2022 03:57:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=uIAD80TsnqhoEIoAg9OGDazohZtAd5BKAn6Ie8u7sdQ=; b=LFd3Y/4epm3hph9eYlirrtitexeS1PoPorHm3d5gG778t44dh/95UTfuJhaBfyZrYn ozuvEJPFMPPKnchYGaRN+CvoE4oOZdNRmE+YFrDtdA4cogn4L3w0NG4i3gWzYc4z2eDQ WzPlH+U1lyZ3eq6Oit45AqprkJSjyheqOM3m9eGHCZQ/koHgnBqJZNpktJjdDlaXYLIz kH1eCFzfSObFELiB9bMdUqSEOw15Y0ymC6sYTkeHSHxISqLTUt42DSFGRDAYpIrT5Vae IoD0yS3rEaVdtapkqewDWw8GSBIKw6Fdl2/UfstWjrvwF96SzWFlo6RtsP4qAISEPkwO 6URw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=uIAD80TsnqhoEIoAg9OGDazohZtAd5BKAn6Ie8u7sdQ=; b=JXYbsMzCOvJG1KxaJpYqzaNcAqzdzi3Huv3QGv1haMo3ds9GcX0O4GG0KvLgSpU5Zo 1ohrCbWTWiHXOPj4F9H+1taAT61YDEJqAnDRlyG4cLyNtpPdCgpLpkJhJHGWsv13tT+i VK6irKr92mFBR4Uweo2a3WR5R8uExcMlMCNTXQI5F8iJmE5NktsIV8bObRYSBS1lkF6c E6y72XCbc80FPPMfEAJa5orf+8yvyxMj+RhF5ObIeKsOwWlwuKOwpgtLGfdLwj62o2jC ccAmmbP7DsfJRdPCnDe+UH9hgTcFuNzjDUt5O0p7wj82Rt9ygXTDjR4CVKDrI45kz54a asAg== X-Gm-Message-State: ACrzQf0LKb9lvGDFrD2ZS/pk/TRFYro8kJsg9rcHx72W5yQF/XaL/1Ww nmzX0odsBQVKt9ZcHK4ihDrHHGxYvM76mdyR6vY= X-Google-Smtp-Source: AMsMyM7ft0Mn/U+oTqj167pVyzxXCdcieYjXi2ITA8QHueKdv0SDrVGodcqAsVwNVz0PII/rqojjTp8jz6/Vpjj7uGM= X-Received: by 2002:ac8:7d90:0:b0:35b:afd3:20aa with SMTP id c16-20020ac87d90000000b0035bafd320aamr21246363qtd.252.1664276269549; Tue, 27 Sep 2022 03:57:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jerin Jacob Date: Tue, 27 Sep 2022 16:27:23 +0530 Message-ID: Subject: Re: [PATCH v2] drivers: remove support to limit XAQ in cnxk event driver To: Shijith Thotton Cc: jerinj@marvell.com, dev@dpdk.org, pbhagavatula@marvell.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Sep 20, 2022 at 12:33 PM Shijith Thotton wrote: > > Removed support to limit XAQ from devargs. If XAQ is limited, new add > works could run out of XAQ entries and disable the queue. > > Signed-off-by: Shijith Thotton Updated the git commit as follows and applied to dpdk-next-net-eventdev/for-main. Thanks commit cd3183a459522daa7d978c5db5576b04e956bbcf Author: Shijith Thotton Date: Tue Sep 20 12:33:39 2022 +0530 drivers: remove option to limit XAQ in cnxk event driver Removed support to limit XAQ from devargs. If XAQ is limited, new add works could run out of XAQ entries and disable the queue. Signed-off-by: Shijith Thotton > --- > v2: > * Removed used function parameter. > > doc/guides/eventdevs/cnxk.rst | 5 ++--- > drivers/common/cnxk/roc_mbox.h | 2 +- > drivers/common/cnxk/roc_sso.c | 4 +--- > drivers/common/cnxk/roc_sso.h | 2 +- > drivers/event/cnxk/cnxk_eventdev.c | 11 ++++------- > drivers/event/cnxk/cnxk_eventdev.h | 1 - > 6 files changed, 9 insertions(+), 16 deletions(-) > > diff --git a/doc/guides/eventdevs/cnxk.rst b/doc/guides/eventdevs/cnxk.rst > index 8537f6257e..3baf26fb54 100644 > --- a/doc/guides/eventdevs/cnxk.rst > +++ b/doc/guides/eventdevs/cnxk.rst > @@ -95,12 +95,11 @@ Runtime Config Options > We can control the QoS of SSO GGRP by modifying the above mentioned > thresholds. GGRPs that have higher importance can be assigned higher > thresholds than the rest. The dictionary format is as follows > - [Qx-XAQ-TAQ-IAQ][Qz-XAQ-TAQ-IAQ] expressed in percentages, 0 represents > - default. > + [Qx-TAQ-IAQ][Qz-TAQ-IAQ] expressed in percentages, 0 represents default. > > For example:: > > - -a 0002:0e:00.0,qos=[1-50-50-50] > + -a 0002:0e:00.0,qos=[1-50-50] > > - ``Force Rx Back pressure`` > > diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h > index 965c704322..d07c8be9d9 100644 > --- a/drivers/common/cnxk/roc_mbox.h > +++ b/drivers/common/cnxk/roc_mbox.h > @@ -1330,7 +1330,7 @@ struct sso_grp_priority { > struct sso_grp_qos_cfg { > struct mbox_msghdr hdr; > uint16_t __io grp; > - uint32_t __io xaq_limit; > + uint32_t __io rsvd; > uint16_t __io taq_thr; > uint16_t __io iaq_thr; > }; > diff --git a/drivers/common/cnxk/roc_sso.c b/drivers/common/cnxk/roc_sso.c > index 126a9cba99..9d5efe848e 100644 > --- a/drivers/common/cnxk/roc_sso.c > +++ b/drivers/common/cnxk/roc_sso.c > @@ -377,7 +377,7 @@ roc_sso_hwgrp_hws_link_status(struct roc_sso *roc_sso, uint8_t hws, > > int > roc_sso_hwgrp_qos_config(struct roc_sso *roc_sso, struct roc_sso_hwgrp_qos *qos, > - uint8_t nb_qos, uint32_t nb_xaq) > + uint8_t nb_qos) > { > struct sso *sso = roc_sso_to_sso_priv(roc_sso); > struct dev *dev = &sso->dev; > @@ -386,7 +386,6 @@ roc_sso_hwgrp_qos_config(struct roc_sso *roc_sso, struct roc_sso_hwgrp_qos *qos, > > plt_spinlock_lock(&sso->mbox_lock); > for (i = 0; i < nb_qos; i++) { > - uint8_t xaq_prcnt = qos[i].xaq_prcnt; > uint8_t iaq_prcnt = qos[i].iaq_prcnt; > uint8_t taq_prcnt = qos[i].taq_prcnt; > > @@ -405,7 +404,6 @@ roc_sso_hwgrp_qos_config(struct roc_sso *roc_sso, struct roc_sso_hwgrp_qos *qos, > } > } > req->grp = qos[i].hwgrp; > - req->xaq_limit = (nb_xaq * (xaq_prcnt ? xaq_prcnt : 100)) / 100; > req->iaq_thr = (SSO_HWGRP_IAQ_MAX_THR_MASK * > (iaq_prcnt ? iaq_prcnt : 100)) / > 100; > diff --git a/drivers/common/cnxk/roc_sso.h b/drivers/common/cnxk/roc_sso.h > index ab7cee1c60..5075991ef7 100644 > --- a/drivers/common/cnxk/roc_sso.h > +++ b/drivers/common/cnxk/roc_sso.h > @@ -89,7 +89,7 @@ int __roc_api roc_sso_rsrc_init(struct roc_sso *roc_sso, uint8_t nb_hws, > void __roc_api roc_sso_rsrc_fini(struct roc_sso *roc_sso); > int __roc_api roc_sso_hwgrp_qos_config(struct roc_sso *roc_sso, > struct roc_sso_hwgrp_qos *qos, > - uint8_t nb_qos, uint32_t nb_xaq); > + uint8_t nb_qos); > int __roc_api roc_sso_hwgrp_alloc_xaq(struct roc_sso *roc_sso, > uint32_t npa_aura_id, uint16_t hwgrps); > int __roc_api roc_sso_hwgrp_release_xaq(struct roc_sso *roc_sso, > diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c > index 8923e94824..db62d32a81 100644 > --- a/drivers/event/cnxk/cnxk_eventdev.c > +++ b/drivers/event/cnxk/cnxk_eventdev.c > @@ -400,10 +400,8 @@ cnxk_sso_start(struct rte_eventdev *event_dev, cnxk_sso_hws_reset_t reset_fn, > qos[i].hwgrp = dev->qos_parse_data[i].queue; > qos[i].iaq_prcnt = dev->qos_parse_data[i].iaq_prcnt; > qos[i].taq_prcnt = dev->qos_parse_data[i].taq_prcnt; > - qos[i].xaq_prcnt = dev->qos_parse_data[i].xaq_prcnt; > } > - rc = roc_sso_hwgrp_qos_config(&dev->sso, qos, dev->qos_queue_cnt, > - dev->xae_cnt); > + rc = roc_sso_hwgrp_qos_config(&dev->sso, qos, dev->qos_queue_cnt); > if (rc < 0) { > plt_sso_dbg("failed to configure HWGRP QoS rc = %d", rc); > return -EINVAL; > @@ -477,7 +475,7 @@ parse_queue_param(char *value, void *opaque) > } > > if (val != (&queue_qos.iaq_prcnt + 1)) { > - plt_err("Invalid QoS parameter expected [Qx-XAQ-TAQ-IAQ]"); > + plt_err("Invalid QoS parameter expected [Qx-TAQ-IAQ]"); > return; > } > > @@ -525,9 +523,8 @@ parse_sso_kvargs_dict(const char *key, const char *value, void *opaque) > { > RTE_SET_USED(key); > > - /* Dict format [Qx-XAQ-TAQ-IAQ][Qz-XAQ-TAQ-IAQ] use '-' cause ',' > - * isn't allowed. Everything is expressed in percentages, 0 represents > - * default. > + /* Dict format [Qx-TAQ-IAQ][Qz-TAQ-IAQ] use '-' cause ',' isn't allowed. > + * Everything is expressed in percentages, 0 represents default. > */ > parse_qos_list(value, opaque); > > diff --git a/drivers/event/cnxk/cnxk_eventdev.h b/drivers/event/cnxk/cnxk_eventdev.h > index e8129bf774..3a8de0bac0 100644 > --- a/drivers/event/cnxk/cnxk_eventdev.h > +++ b/drivers/event/cnxk/cnxk_eventdev.h > @@ -83,7 +83,6 @@ typedef int (*cnxk_sso_hws_flush_t)(void *ws, uint8_t queue_id, uintptr_t base, > > struct cnxk_sso_qos { > uint16_t queue; > - uint16_t xaq_prcnt; > uint16_t taq_prcnt; > uint16_t iaq_prcnt; > }; > -- > 2.25.1 >