From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06273A04F5; Thu, 12 Dec 2019 18:12:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30EB21BF75; Thu, 12 Dec 2019 18:12:40 +0100 (CET) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id DDE681BF6C for ; Thu, 12 Dec 2019 18:12:38 +0100 (CET) Received: by mail-io1-f65.google.com with SMTP id i11so3545320ioi.12 for ; Thu, 12 Dec 2019 09:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8dwSC8SEdzdc1fFlHyM/cH3/WdwwKk6uu26/gS+Qf7A=; b=enFAnhXPcNM1pBC77EJJJkDK33Pt4KPif2LhaZ1Y8Hpg247CbKoD4XJK0DqwwMfOFp 2nq/Iita2cIEBMLPmv6WagUN+snvURLKN2CMdhtroBkgBX5ZMX02oqGiqCx5vgZMM6WL GaYDvaYKBKNXnb9ERj7jHPtTJq2KBqfkrgiCX6+y9H4NyQslJhenIwSP66mYVC7YQ/+d HEI3LkSpQI+cYEKFED3pivKrgIWatL5IakPq2W19e/R9m0f5hzmjvEDg0IP1rdejDgtx rcb+mkENvgsutt3Q+rzA8sOvg+46YStlQHIgG2nnwweX+zlSsedPmI5mCdi+2r1HUkQJ /7bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8dwSC8SEdzdc1fFlHyM/cH3/WdwwKk6uu26/gS+Qf7A=; b=Fk54wuvmYeWmVtsCgP5KbtF23M6aRnP2LGsJFAGQ5LYckwukytUCdTyRbev5YZxX4W QZKWOMW/dna1N+lKufvbWKt+wU2gUhPNylfKxUzxMsxa7S/aimle8yRJlN8/juz9KMPO gAz5M5TGYGLcpFN/yKIO25QqwxPCrspZkJ4xPNy59Z5RSFxpF33yCxF2FZjv85nE9VcT hi2C+rdDUfao7+vIO6HSdegPM5SMaP7B7B5egyCrnkuIyyE1yucphNPzJM5WtvmStOrf 18Dh0uT1Q9K2ymyj4rV+n0RfnBc/DMU1loJWTs3mRRp4uOV8iRDDZKaMTGOJf178L5iP iBBA== X-Gm-Message-State: APjAAAXsTGukmFRIk50MyfHSwIkpjMms9S5XirP8LF7v7jcW0mPoGMe6 R/PRnMg95k0pGZOXraP+TQtseXNwhj6lmIyRzmc= X-Google-Smtp-Source: APXvYqwWj2nNT13+Jk6TwrkRmCkKSpDh8ARkSW07dQ0VgyZqis2ni1ik/KwwLqEr5cN2EkMiLZdkWolc92jpSu1oIvs= X-Received: by 2002:a05:6638:a2c:: with SMTP id 12mr8972289jao.60.1576170757939; Thu, 12 Dec 2019 09:12:37 -0800 (PST) MIME-Version: 1.0 References: <1576057875-7677-1-git-send-email-xiaojun.liu@silicom.co.il> <1576057875-7677-2-git-send-email-xiaojun.liu@silicom.co.il> In-Reply-To: From: Jerin Jacob Date: Thu, 12 Dec 2019 22:42:21 +0530 Message-ID: To: Xiaojun Liu Cc: "xiao.w.wang@intel.com" , "qi.z.zhang@intel.com" , "ngai-mint.kwan@intel.com" , "jakub.fornal@intel.co" , "jacob.e.keller@intel.com" , "dev@dpdk.org" , Jeff Zheng , Eyal Cohen Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/7] net/fm10k: add i2c sbus registers definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Dec 12, 2019 at 3:05 PM Xiaojun Liu wrote: > > This is not a generic i2c bus, but rather an indirect access to i2c devices through FM10k registers. It's only purpose is to support the fm10k chip. Also there's currently no i2c bus support framework in DPDK. To understand it better: # Who are the i2c master and i2c slave here? # Is i2c slave connected on board or in-built to FM10K SoC? # What is the purpose of the i2c API in the ethdev driver? > > -----Original Message----- > From: Jerin Jacob [mailto:jerinjacobk@gmail.com] > Sent: Wednesday, December 11, 2019 11:48 PM > To: Xiaojun Liu > Cc: xiao.w.wang@intel.com; qi.z.zhang@intel.com; ngai-mint.kwan@intel.com; jakub.fornal@intel.co; jacob.e.keller@intel.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/7] net/fm10k: add i2c sbus registers definition > > On Wed, Dec 11, 2019 at 3:22 PM Xiaojun Liu wrote: > > > > To support switch management, add the following files: > > Add fm10k/switch/fm10k_debug.h(define log Macros). > > Add fm10k/switch/fm10k_regs.h(define all the registers). > > Add fm10k/switch/fm10k_switch.h(define switch Macros and APIs). > > Add fm10k/switch/fm10k_i2c.h(define I2C interfaces). > > Add fm10k/switch/fm10k_i2c.c(support I2C access). > > Add fm10k/switch/fm10k_sbus.h(define SBUS interface). > > Add fm10k/switch/fm10k_sbus.c(support SBUS access). > > and modify fm10k/Makefile(add ENABLE_FM10K_MANAGEMENT support, > > add fm10k_i2c.c and fm10k_sbus.c). > > Integrating NIC with the integrated or onboard switches over i2c or > sbus is a common problem. > Instead of polluting ethdev driver with i2c and sbus _bus_ code, Why > not add new i2c bus > and move this code to driver/bus/i2c/xxxx/ > > > > > To avoid configuration for both kernel driver > > and userspace SDK outside DPDK, we add switch > > management in FM10K DPDK PMD driver. > > To enable switch management, you need add > > CONFIG_RTE_FM10K_MANAGEMENT=y in > > config/common_linux when building. > > > > Signed-off-by: Xiaojun Liu