From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C55BEA052A; Mon, 3 Aug 2020 13:56:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3199A2C12; Mon, 3 Aug 2020 13:56:59 +0200 (CEST) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by dpdk.org (Postfix) with ESMTP id 6E08B2AB for ; Mon, 3 Aug 2020 13:56:58 +0200 (CEST) Received: by mail-il1-f193.google.com with SMTP id y18so22390597ilp.10 for ; Mon, 03 Aug 2020 04:56:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UQaNbPXNa2S821TXf+cVNit/GvihI99XmmLP0aQPyAs=; b=JYYq/CAskxSsILhDhMF+P8JWHXMwRq+U3zpkkPZMqsQU23gVQsm9xhAzQKQTWLRSG7 uGU6d0JQQUR4vfbzOuuBokNpFQNJq15ow4AQJZ7rYZOha10shYKH81GwHZnzHqzKsDjZ jD/PdlNQjzufaY4Ug9YmphKvsj2IFCyX8SELKzozOgCyPtOsnkaATe4vG3NZ33thwdoJ riv2Cd26Oaq48bEESY7kF81SFHpt4/wA1kOYpHlb4CGR4Sgc+rhEckJUhflUbue0F+Zc onIB6uIjr8N/UDt0Pv08klugg3JDCPjrfEotmJmLpQtjxL+fNnHS7UQyyKjaCgekdE6X inyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UQaNbPXNa2S821TXf+cVNit/GvihI99XmmLP0aQPyAs=; b=iNiadeuvkxug7xT4eD/YhOM9dnvJOIX3dsuL64qP4YwDbalsnkcyw9dPCkL3aZw2a3 1cdI06VpqWaej3OMVXIHt8qqyFOpfnV76xbBOqgkD3S96QHbNeEf3P/+rEyJzDNbiVQp BnlQvD53y3ZwAeAdtxapsKAgceEVcE8jHoDY9y9Aj4s3x1MmCh9ow9Q62pch2Rrd/pMe 9JG6mU3/30QJgsq23NTN8Fi4rG2Bz8XGrNneis/A7cHKGFVwfDEBdtHEmanZusBn3tqS h+VpDaM/OO+dViFhstuLpebGmJBMrtlcyTXkTYGZxMEf54bhaAsvAu0/JiSmS44nmZtg UzYQ== X-Gm-Message-State: AOAM532E3sxLjEPkOcZ3ooHThQ173Gr435MtMY2n+366X/4F8+SsgdWn +dOkjvFF/Kve6aU8GvEpch+YBaG86OQYXjdQk3c= X-Google-Smtp-Source: ABdhPJyEpjL7rwjBokLU2w93JfSGr5rIKtwENpaziW55F7Q+F/R/LqOGxI6VFHc1ztaxD86BQRX/uqzjBbBjm7UAxJk= X-Received: by 2002:a92:dcc8:: with SMTP id b8mr15720530ilr.60.1596455817645; Mon, 03 Aug 2020 04:56:57 -0700 (PDT) MIME-Version: 1.0 References: <1596452291-25535-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1596452291-25535-1-git-send-email-viacheslavo@mellanox.com> From: Jerin Jacob Date: Mon, 3 Aug 2020 17:26:41 +0530 Message-ID: To: Viacheslav Ovsiienko Cc: dpdk-dev , Matan Azrad , Raslan Darawsheh , Thomas Monjalon , Ferruh Yigit , Stephen Hemminger , Andrew Rybchenko , Ajit Khaparde , Maxime Coquelin , Olivier Matz , David Marchand Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] doc: announce changes to ethdev rxconf structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Aug 3, 2020 at 4:28 PM Viacheslav Ovsiienko wrote: > > The DPDK datapath in the transmit direction is very flexible. > The applications can build multisegment packets and manages > almost all data aspects - the memory pools where segments > are allocated from, the segment lengths, the memory attributes > like external, registered, etc. > > In the receiving direction, the datapath is much less flexible, > the applications can only specify the memory pool to configure > the receiving queue and nothing more. In order to extend the > receiving datapath capabilities it is proposed to add the new > fields into rte_eth_rxconf structure: > > struct rte_eth_rxconf { > ... > uint16_t rx_split_num; /* number of segments to split */ > uint16_t *rx_split_len; /* array of segment lengthes */ > struct rte_mempool **mp; /* array of segment memory pools */ The pool has the packet length it's been configured for. So I think, rx_split_len can be removed. This feature also available in Marvell HW. So it not specific to one vendor. Maybe we could just the use case mention the use case in the depreciation notice and the tentative change in rte_eth_rxconf and exact details can be worked out at the time of implementation. With the above change: Acked-by: Jerin Jacob > ... > }; > > The non-zero value of rx_split_num field configures the receiving > queue to split ingress packets into multiple segments to the mbufs > allocated from various memory pools according to the specified > lengths. The zero value of rx_split_num field provides the > backward compatibility and queue should be configured in a regular > way (with single/multiple mbufs of the same data buffer length > allocated from the single memory pool). > > The new approach would allow splitting the ingress packets into > multiple parts pushed to the memory with different attributes. > For example, the packet headers can be pushed to the embedded data > buffers within mbufs and the application data into the external > buffers attached to mbufs allocated from the different memory > pools. The memory attributes for the split parts may differ > either - for example the application data may be pushed into > the external memory located on the dedicated physical device, > say GPU or NVMe. This would improve the DPDK receiving datapath > flexibility preserving compatibility with existing API. > > Signed-off-by: Viacheslav Ovsiienko > --- > doc/guides/rel_notes/deprecation.rst | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index ea4cfa7..cd700ae 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -99,6 +99,11 @@ Deprecation Notices > In 19.11 PMDs will still update the field even when the offload is not > enabled. > > +* ethdev: add new fields to ``rte_eth_rxconf`` to configure the receiving > + queues to split ingress packets into multiple segments according to the > + specified lengths into the buffers allocated from the specified > + memory pools. The backward compatibility to existing API is preserved. > + > * ethdev: ``rx_descriptor_done`` dev_ops and ``rte_eth_rx_descriptor_done`` > will be deprecated in 20.11 and will be removed in 21.11. > Existing ``rte_eth_rx_descriptor_status`` and ``rte_eth_tx_descriptor_status`` > -- > 1.8.3.1 >